Re: [Development] Qt 5.6.0 header diff: QtCore.diff

2015-09-21 Thread Knoll Lars
APIs look good, just two doc fixes: https://codereview.qt-project.org/#/c/126153/ https://codereview.qt-project.org/#/c/126154/ Cheers, Lars ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/developm

Re: [Development] Qt 5.6.0 header diff: QtCore.diff

2015-09-17 Thread Thiago Macieira
On Thursday 17 September 2015 18:17:01 Sune Vuorela wrote: > > -// undocumented: > > -static const quint64 MaxSize =3D (1 << 30) - sizeof(Data); > > - > Even though it is marked as undocumented, it does look slightly fishy to > me. You were not supposed to use it. If you did, your code is

Re: [Development] Qt 5.6.0 header diff: QtCore.diff

2015-09-17 Thread Sune Vuorela
On 2015-09-17, Frederik Gladhorn wrote: > --- a/src/corelib/tools/qbytearray.h > +++ b/src/corelib/tools/qbytearray.h > @@ -43,6 +43,7 @@ > #include >=20 > #include > +#include >=20 > #ifdef truncate > #error qbytearray.h must be included before any header file that defin= > es truncate > @