Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Marc Mutz
On Monday 08 June 2015 15:29:46 Thiago Macieira wrote: > On Monday 08 June 2015 15:26:26 Marc Mutz wrote: > > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > > return a QTemporaryDir (which > > > implies passing in by output parameter) > > > > > > > > Or simply return QSharedPointer..

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:26:26 Marc Mutz wrote: > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > return a QTemporaryDir (which > > implies passing in by output parameter) > > Or simply return QSharedPointer... Right, but no one has done it yet. -- Thiago Macieira - thiago.macieira

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Oswald Buddenhagen
On Mon, Jun 08, 2015 at 03:26:26PM +0200, Marc Mutz wrote: > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > return a QTemporaryDir (which > > implies passing in by output parameter) > > Or simply return QSharedPointer... > smart pointers in the api are not liked by binding authors

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Marc Mutz
On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > return a QTemporaryDir (which > implies passing in by output parameter) Or simply return QSharedPointer... -- Marc Mutz | Senior Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company Tel: +49-30-521325470 KDAB - The Q

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:47 Frederik Gladhorn wrote: > +Q_TESTLIB_EXPORT QString qExtractTestData(const QString &dirName); > This API isn't finished. The function needs to return a QTemporaryDir (which implies passing in by output parameter) so that the caller properly cleans up the ex

[Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/testlib/qbenchmark.h b/src/testlib/qbenchmark.h index de4f9a1..9481e91 100644 --- a/src/testlib/qbenchmark.h +++ b/src/testlib/qbenchmark.h @@ -70,7 +70,7 @@ template<> inline char *toString(const QLatin1String &str) template<> inline char *toString(const QByteArray &ba) { -