Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:11:30 Frederik Gladhorn wrote: > +static bool startTcpDebugServer(int port, bool block = false, > +const QString &hostName = QString()); boolean argument should be an enum. -- Marc Mutz | Senior Software Engineer KDAB (Deutschlan

Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 12:24:36 Simon Hausmann wrote: > Those changes were not on qqmlerror.h but on qqmlfile.h. However the class > in question - while exported - is marked as \internal in the docs. > > If it's ok with everyone, then I'll rename qqmfile.h into qqmlfile_p.h. If it is not used, s

Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-05 Thread Simon Hausmann
On Friday, June 05, 2015 10:11:30 AM Frederik Gladhorn wrote: > There's a bug in this diff: --- a/src/qml/qml/qqmlerror.h +++ b/src/qml/qml/qqmlerror.h @@ -68,8 +68,6 @@ public: const char *data() const; QByteArray dataByteArray() const; -QByteArray metaData(const QString &) cons

[Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/qml/debugger/qqmldebug.h b/src/qml/debugger/qqmldebug.h index 876d068..bb90c4f 100644 --- a/src/qml/debugger/qqmldebug.h +++ b/src/qml/debugger/qqmldebug.h @@ -35,6 +35,7 @@ #define QQMLDEBUG_H #include +#include QT_BEGIN_NAMESPACE @@ -42,6 +43,8 @@ QT_BEGIN_NAMESPACE s