Re: [Development] Qt 5.5.0 header diff: QtWebEngineCore.diff (sorry 5.6.0)

2015-09-25 Thread Allan Sandfeld Jensen
Posted to wrong thread, this is is of course for 5.6 On Friday 25 September 2015, Allan Sandfeld Jensen wrote: > Also posting the new APIs from QtWebEncoreCore ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/l

[Development] Qt 5.5.0 header diff: QtWebEngineCore.diff

2015-09-25 Thread Allan Sandfeld Jensen
Also posting the new APIs from QtWebEncoreCore diff --git a/src/core/api/qtwebenginecoreglobal.h b/src/core/api/qtwebenginecoreglobal.h new file mode 100644 index 000..16daaab --- /dev/null +++ b/src/core/api/qtwebenginecoreglobal.h @@ -0,0 +1,50 @@ +/***

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Friday 12 June 2015 00:28:05 Marc Mutz wrote: > On Thursday 11 June 2015 22:07:00 André Pönitz wrote: > > To be blunt: Even though some of the existing patterns and conventions > > are unfashionable in 2015, consistency is a value by itself. Any > > partial "modernization" of the API destroys th

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Thursday 11 June 2015 22:07:00 André Pönitz wrote: > To be blunt: Even though some of the existing patterns and conventions > are unfashionable in 2015, consistency is a value by itself. Any > partial "modernization" of the API destroys that consistency, and > therefore value. So even if "use pa

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread André Pönitz
On Thu, Jun 11, 2015 at 08:55:24AM +, Knoll Lars wrote: > >On Tuesday 09 June 2015 13:35:14 Oswald Buddenhagen wrote: > >> On Tue, Jun 09, 2015 at 10:59:32AM +, Heikkinen Jani wrote: > >> > Hi, > >> > > >> > I tried to create error reports about the findings to be able to > >> > follow-up

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Knoll Lars
On 11/06/15 16:26, "Marc Mutz" wrote: >On Thursday 11 June 2015 13:56:12 Knoll Lars wrote: >> >- QAbstractVideoFilter should re-use QObject::d_ptr instead of adding >>its >> >own >> > (though its unclear why it's inheriting QObject in the first place). >> >> It could, since the module depends o

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Knoll Lars
On 11/06/15 16:33, "Marc Mutz" wrote: >On Thursday 11 June 2015 13:43:15 Knoll Lars wrote: >> Well, QSslEllipticCurve is problematic IMO. The class only contains one >> int and accesses it inline. Since we might have other backends than >> openssl implementing this in the future, I’d like have th

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread André Somers
Marc Mutz schreef op 11-6-2015 om 16:33: > BTW: Can someone send a summary of Qt 5.6 vs. C++11 to the ML, for > those that couldn't attend? I made notes. Available from here: https://wiki.qt.io/QtCS2015_ModernCpp André ___ Development mailing list De

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Thursday 11 June 2015 13:43:15 Knoll Lars wrote: > Well, QSslEllipticCurve is problematic IMO. The class only contains one > int and accesses it inline. Since we might have other backends than > openssl implementing this in the future, I’d like have this non inline and > a qint64 as data type (s

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Thursday 11 June 2015 13:56:12 Knoll Lars wrote: > >- QAbstractVideoFilter should re-use QObject::d_ptr instead of adding its > >own > > (though its unclear why it's inheriting QObject in the first place). > > It could, since the module depends on private apis in Qt Core anyway. > Still, no sh

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Knoll Lars
On 11/06/15 14:19, "Marc Mutz" wrote: >On Thursday 11 June 2015 12:29:06 Knoll Lars wrote: >> A src/multimedia/camera/qcameraviewfindersettings.h > >Aprt from the changes already uploaded to Gerrit, I would suggest to use >the >new QCamera::FrameRateRange class instead of separate >minimumFrameR

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Knoll Lars
On 11/06/15 12:29, "Knoll Lars" wrote: >qtwebengine > >A src/webenginewidgets/api/qwebenginedownloaditem.h >A src/webenginewidgets/api/qwebengineprofile.h >A src/webenginewidgets/api/qwebenginescript.h >A src/webenginewidgets/api/qwebenginescriptcollection.h Some smaller issues here, talked to

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Knoll Lars
On 11/06/15 14:28, "Marc Mutz" wrote: >On Thursday 11 June 2015 12:29:06 Knoll Lars wrote: >> A src/network/ssl/qsslellipticcurve.h >> A src/network/ssl/qsslpresharedkeyauthenticator.h > >Fine imho (but I was partially involved in their upbringing, so another >set of >eyes wouldn't hurt). Well,

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Thursday 11 June 2015 12:29:06 Knoll Lars wrote: > A src/network/ssl/qsslellipticcurve.h > A src/network/ssl/qsslpresharedkeyauthenticator.h Fine imho (but I was partially involved in their upbringing, so another set of eyes wouldn't hurt). -- Marc Mutz | Senior Software Engineer KDAB (Deut

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Thursday 11 June 2015 12:29:06 Knoll Lars wrote: > Qt Location: The APIs underwent some changes from the 4.8 mobility API, > but the module got a good review during Nokia times. The QtMultimedia changes I uploaded and described in my previous mail show what - IMHO - needs to be done to each of

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Thursday 11 June 2015 12:29:06 Knoll Lars wrote: > A src/multimedia/camera/qcameraviewfindersettings.h Aprt from the changes already uploaded to Gerrit, I would suggest to use the new QCamera::FrameRateRange class instead of separate minimumFrameRate/maximumFrameRate properties. That *may* i

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Knoll Lars
On 11/06/15 10:55, "Knoll Lars" wrote: >On 11/06/15 11:38, "Marc Mutz" wrote: > >>On Tuesday 09 June 2015 13:35:14 Oswald Buddenhagen wrote: >>> On Tue, Jun 09, 2015 at 10:59:32AM +, Heikkinen Jani wrote: >>> > Hi, >>> > >>> > I tried to create error reports about the findings to be able to

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Knoll Lars
On 11/06/15 11:38, "Marc Mutz" wrote: >On Tuesday 09 June 2015 13:35:14 Oswald Buddenhagen wrote: >> On Tue, Jun 09, 2015 at 10:59:32AM +, Heikkinen Jani wrote: >> > Hi, >> > >> > I tried to create error reports about the findings to be able to >> > follow-up the progress. Please create new

Re: [Development] Qt 5.5.0 header diff

2015-06-11 Thread Marc Mutz
On Tuesday 09 June 2015 13:35:14 Oswald Buddenhagen wrote: > On Tue, Jun 09, 2015 at 10:59:32AM +, Heikkinen Jani wrote: > > Hi, > > > > I tried to create error reports about the findings to be able to > > follow-up the progress. Please create new one if something is missing. > > the point wa

Re: [Development] Qt 5.5.0 header diff: QtQuick.diff

2015-06-09 Thread Alan Alpert
On Sat, Jun 6, 2015 at 1:14 AM, Thiago Macieira wrote: > On Friday 05 June 2015 10:11:20 Frederik Gladhorn wrote: >> > Looks good. Looks good to me as well. I'll try to produce a QML API diff to look through later today. -- Alan Alpert ___ Development

Re: [Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-09 Thread Alan Alpert
I started working on something that would diff QML API changes a while ago: https://codereview.qt-project.org/#/c/52625/ It's a little tricky, but it basically is just diffing the plugins.qmltypes files. After regenerating them and having old "full" copies because of the manual editing that occurs

Re: [Development] Qt 5.5.0 header diff

2015-06-09 Thread Knoll Lars
On 09/06/15 16:41, "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Thiago Macieira" wrote: >On Tuesday 09 June 2015 07:35:45 Knoll Lars wrote: >> On 08/06/15 23:58, "development-bounces+lars.knoll=theqtcompany.com@qt- >project.org on behalf of Thiago Macieira" bo

Re: [Development] Qt 5.5.0 header diff: QtWidgets.diff

2015-06-09 Thread Marc Mutz
On Tuesday 09 June 2015 17:40:59 Sorvig Morten wrote: > > On 08 Jun 2015, at 11:07, Marc Mutz wrote: > > > > On Friday 05 June 2015 10:11:27 Frederik Gladhorn wrote: > >> diff --git a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h > >> b/src/widgets/widgets/qmaccocoaviewcontainer_mac.h index >

Re: [Development] Qt 5.5.0 header diff: QtWidgets.diff

2015-06-09 Thread Sorvig Morten
> On 08 Jun 2015, at 11:07, Marc Mutz wrote: > > On Friday 05 June 2015 10:11:27 Frederik Gladhorn wrote: >> diff --git a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h >> b/src/widgets/widgets/qmaccocoaviewcontainer_mac.h index a98d30f..5920c1f >> 100644 >> --- a/src/widgets/widgets/qmaccocoa

Re: [Development] Qt 5.5.0 header diff

2015-06-09 Thread Thiago Macieira
On Tuesday 09 June 2015 07:35:45 Knoll Lars wrote: > On 08/06/15 23:58, "development-bounces+lars.knoll=theqtcompany.com@qt- project.org on behalf of Thiago Macieira" wrote: > >On Monday 08 June 2015 22:31:15 Marc Mutz wrote: > >> It would probably be a good idea to do an additional header diff (i

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-09 Thread Thiago Macieira
On Tuesday 09 June 2015 12:10:02 Olivier Goffart wrote: > A change in the IsGadget flag is fine. > > Old code did not need this flag. And code that relies on it requires anyway > that the code that register the types register the isGadget flag. > > Even if one could build a complicated use case t

Re: [Development] Qt 5.5.0 header diff

2015-06-09 Thread Oswald Buddenhagen
On Tue, Jun 09, 2015 at 10:59:32AM +, Heikkinen Jani wrote: > Hi, > > I tried to create error reports about the findings to be able to follow-up > the progress. Please create new one if something is missing. > the point was about the entirely new headers that were not in the diffs, i.e., enti

Re: [Development] Qt 5.5.0 header diff

2015-06-09 Thread Heikkinen Jani
Original Message- >>From: development-bounces+jani.heikkinen=theqtcompany.com@qt- >>project.org [mailto:development- >>bounces+jani.heikkinen=theqtcompany@qt-project.org] On Behalf Of >>Oswald Buddenhagen >>Sent: 9. kesäkuuta 2015 12:49 >>To: development@qt-proj

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-09 Thread Olivier Goffart
On Monday 8. June 2015 17:57:23 Thiago Macieira wrote: > On Monday 08 June 2015 15:58:23 Olivier Goffart wrote: > > > > There is no reason to stop improving qmetatype. > > > > > > The qFatal was there for a good reason. > > > > It was there for a good reason for the existing flags. > > But for ne

Re: [Development] Qt 5.5.0 header diff

2015-06-09 Thread Oswald Buddenhagen
On Tue, Jun 09, 2015 at 07:35:45AM +, Knoll Lars wrote: > On 08/06/15 23:58, > "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of > Thiago Macieira" > thiago.macie...@intel.com> wrote: > > >On Monday 08 June 2015 22:31:15 Marc Mutz wrote: > >> It would probably be

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-09 Thread Marc Mutz
On Tuesday 09 June 2015 00:27:40 Thiago Macieira wrote: > But Qt API that doesn't explicitly need an array for the data should > continue to use QList. I disagree insofar as it concerns new types. Either a new type put into a QList is optimally efficient (sizeof == sizeof void* and at least Q_M

Re: [Development] Qt 5.5.0 header diff

2015-06-09 Thread Knoll Lars
On 08/06/15 23:58, "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Thiago Macieira" wrote: >On Monday 08 June 2015 22:31:15 Marc Mutz wrote: >> It would probably be a good idea to do an additional header diff (incl. new >> headers) on the ML after the alpha. I do

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Alex Montgomery
On Mon, Jun 8, 2015 at 3:27 PM, Thiago Macieira wrote: > On Tuesday 09 June 2015 00:12:47 Milian Wolff wrote: > > Sorry Thiago, but imo your answers are not on topic: The documentation is > > /wrong/. QList is _not_ the right container class to use "for most > > purposes". If, inside Qt, it is cu

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Tuesday 09 June 2015 00:12:47 Milian Wolff wrote: > Sorry Thiago, but imo your answers are not on topic: The documentation is > /wrong/. QList is _not_ the right container class to use "for most > purposes". If, inside Qt, it is currently (ab)used for historical reasons, > well then fine. But ca

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Milian Wolff
On Monday 08 June 2015 17:50:31 Thiago Macieira wrote: > On Monday 08 June 2015 15:40:01 Milian Wolff wrote: > > On Monday 08 June 2015 09:32:42 Thiago Macieira wrote: > > > On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > > > > On 08-Jun-15 15:38, Marc Mutz wrote: > > > > > QList should be

Re: [Development] Qt 5.5.0 header diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 22:31:15 Marc Mutz wrote: > It would probably be a good idea to do an additional header diff (incl. new > headers) on the ML after the alpha. I don't follow the development of > modules other than QtBase closely, nor do I want to, and apparently I'm too > strict a reviewer t

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:58:23 Olivier Goffart wrote: > > > There is no reason to stop improving qmetatype. > > > > > > > > The qFatal was there for a good reason. > > It was there for a good reason for the existing flags. > But for new flags of course it does not make sens. It did make sense:

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:40:01 Milian Wolff wrote: > On Monday 08 June 2015 09:32:42 Thiago Macieira wrote: > > On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > > > On 08-Jun-15 15:38, Marc Mutz wrote: > > > > QList should be QVector > > > > > > Speaking of that, should we adjust the foll

Re: [Development] Qt 5.5.0 header diff

2015-06-08 Thread Marc Mutz
On Monday 08 June 2015 15:36:21 Thiago Macieira wrote: > On Thursday 04 June 2015 15:29:10 Frederik Gladhorn wrote: > > It's time for the header diffs, please help review the changes (Qt 5.4.2 > > to 5.5.0) to make sure nothing that was added to the public headers > > slipped through when it should

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Marc Mutz
On Monday 08 June 2015 15:29:46 Thiago Macieira wrote: > On Monday 08 June 2015 15:26:26 Marc Mutz wrote: > > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > > return a QTemporaryDir (which > > > implies passing in by output parameter) > > > > > > > > Or simply return QSharedPointer..

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Olivier Goffart
On Monday 8. June 2015 09:34:30 Thiago Macieira wrote: > On Monday 08 June 2015 11:28:48 Olivier Goffart wrote: > > On Saturday 6. June 2015 11:17:30 Thiago Macieira wrote: > > > On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > > > > > > > > > I can't tell if the qmetatype.h template ma

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:38:21 Marc Mutz wrote: > > +QList supportedViewfinderResolutions( > > +const QCameraViewfinderSettings &settings = > > QCameraViewfinderSettings()) const; > > QList should be QVector We know that QList is defective, but let's keep it in API. We'll get a c

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Milian Wolff
On Monday 08 June 2015 09:32:42 Thiago Macieira wrote: > On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > > On 08-Jun-15 15:38, Marc Mutz wrote: > > > QList should be QVector > > > > Speaking of that, should we adjust the following recommendation in the > > docs? > > > > "For most purpose

Re: [Development] Qt 5.5.0 header diff

2015-06-08 Thread Thiago Macieira
On Thursday 04 June 2015 15:29:10 Frederik Gladhorn wrote: > It's time for the header diffs, please help review the changes (Qt 5.4.2 to > 5.5.0) to make sure nothing that was added to the public headers slipped > through when it shouldn't be there. We seem to be doing API reviews and finding mist

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 11:28:48 Olivier Goffart wrote: > On Saturday 6. June 2015 11:17:30 Thiago Macieira wrote: > > On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > > > > > > I can't tell if the qmetatype.h template magic is binary compatible or > > not. > > As evidenced by a recent p

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > On 08-Jun-15 15:38, Marc Mutz wrote: > > QList should be QVector > > Speaking of that, should we adjust the following recommendation in the docs? > > "For most purposes, QList is the right class to use. Its index-based API > is more conveni

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Oswald Buddenhagen
On Mon, Jun 08, 2015 at 01:17:26PM +, Lopes Yoann wrote: > > > On 08 Jun 2015, at 15:38, Marc Mutz wrote: > > > > On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: > >> +typedef QPair FrameRateRange; > > > > Should be a struct, not a QPair: > > > > FrameRateChange chg = ...; >

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:26:26 Marc Mutz wrote: > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > return a QTemporaryDir (which > > implies passing in by output parameter) > > Or simply return QSharedPointer... Right, but no one has done it yet. -- Thiago Macieira - thiago.macieira

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Lopes Yoann
> On 08 Jun 2015, at 15:38, Marc Mutz wrote: > > On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: >> +typedef QPair FrameRateRange; > > Should be a struct, not a QPair: > > FrameRateChange chg = ...; > chg.first... // what's first??? > chg.second... // what's second??? It’s

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Oswald Buddenhagen
On Mon, Jun 08, 2015 at 03:26:26PM +0200, Marc Mutz wrote: > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > return a QTemporaryDir (which > > implies passing in by output parameter) > > Or simply return QSharedPointer... > smart pointers in the api are not liked by binding authors

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Joerg Bornemann
On 08-Jun-15 15:38, Marc Mutz wrote: > QList should be QVector Speaking of that, should we adjust the following recommendation in the docs? "For most purposes, QList is the right class to use. Its index-based API is more convenient than QLinkedList's iterator-based API, and it is usually faste

Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:11:30 Frederik Gladhorn wrote: > +static bool startTcpDebugServer(int port, bool block = false, > +const QString &hostName = QString()); boolean argument should be an enum. -- Marc Mutz | Senior Software Engineer KDAB (Deutschlan

Re: [Development] Qt 5.5.0 header diff: QtBluetooth.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:11:25 Frederik Gladhorn wrote: > +bool operator==(const QBluetoothHostInfo &other) const; > +bool operator!=(const QBluetoothHostInfo &other) const; > + should be non-member (friends, if needed) -- Marc Mutz | Senior Software Engineer KDAB (Deutschland) GmbH &

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: > +typedef QPair FrameRateRange; Should be a struct, not a QPair: FrameRateChange chg = ...; chg.first... // what's first??? chg.second... // what's second??? > enum Status { > UnavailableStatus, > Unloa

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Marc Mutz
On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > return a QTemporaryDir (which > implies passing in by output parameter) Or simply return QSharedPointer... -- Marc Mutz | Senior Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company Tel: +49-30-521325470 KDAB - The Q

Re: [Development] Qt 5.5.0 header diff: QtLocation.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:10:37 Frederik Gladhorn wrote: > diff --git a/src/location/maps/qgeocodereply.h > b/src/location/maps/qgeocodereply.h index a30a863..f713e42 100644 > --- a/src/location/maps/qgeocodereply.h > +++ b/src/location/maps/qgeocodereply.h > @@ -56,7 +59,7 @@ class QGeoServiceProv

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Olivier Goffart
On Saturday 6. June 2015 11:17:30 Thiago Macieira wrote: > On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > > > I can't tell if the qmetatype.h template magic is binary compatible or not. > As evidenced by a recent push [1] about the IsGadget flag, it isn't. > > I'm going to put a stop

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-08 Thread Giuseppe D'Angelo
Il 06/06/2015 15:26, Thiago Macieira ha scritto: The symmetry only existed because we added them to QSslSocket before QSslCertificate existed. I'd rather new API existed only in QSslConfiguration. That way, we don't need to duplicate in QSslSocket. Richard, Peter, do you concur on this? I can

Re: [Development] Qt 5.5.0 header diff: QtWidgets.diff

2015-06-08 Thread Marc Mutz
On Monday 08 June 2015 11:07:26 Marc Mutz wrote: > On Friday 05 June 2015 10:11:27 Frederik Gladhorn wrote: > > diff --git a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h > > b/src/widgets/widgets/qmaccocoaviewcontainer_mac.h index a98d30f..5920c1f > > 100644 > > --- a/src/widgets/widgets/qmacco

Re: [Development] Qt 5.5.0 header diff: QtWidgets.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:11:27 Frederik Gladhorn wrote: > diff --git a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h > b/src/widgets/widgets/qmaccocoaviewcontainer_mac.h index a98d30f..5920c1f > 100644 > --- a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h > +++ b/src/widgets/widgets/qmaccoco

Re: [Development] Qt 5.5.0 header diff: QtPositioning.diff

2015-06-08 Thread Blasche Alexander
> -Original Message- > Thiago Macieira > On Friday 05 June 2015 10:10:50 Frederik Gladhorn wrote: > > -qreal distanceTo(const QGeoCoordinate &other) const; > > -qreal azimuthTo(const QGeoCoordinate &other) const; > > +Q_INVOKABLE qreal distanceTo(const QGeoCoordinate &other) con

Re: [Development] Qt 5.5.0 header diff: QtQuickWidgets.diff

2015-06-07 Thread Knoll Lars
On 06/06/15 10:04, "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Thiago Macieira" wrote: >On Friday 05 June 2015 10:10:46 Frederik Gladhorn wrote: >> +#ifndef QT_NO_DRAGANDDROP >> +virtual void dragEnterEvent(QDragEnterEvent *); >> +virtual void dragMov

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-07 Thread Knoll Lars
On 06/06/15 15:26, "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Thiago Macieira" wrote: >On Saturday 06 June 2015 14:22:20 Giuseppe D'Angelo wrote: >> Il 06/06/2015 13:27, Thiago Macieira ha scritto: >> > Then why do we need them in QSslSocket? >> >> Technical

Re: [Development] Qt 5.5.0 header diff: QtSvg.diff

2015-06-07 Thread Olivier Goffart
On Saturday 6. June 2015 10:04:09 Thiago Macieira wrote: > On Friday 05 June 2015 10:10:44 Frederik Gladhorn wrote: > > No changes, good. > > We ought to stop revving the version number for libraries that did not > update at all... Maybe there was no API, But if you look a git loog, you will see

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 14:22:20 Giuseppe D'Angelo wrote: > Il 06/06/2015 13:27, Thiago Macieira ha scritto: > > Then why do we need them in QSslSocket? > > Technically they are be needed there, indeed, but I didn't want to cause > an API asymmetry with the other functions for ciphers, certificat

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Giuseppe D'Angelo
Il 06/06/2015 13:27, Thiago Macieira ha scritto: Then why do we need them in QSslSocket? Technically they are be needed there, indeed, but I didn't want to cause an API asymmetry with the other functions for ciphers, certificates and so on, that's all. -- Giuseppe D'Angelo | giuseppe.dang..

Re: [Development] Qt 5.5.0 header diff: QtXml.diff

2015-06-06 Thread Knoll Lars
Looks good. Cheers, Lars On 05/06/15 10:11, "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Frederik Gladhorn" wrote: > ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/list

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 11:30:39 Giuseppe D'Angelo wrote: > Il 06/06/2015 11:20, Thiago Macieira ha scritto: > > These should be in QSslConfiguration, not QSslSocket. > > They're in both, just like ciphers, certificates etc. Then why do we need them in QSslSocket? -- Thiago Macieira - thiago.ma

Re: [Development] Qt 5.5.0 header diff: QtGui.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 11:03:43 Allan Sandfeld Jensen wrote: > On the topic of qpen.h, I am a little concerned about the addition of > Q_DECL_NOTHROW to the two non-inlined methods QPen(const QPen &pen) and > QPen &operator=(const QPen &pen). Q_DECL_NOEXCEPT should be fine I think, > but throw(

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Giuseppe D'Angelo
Il 06/06/2015 11:20, Thiago Macieira ha scritto: These should be in QSslConfiguration, not QSslSocket. They're in both, just like ciphers, certificates etc. -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Software Engineer KDAB (UK) Ltd., a KDAB Group company | Tel: UK +44-1625-809908 KDAB

Re: [Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-06 Thread Liang Qi
On 6 June 2015 at 10:52, Allan Sandfeld Jensen wrote: > On Friday 05 June 2015, Frederik Gladhorn wrote: > > > > Would there be any way to generate diffs or changes for QML APIs? > Perhaps a diff for all plugins.qmltypes files? But I guess that not all were updated yet. -- http://www.qiliang.n

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:29 Frederik Gladhorn wrote: > +// EC settings. > +QVector ellipticCurves() const; > +void setEllipticCurves(const QVector &curves); > +static void setDefaultEllipticCurves(const QVector > &curves); +static QVector defaultEllipticCurves(); > +stat

Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 12:24:36 Simon Hausmann wrote: > Those changes were not on qqmlerror.h but on qqmlfile.h. However the class > in question - while exported - is marked as \internal in the docs. > > If it's ok with everyone, then I'll rename qqmfile.h into qqmlfile_p.h. If it is not used, s

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > I can't tell if the qmetatype.h template magic is binary compatible or not. As evidenced by a recent push [1] about the IsGadget flag, it isn't. I'm going to put a stop to this. qmetatype.h template magic is now frozen as of Qt 5.5 and

Re: [Development] Qt 5.5.0 header diff: QtGui.diff

2015-06-06 Thread Allan Sandfeld Jensen
On Friday 05 June 2015, Frederik Gladhorn wrote: > Something is wrong with the diff. The qpen.h diff is listed as src/gui/painting/qpdfwriter.h. On the topic of qpen.h, I am a little concerned about the addition of Q_DECL_NOTHROW to the two non-inlined methods QPen(const QPen &pen) and QPen &op

Re: [Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-06 Thread Allan Sandfeld Jensen
On Friday 05 June 2015, Frederik Gladhorn wrote: > Would there be any way to generate diffs or changes for QML APIs? `Allan ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.5.0 header diff: QtSql.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:26 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtBluetooth.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:25 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtOpenGL.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:23 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtScriptTools.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:22 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtPrintSupport.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:21 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtQuick.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:20 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtWebSockets.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:19 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtMultimediaWidgets.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:53 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtX11Extras.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:54 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:49 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtScript.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:51 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtPositioning.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:50 Frederik Gladhorn wrote: > -qreal distanceTo(const QGeoCoordinate &other) const; > -qreal azimuthTo(const QGeoCoordinate &other) const; > +Q_INVOKABLE qreal distanceTo(const QGeoCoordinate &other) const; > +Q_INVOKABLE qreal azimuthTo(const QGeoCoordi

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:47 Frederik Gladhorn wrote: > +Q_TESTLIB_EXPORT QString qExtractTestData(const QString &dirName); > This API isn't finished. The function needs to return a QTemporaryDir (which implies passing in by output parameter) so that the caller properly cleans up the ex

Re: [Development] Qt 5.5.0 header diff: QtSerialPort.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:47 Frederik Gladhorn wrote: > +#if QT_DEPRECATED_SINCE(5, 2) > +QT_DEPRECATED void dataErrorPolicyChanged(QSerialPort::DataErrorPolicy > policy); > +#endif > void dataTerminalReadyChanged(bool set); > void requestToSendChanged(bool set); > void error

Re: [Development] Qt 5.5.0 header diff: QtQuickWidgets.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:46 Frederik Gladhorn wrote: > +#ifndef QT_NO_DRAGANDDROP > +virtual void dragEnterEvent(QDragEnterEvent *); > +virtual void dragMoveEvent(QDragMoveEvent *); > +virtual void dragLeaveEvent(QDragLeaveEvent *); > +virtual void dropEvent(QDropEvent *); > +#e

Re: [Development] Qt 5.5.0 header diff: QtXmlPatterns.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:45 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtWebChannel.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:43 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtSvg.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:44 Frederik Gladhorn wrote: > No changes, good. We ought to stop revving the version number for libraries that did not update at all... -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center __

Re: [Development] Qt 5.5.0 header diff: QtMultimediaQuick_p.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:42 Frederik Gladhorn wrote: > Private library. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://li

Re: [Development] Qt 5.5.0 header diff: QtNfc.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:41 Frederik Gladhorn wrote: > +//TODO Qt 6 the mimetype should be QString as it is UTF-8 Looks good, except the comment. We usually use "### Qt6" as a marker, not "TODO". -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source

Re: [Development] Qt 5.5.0 header diff: QtConcurrent.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:39 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtGui.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:38 Frederik Gladhorn wrote: > +++ b/src/gui/accessible/qaccessible.h > @@ -60,7 +60,6 @@ class QTextCursor; > class Q_GUI_EXPORT QAccessible > @@ -635,6 +636,12 @@ public: > static const QString &showMenuAction(); > static const QString &setFocusAction(); >

Re: [Development] Qt 5.5.0 header diff: QtLocation.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:37 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

  1   2   >