Re: [Development] Qt 5.4.0 header diff: QtGui.diff

2014-11-19 Thread Knoll Lars
On 19/11/14 11:59, "Knoll Lars" wrote: >>API and style mistake -- the new constructor should very likely be >>protected (useful only from subclasses?), but the private should be >>passed by reference (or "QOpenGLPaintDevice(0)" gives a cryptic error): >> >>> class Q_GUI_EXPORT QOpenGLPaintDevic

Re: [Development] Qt 5.4.0 header diff: QtGui.diff

2014-11-19 Thread Knoll Lars
On 19/11/14 10:43, "Giuseppe D'Angelo" wrote: >ABI break (changing a private static in a public exported class)? > >> --- a/src/gui/text/qfontdatabase.h >> +++ b/src/gui/text/qfontdatabase.h >> @@ -160,14 +152,14 @@ private: >> static void createDatabase(); >> static void parseFontName(

Re: [Development] Qt 5.4.0 header diff: QtGui.diff

2014-11-19 Thread Giuseppe D'Angelo
ABI break (changing a private static in a public exported class)? --- a/src/gui/text/qfontdatabase.h +++ b/src/gui/text/qfontdatabase.h @@ -160,14 +152,14 @@ private: static void createDatabase(); static void parseFontName(const QString &name, QString &foundry, QString &family);

Re: [Development] Qt 5.4.0 header diff: QtGui.diff

2014-11-19 Thread Giuseppe D'Angelo
Il 19/11/2014 01:23, Thiago Macieira ha scritto: On Tuesday 18 November 2014 16:38:33 Frederik Gladhorn wrote: Attaching simpler diff. The diff is still huge because it trips over a massive change in Khronos headers, which are 3rd party -- we have no control over those. Should we move them