Re: [Development] Qt 5.4.0 header diff: QtCore.diff

2014-11-18 Thread Thiago Macieira
On Wednesday 19 November 2014 08:52:41 Morten Johan Sørvig wrote: > > On 19 Nov 2014, at 02:22, Thiago Macieira > > wrote: > > > > Impressive number of "### Qt6" comments we're adding... > > Should we mandate that the pattern for doing this is > > #if QT_VERSION >= QT_VERSION_CHECK(6,0,0) > >

Re: [Development] Qt 5.4.0 header diff: QtCore.diff

2014-11-18 Thread Morten Johan Sørvig
> On 19 Nov 2014, at 02:22, Thiago Macieira wrote: > > Impressive number of "### Qt6" comments we're adding... Should we mandate that the pattern for doing this is #if QT_VERSION >= QT_VERSION_CHECK(6,0,0) and then actually writing the Qt 6 code? There are a couple of instances of this alrea

Re: [Development] Qt 5.4.0 header diff: QtCore.diff

2014-11-18 Thread Thiago Macieira
Impressive number of "### Qt6" comments we're adding... qjsonobject.h > -//typedef T *pointer; > typedef QJsonValueRef reference; Missing typedef for pointer, like was done for QJsonArray > --- a/src/corelib/thread/qmutex.h > +++ b/src/corelib/thread/qmutex.h > @@ -101,10 +93,6