Re: [Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-05 Thread Marc Mutz
On Tuesday, November 05, 2013 18:00:02 Nicolás Alvarez wrote: > 2013/11/5 Marc Mutz : > > On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote: > >> -return (void *)qptrdiff(data); > >> +char *null = 0; > >> +return null + qptrdiff(data); > > > > Since t

Re: [Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-05 Thread Nicolás Alvarez
2013/11/5 Marc Mutz : > On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote: >> -return (void *)qptrdiff(data); >> +char *null = 0; >> +return null + qptrdiff(data); > > Since this is equivalent to > > return 0[qptrdiff(data)]; > > isn't that derefer

Re: [Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-05 Thread Thiago Macieira
On terça-feira, 5 de novembro de 2013 12:24:32, Marc Mutz wrote: > On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote: > > -return (void *)qptrdiff(data); > > +char *null = 0; > > +return null + qptrdiff(data); > > Since this is equivalent to > >

Re: [Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-05 Thread Marc Mutz
On Tuesday, November 05, 2013 12:24:32 Marc Mutz wrote: > What's wrong with > >reinterpret_cast(qptrdiff(data)); -> https://codereview.qt-project.org/70402 ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/l

Re: [Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-05 Thread Olivier Goffart
On Tuesday 05 November 2013 12:24:32 Marc Mutz wrote: > On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote: > > -return (void *)qptrdiff(data); > > +char *null = 0; > > +return null + qptrdiff(data); > > Since this is equivalent to > > return 0[qp

Re: [Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-05 Thread Marc Mutz
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote: > -return (void *)qptrdiff(data); > +char *null = 0; > +return null + qptrdiff(data); Since this is equivalent to return 0[qptrdiff(data)]; isn't that dereferencing the nullptr and therefore und

Re: [Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-04 Thread Thiago Macieira
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote: > Module is fine. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___

[Development] Qt 5.2 header diff: QtXmlPatterns

2013-11-04 Thread Thiago Macieira
Pastebin URL (expires in 24 hours): http://paste.fedoraproject.org/51645/13836114 --- diff --git a/src/xmlpatterns/api/qabstractxmlnodemodel.h b/src/xmlpatterns/api/qabstractxmlnodemodel.h index 0bdf9c4..98148f7 100644 --- a/src/xmlpatterns/api/qabstractxmlnodemodel.h +++ b/src/xmlpatterns/api/qa