On Fri, Nov 8, 2013 at 4:59 AM, Heikkinen Jani wrote:
> Hi all,
>
>
>
> What is the situation with reviews & especially potential fixes? Is all
> needed now done and so on can we start merge on Monday morning?
https://codereview.qt-project.org/#change,70479 still needs to merge.
It should be read
Il 09/11/2013 18:03, Marc Mutz ha scritto:
For QtWidgets, we're discussing for the following API issue:
https://codereview.qt-project.org/70730
The patch has been merged and I've closed the associated bug.
Thanks,
--
Join us at Qt Developer Days 2013! - https://devdays.kdab.com
Giuseppe D'A
On Friday, November 08, 2013 13:59:00 Heikkinen Jani wrote:
> Hi all,
>
> What is the situation with reviews & especially potential fixes? Is all
> needed now done and so on can we start merge on Monday morning?
For QtWidgets, we're discussing for the following API issue:
https://codereview.qt-
Hi all,
What is the situation with reviews & especially potential fixes? Is all needed
now done and so on can we start merge on Monday morning?
Br,
Jani
--
Jani Heikkinen
Release Manager
__
On Tue, Nov 5, 2013 at 1:36 PM, Thiago Macieira
wrote:
> On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
> >
>
> Module is fine.
>
+1
--
Jason
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/
On 05 Nov 2013, at 19:17, Shaw Andy wrote:
> IIRC it wasn’t even compiled into the QtWidgets library, although the
> documentation and everything existed, those symbols were never in Qt. Morten
> can say 100% at least but that is my understanding and recollection at least.
That is correct, th
There is unnecessary include of QtCore/qcoreapplication.h (in
src/gui/accessible/qaccessible.h:48).
2013/11/5 Thiago Macieira
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
__
Module looks ok. Some comment inline:
On 05/11/13 01:07, "Thiago Macieira" wrote:
>Pastebin URL (expires in 24 hours):
>http://paste.fedoraproject.org/51637/13836114
>
>template
> QObject *qmlAttachedPropertiesObject(const QObject *obj, bool create =
>true)
> {
>diff --git a/src/qml/qml/qqmlcomp
Looks ok as well.
Cheers,
Lars
On 05/11/13 01:07, "Thiago Macieira" wrote:
>Pastebin URL (expires in 24 hours):
>http://paste.fedoraproject.org/51638/61143313
>
>---
>diff --git a/src/quick/designer/designersupport.h
>b/src/quick/designer/designersupport.h
>index 5139a65..41458ae 100644
>--- a
t.org
[mailto:development-bounces+andy.shaw=digia@qt-project.org] On Behalf Of
Jake Petroules
Sent: 5. november 2013 19:10
To: Thiago Macieira
Cc: development@qt-project.org
Subject: Re: [Development] Qt 5.2 header diff: QtWidgets
On Nov 5, 2013, at 12:55 PM, Thiago Macieira
mailto:thiago.
On Nov 5, 2013, at 12:55 PM, Thiago Macieira wrote:
> On terça-feira, 5 de novembro de 2013 12:39:55, Jake Petroules wrote:
>> On Nov 5, 2013, at 12:22 PM, Marc Mutz wrote:
>>> But can be overloaded on the new types, right.
>>
>> Does this 100% NEED to be reverted? It wasn't even functional unt
On terça-feira, 5 de novembro de 2013 12:39:55, Jake Petroules wrote:
> On Nov 5, 2013, at 12:22 PM, Marc Mutz wrote:
> > But can be overloaded on the new types, right.
>
> Does this 100% NEED to be reverted? It wasn't even functional until 5.2
> IIRC.
>
> I really hope this does not have to wai
On Nov 5, 2013, at 12:22 PM, Marc Mutz wrote:
> On Tuesday, November 05, 2013 17:51:25 Thiago Macieira wrote:
>> On terça-feira, 5 de novembro de 2013 11:09:48, Giuseppe D'Angelo wrote:
class Q_WIDGETS_EXPORT QMacCocoaViewContainer : public QWidget
{
Q_OBJECT
>>>
On Tuesday, November 05, 2013 17:51:25 Thiago Macieira wrote:
> On terça-feira, 5 de novembro de 2013 11:09:48, Giuseppe D'Angelo wrote:
> > > class Q_WIDGETS_EXPORT QMacCocoaViewContainer : public QWidget
> > > {
> > >
> > > Q_OBJECT
> > >
> > > public:
> > > -QMacCocoaViewCo
On Tuesday, November 05, 2013 18:00:02 Nicolás Alvarez wrote:
> 2013/11/5 Marc Mutz :
> > On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> >> -return (void *)qptrdiff(data);
> >> +char *null = 0;
> >> +return null + qptrdiff(data);
> >
> > Since t
2013/11/5 Marc Mutz :
> On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
>> -return (void *)qptrdiff(data);
>> +char *null = 0;
>> +return null + qptrdiff(data);
>
> Since this is equivalent to
>
> return 0[qptrdiff(data)];
>
> isn't that derefer
On terça-feira, 5 de novembro de 2013 12:24:32, Marc Mutz wrote:
> On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> > -return (void *)qptrdiff(data);
> > +char *null = 0;
> > +return null + qptrdiff(data);
>
> Since this is equivalent to
>
>
On terça-feira, 5 de novembro de 2013 11:09:48, Giuseppe D'Angelo wrote:
> > +#ifdef Q_OS_OSX
> > +NSMenu* toNSMenu();
> > +void setAsDockMenu();
> > +#endif
>
> Is it OK to reintroduce platform specific calls in the APIs? I would've
> expected this kind of functionality to be provided by
On terça-feira, 5 de novembro de 2013 11:09:48, Giuseppe D'Angelo wrote:
> > class Q_WIDGETS_EXPORT QMacCocoaViewContainer : public QWidget
> > {
> > Q_OBJECT
> >
> > public:
> > -QMacCocoaViewContainer(void *cocoaViewToWrap, QWidget *parent = 0);
> > +QMacCocoaViewContainer(NSV
On terça-feira, 5 de novembro de 2013 11:22:45, Marc Mutz wrote:
> On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> > @@ -206,7 +212,8 @@ protected:
> > int qt4D;
> > Qt::Orientation qt4O;
> > Qt::MouseButtons mouseState;
> >
> > -int reserved;
> > +uint ph :
g
Emne: Re: [Development] Qt 5.2 header diff: QtGui
Il 05/11/2013 11:22, Marc Mutz ha scritto:
> On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
>> @@ -206,7 +212,8 @@ protected:
>> int qt4D;
>> Qt::Orientation qt4O;
>> Qt::MouseButtons mouseState;
On Tuesday, November 05, 2013 12:24:32 Marc Mutz wrote:
> What's wrong with
>
>reinterpret_cast(qptrdiff(data));
-> https://codereview.qt-project.org/70402
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/l
On Tuesday 05 November 2013 12:24:32 Marc Mutz wrote:
> On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> > -return (void *)qptrdiff(data);
> > +char *null = 0;
> > +return null + qptrdiff(data);
>
> Since this is equivalent to
>
> return 0[qp
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> -return (void *)qptrdiff(data);
> +char *null = 0;
> +return null + qptrdiff(data);
Since this is equivalent to
return 0[qptrdiff(data)];
isn't that dereferencing the nullptr and therefore und
On 11/05/2013 04:38 AM, Thiago Macieira wrote:
> On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>> +QByteArray session() const;
>> +void setSession(const QByteArray &session);
>> +int sessionTicketLifeTimeHint() const;
>
> Module is fine.
>
> I'm just wondering
Il 05/11/2013 11:22, Marc Mutz ha scritto:
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
@@ -206,7 +212,8 @@ protected:
int qt4D;
Qt::Orientation qt4O;
Qt::MouseButtons mouseState;
-int reserved;
+uint ph : 2;
+int reserved : 30;
};
#endif
is s
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> @@ -101,9 +102,10 @@ public:
> {
> if (dirty) {
> dirty = false;
> -QVector sorted = values;
> -qSort(sorted);
> -currentMedian = sorted.at(bufferSize / 2 + 1);
> +
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
> @@ -206,7 +212,8 @@ protected:
> int qt4D;
> Qt::Orientation qt4O;
> Qt::MouseButtons mouseState;
> -int reserved;
> +uint ph : 2;
> +int reserved : 30;
> };
> #endif
is sizeof(int) == 4 everywhere?
> ---
Il 05/11/2013 01:07, Thiago Macieira ha scritto:
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51643/61145013
---
diff --git a/src/widgets/dialogs/qcolordialog.h
b/src/widgets/dialogs/qcolordialog.h
index 80a31c4..c7a1d6f 100644
--- a/src/widgets/dialogs/qcolordialog.h
+++
On segunda-feira, 4 de novembro de 2013 17:25:45, Thiago Macieira wrote:
> qmetatype.h:
> > +#include
> > +#include
> > +#include
>
> Argh. Thanks for making the compilation that much slower. These three lines
> probably impact Qt's compilation time in 20%, or more.
With those three lines, sr
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>
Module is fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
_
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
> +QByteArray session() const;
> +void setSession(const QByteArray &session);
> +int sessionTicketLifeTimeHint() const;
Module is fine.
I'm just wondering if the "session" property should not instead be called
"
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>
Module is fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
_
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>
Module is fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
___
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>
Module is fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
_
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>
Module is fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
___
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>
Module is fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
>
Module is fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
___
In case anyone's wondering why a deprecated module had a header
change, it was just a backport of removing a compiler warning (VS2010
specific). No new functionality here.
--
Alan Alpert
___
Development mailing list
Development@qt-project.org
http://list
I didn't find anything, but I did not review qmetatype.h. These are just
comments and explanations.
On segunda-feira, 4 de novembro de 2013 16:07:32, Thiago Macieira wrote:
qlogging.h:
> -enum QtMsgType { QtDebugMsg, QtWarningMsg, QtCriticalMsg, QtFatalMsg,
> QtSystemMsg = QtCriticalMsg };
> +e
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51643/61145013
---
diff --git a/src/widgets/dialogs/qcolordialog.h b/src/widgets/dialogs/qcolordialog.h
index 80a31c4..c7a1d6f 100644
--- a/src/widgets/dialogs/qcolordialog.h
+++ b/src/widgets/dialogs/qcolordialog.h
@@ -112,6 +112
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51644/38361145
---
diff --git a/src/x11extras/qx11info_x11.h b/src/x11extras/qx11info_x11.h
index afc9ee4..d5d00f3 100644
--- a/src/x11extras/qx11info_x11.h
+++ b/src/x11extras/qx11info_x11.h
@@ -53,6 +53,8 @@ QT_BEGIN_NAMESPACE
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51642/83611445
---
diff --git a/src/testlib/qtestcase.h b/src/testlib/qtestcase.h
index 6b5e7a5..ba727b5 100644
--- a/src/testlib/qtestcase.h
+++ b/src/testlib/qtestcase.h
@@ -200,6 +200,8 @@ namespace QTest
Q_TESTLIB_EXPORT
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51645/13836114
---
diff --git a/src/xmlpatterns/api/qabstractxmlnodemodel.h b/src/xmlpatterns/api/qabstractxmlnodemodel.h
index 0bdf9c4..98148f7 100644
--- a/src/xmlpatterns/api/qabstractxmlnodemodel.h
+++ b/src/xmlpatterns/api/qa
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51638/61143313
---
diff --git a/src/quick/designer/designersupport.h b/src/quick/designer/designersupport.h
index 5139a65..41458ae 100644
--- a/src/quick/designer/designersupport.h
+++ b/src/quick/designer/designersupport.h
@@ -80
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51641/38361144
---
diff --git a/src/serialport/qserialport.h b/src/serialport/qserialport.h
index e035ee3..e173445 100644
--- a/src/serialport/qserialport.h
+++ b/src/serialport/qserialport.h
@@ -55,6 +55,7 @@ class QSerialPortPri
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51640/11437138
---
diff --git a/src/sensors/qpressuresensor.h b/src/sensors/qpressuresensor.h
index 2a544cb..8a14d41 100644
--- a/src/sensors/qpressuresensor.h
+++ b/src/sensors/qpressuresensor.h
@@ -51,10 +51,14 @@ class Q_SENSOR
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51637/13836114
---
diff --git a/src/qml/debugger/qqmldebug.h b/src/qml/debugger/qqmldebug.h
index d2b0220..d6b6bb0 100644
--- a/src/qml/debugger/qqmldebug.h
+++ b/src/qml/debugger/qqmldebug.h
@@ -54,9 +54,9 @@ struct Q_QML_EXPORT
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51636/11423138
---
diff --git a/src/printsupport/dialogs/qprintdialog.h b/src/printsupport/dialogs/qprintdialog.h
index 7d77c6a..c822aa0 100644
--- a/src/printsupport/dialogs/qprintdialog.h
+++ b/src/printsupport/dialogs/qprintdia
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51635/83611419
---
diff --git a/src/network/access/qnetworkaccessmanager.h b/src/network/access/qnetworkaccessmanager.h
index 826c8e4..67b9bbc 100644
--- a/src/network/access/qnetworkaccessmanager.h
+++ b/src/network/access/qnetwo
Pastebin URL (expires in 24 hours):
---
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Pastebin URL (expires in 24 hours):
---
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Pastebin URL (expires in 24 hours):
---
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51630/13836110
---
diff --git a/src/declarative/qml/qdeclarativeprivate.h b/src/declarative/qml/qdeclarativeprivate.h
index 05a457c..6f95dde 100644
--- a/src/declarative/qml/qdeclarativeprivate.h
+++ b/src/declarative/qml/qdeclara
Pastebin URL (expires in 24 hours):
---
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Pastebin URL (expires in 24 hours):
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Pastebin URL (expires in 24 hours):
---
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51628/61095313
---
diff --git a/src/concurrent/qtconcurrentfilterkernel.h b/src/concurrent/qtconcurrentfilterkernel.h
index 63e77ab..29bb3c9 100644
--- a/src/concurrent/qtconcurrentfilterkernel.h
+++ b/src/concurrent/qtconcurrentf
Pastebin URL (expires in 24 hours):
---
diff --git a/src/declarative/qml/qdeclarativeprivate.h b/src/declarative/qml/qdeclarativeprivate.h
index 05a457c..6f95dde 100644
--- a/src/declarative/qml/qdeclarativeprivate.h
+++ b/src/declarative/qml/qdeclarativeprivate.h
@@ -55,6 +55,7 @@
#include
Pastebin URL (expires in 24 hours):
http://paste.fedoraproject.org/51626/38361087
---
diff --git a/src/gui/accessible/qaccessible.h b/src/gui/accessible/qaccessible.h
index 6667cae..25ce161 100644
--- a/src/gui/accessible/qaccessible.h
+++ b/src/gui/accessible/qaccessible.h
@@ -45,6 +45,7 @@
#if
Sending the header diff for Qt 5.2.
Script update: https://codereview.qt-project.org/70327
Results
Modules with no public headers:
QtCompositor
QtDuse
QtMacExtras [*]
QtModeling
QtModelingWidgets
QtMof
QtPlatformSupport
QtQmlDevTools
61 matches
Mail list logo
