On Wed, Jul 8, 2015 at 12:10 PM Thiago Macieira
wrote:
> On Wednesday 08 July 2015 12:07:20 Keith Gardner wrote:
> > > Please take the patches starting at
> > > https://codereview.qt-project.org/95531.
> > > Follow the chain of dependency.
> >
> > Would you like someone to pick up those changes a
On Wednesday 08 July 2015 12:07:20 Keith Gardner wrote:
> > Please take the patches starting at
> > https://codereview.qt-project.org/95531.
> > Follow the chain of dependency.
>
> Would you like someone to pick up those changes and finish them for you? I
> am just asking since you started many of
>
> It's already done and approved. You just need to move qversionnumber_p.h
> back
> to qversionnumber.h in a separate commit and check that the patch series
> still
> applies. IIRC, only the unexporting was applied out-of-order, so you can
> revert that one temporarily, to make the other changes
On Wednesday 08 July 2015 14:07:20 Keith Gardner wrote:
> > Please take the patches starting at
> > https://codereview.qt-project.org/95531.
> > Follow the chain of dependency.
>
> Would you like someone to pick up those changes and finish them for you? I
> am just asking since you started many of
>
> Please take the patches starting at
> https://codereview.qt-project.org/95531.
> Follow the chain of dependency.
>
Would you like someone to pick up those changes and finish them for you? I
am just asking since you started many of them but I know you have a lot on
your plate.
The only change
On Tuesday 07 July 2015 07:38:51 André Somers wrote:
> Thiago Macieira schreef op 7-7-2015 om 01:13:
> > There are about a dozen changes pending between refactorings that I've
> > done
> > and those of Marc on top of mine.
> >
> > The class needs those cleanups before it becomes public API.
> >
>
Thiago Macieira schreef op 7-7-2015 om 01:13:
> There are about a dozen changes pending between refactorings that I've done
> and those of Marc on top of mine.
>
> The class needs those cleanups before it becomes public API.
>
> If there's no interest in reviving the API in the until feature freeze
There are about a dozen changes pending between refactorings that I've done
and those of Marc on top of mine.
The class needs those cleanups before it becomes public API.
If there's no interest in reviving the API in the until feature freeze for 5.6
(even if you actually miss the deadline), I'
