Re: [Development] QVariant::operator< deprecation fallout

2020-11-24 Thread Giuseppe D'Angelo via Development
On 24/11/2020 16:40, Giuseppe D'Angelo via Development wrote: [*] IIUC, that'd be: -DQT_DISABLE_DEPRECATED_BEFORE=0x060001 Then, should it actually be deprecated as 5.255? So asking for 6.0.*0* deprecations would flag it. Well, I've marked everything as 6.0. https://codereview.qt-project.org

Re: [Development] QVariant::operator< deprecation fallout

2020-11-24 Thread Edward Welbourne
>>> I'm guessing you meant generic / special. I'm more keen on keeping >>> everything deprecated, but with a special macro. (Or maybe just bump >>> the deprecation version to 6.0 instead of 5.15?) On 24/11/2020 16:29, Edward Welbourne wrote: >> I think changing the version to 6.0 is a sane option.

Re: [Development] QVariant::operator< deprecation fallout

2020-11-24 Thread Giuseppe D'Angelo via Development
On 24/11/2020 16:29, Edward Welbourne wrote: I'm guessing you meant generic / special. I'm more keen on keeping everything deprecated, but with a special macro. (Or maybe just bump the deprecation version to 6.0 instead of 5.15?) I think changing the version to 6.0 is a sane option. It'll leave

Re: [Development] QVariant::operator< deprecation fallout

2020-11-24 Thread Edward Welbourne
On 23/11/2020 08:48, Fabian Kosmale wrote: >> I think we should at least_somehow_ deprecate operator<; but I'm not >> sure if it should be a special deprecation macro, or a special one. Giuseppe D'Angelo (23 November 2020 15:47) wrote: > I'm guessing you meant generic / special. I'm more keen on k

Re: [Development] QVariant::operator< deprecation fallout

2020-11-23 Thread Giuseppe D'Angelo via Development
Hi, On 23/11/2020 08:48, Fabian Kosmale wrote: I think we should at least_somehow_ deprecate operator<; but I'm not sure if it should be a special deprecation macro, or a special one. I'm guessing you meant generic / special. I'm more keen on keeping everything deprecated, but with a special

Re: [Development] QVariant::operator< deprecation fallout

2020-11-22 Thread Fabian Kosmale
opment@qt-project.org Betreff: [Development] QVariant::operator< deprecation fallout QVariant::operator< has been deprecated in 5.15 because its broken semantics, unable to establish a strict weak order (as expected by "operator<". cf. VALUE.16 of QUIP-19). The problem with this deprecati

[Development] QVariant::operator< deprecation fallout

2020-11-22 Thread Giuseppe D'Angelo via Development
QVariant::operator< has been deprecated in 5.15 because its broken semantics, unable to establish a strict weak order (as expected by "operator<". cf. VALUE.16 of QUIP-19). The problem with this deprecation is that it doesn't offer a replacement. Users that are still on Qt 5.15 and want to get