Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-31 Thread lars.knoll
On 3/31/12 6:41 PM, "ext Giuseppe D'Angelo" wrote: >2012/3/31 Thiago Macieira : >> On sábado, 31 de março de 2012 17.00.17, Davet Jacques wrote: >>> Out of interest: Has there been a final decision to keep the name >>> QRegularExpression (rather than QRegex)? >> >> I like the name. >> >> And I es

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-31 Thread Giuseppe D'Angelo
2012/3/31 Thiago Macieira : > On sábado, 31 de março de 2012 17.00.17, Davet Jacques wrote: >> Out of interest: Has there been a final decision to keep the name >> QRegularExpression (rather than QRegex)? > > I like the name. > > And I especially DO NOT like QRegex because it's too close to the exi

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-31 Thread Thiago Macieira
On sábado, 31 de março de 2012 17.00.17, Davet Jacques wrote: > Out of interest: Has there been a final decision to keep the name > QRegularExpression (rather than QRegex)? I like the name. And I especially DO NOT like QRegex because it's too close to the existing class and might lead to confusio

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-13 Thread Giuseppe D'Angelo
Hi, Some updates on this. After yesterday's discussion it was decided to keep QRegExp in QtCore as a deprecated class. At the same time all QRegExp-related classes or overloads get deprecated as well (although probably not disabled with QT_DEPRECATED_SINCE because very few of them are actually inl

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-06 Thread Giuseppe D'Angelo
Hi, 2012/3/4 Thiago Macieira : > Please stop rebasing. Let the first 4 changes be reviewed and try to go in. The QRegularExpression classes have finally landed in master :-) -- Giuseppe D'Angelo ___ Development mailing list Development@qt-project.org

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-03 Thread Giuseppe D'Angelo
2012/3/4 Thiago Macieira : > On sábado, 3 de março de 2012 14.30.06, Giuseppe D'Angelo wrote: >> > Ok, I'll rebase/push on master and leave QString changes out >> > (targeting api_changes instead). >> >> All done :) > > Now I have to re-review everything because you rebased. > > Please stop rebasin

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-03 Thread Thiago Macieira
On sábado, 3 de março de 2012 14.30.06, Giuseppe D'Angelo wrote: > > Ok, I'll rebase/push on master and leave QString changes out > > (targeting api_changes instead). > > All done :) Now I have to re-review everything because you rebased. Please stop rebasing. Let the first 4 changes be reviewed

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-03 Thread Giuseppe D'Angelo
On 3 March 2012 10:22, Giuseppe D'Angelo wrote: > On 3 March 2012 08:42,   wrote: >> On 3/3/12 9:14 AM, "ext Thiago Macieira" wrote: >> >>>On sábado, 3 de março de 2012 07.13.54, Thiago Macieira wrote: On sábado, 3 de março de 2012 05.17.37, Giuseppe D'Angelo wrote: > NB: Since PCRE lan

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-03 Thread Giuseppe D'Angelo
On 3 March 2012 08:42, wrote: > On 3/3/12 9:14 AM, "ext Thiago Macieira" wrote: > >>On sábado, 3 de março de 2012 07.13.54, Thiago Macieira wrote: >>> On sábado, 3 de março de 2012 05.17.37, Giuseppe D'Angelo wrote: >>> > NB: Since PCRE landed in *master*, there's the need of a merge before >>>

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-03 Thread lars.knoll
On 3/3/12 9:14 AM, "ext Thiago Macieira" wrote: >On sábado, 3 de março de 2012 07.13.54, Thiago Macieira wrote: >> On sábado, 3 de março de 2012 05.17.37, Giuseppe D'Angelo wrote: >> > NB: Since PCRE landed in *master*, there's the need of a merge before >> > staging these ones, but I didn't do i

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-03 Thread Thiago Macieira
On sábado, 3 de março de 2012 07.13.54, Thiago Macieira wrote: > On sábado, 3 de março de 2012 05.17.37, Giuseppe D'Angelo wrote: > > NB: Since PCRE landed in *master*, there's the need of a merge before > > staging these ones, but I didn't do it just yet (I don't even think I > > can push merges).

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-02 Thread Thiago Macieira
On sábado, 3 de março de 2012 05.17.37, Giuseppe D'Angelo wrote: > NB: Since PCRE landed in *master*, there's the need of a merge before > staging these ones, but I didn't do it just yet (I don't even think I > can push merges). Lars has promised to do that this weekend. -- Thiago Macieira - thiag

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-03-02 Thread Giuseppe D'Angelo
On 22 February 2012 17:11, wrote: > Hi, > > this is the first mail where I'd like to go through the remaining features > for Qt 5.0. > > I know that this bug is blocked by not having PCRE in 3rdparty/. But how > is the status apart from this? Thiago, simply tell me if you feel > comfortable with

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-25 Thread Giuseppe D'Angelo
2012/2/25 Thiago Macieira : > On sábado, 25 de fevereiro de 2012 02.48.11, Giuseppe D'Angelo wrote: >> 1) add the operator QRegularExpression() const to QRegExp and remove >> the QString overloads taking a QRegExp: >> Drawbacks: >> * possible subtle bugs introduced by the different QRegExp and >> Q

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-25 Thread Thiago Macieira
On sábado, 25 de fevereiro de 2012 02.48.11, Giuseppe D'Angelo wrote: > 1) add the operator QRegularExpression() const to QRegExp and remove > the QString overloads taking a QRegExp: > Drawbacks: > * possible subtle bugs introduced by the different QRegExp and > QRegularExpression behaviours/quirks

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-24 Thread Giuseppe D'Angelo
2012/2/22 Thiago Macieira : > The uses of QRegExp in qtbase and my proposals would be: In short, the biggest deal is how to properly replace QString methods; since everywhere else (QVariant, QObject, QStringList, QSortFilterProxyModel) you want it to be replaced by the new class, or a new class to

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-23 Thread Thiago Macieira
On quinta-feira, 23 de fevereiro de 2012 13.25.30, Shaw Andy wrote: > >The uses of QRegExp in qtbase and my proposals would be: > > - qmake: lots of use, keep it by copying qregexp.cpp into qmake > > Since I understand that the code would still be available in a separate > library anyway, then the

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-23 Thread Shaw Andy
On 2/22/12 9:48 PM, "Thiago Macieira" wrote: >On quarta-feira, 22 de fevereiro de 2012 17.11.17, lars.kn...@nokia.com >wrote: >> Hi, >> >> this is the first mail where I'd like to go through the remaining >>features >> for Qt 5.0. >> >> I know that this bug is blocked by not having PCRE in 3r

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-22 Thread Thiago Macieira
On quarta-feira, 22 de fevereiro de 2012 17.51.07, Giuseppe D'Angelo wrote: > The only points where the API isn't a replecement is where the other > non-Perl QRegExp matchings are used (f.i. wildcard matching; but I saw > that QRegExp has a nice wc2rx internal method to convert wildcards to > a Per

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-22 Thread Thiago Macieira
On quarta-feira, 22 de fevereiro de 2012 17.11.17, lars.kn...@nokia.com wrote: > Hi, > > this is the first mail where I'd like to go through the remaining features > for Qt 5.0. > > I know that this bug is blocked by not having PCRE in 3rdparty/. But how > is the status apart from this? Thiago, s

Re: [Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-22 Thread Giuseppe D'Angelo
On 22 February 2012 17:11, wrote: > Hi, > > this is the first mail where I'd like to go through the remaining features > for Qt 5.0. > > I know that this bug is blocked by not having PCRE in 3rdparty/. But how > is the status apart from this? The "final" reviews (API, code, tests, docs) are miss

[Development] QTBUG-23489: Implement the new regular expression classes using PCRE

2012-02-22 Thread lars.knoll
Hi, this is the first mail where I'd like to go through the remaining features for Qt 5.0. I know that this bug is blocked by not having PCRE in 3rdparty/. But how is the status apart from this? Thiago, simply tell me if you feel comfortable with the code and I'll do final review and approval. If