Re: [Development] Proposed API change: Change signature of QMessageHandler to use QString

2012-04-13 Thread kai.koehne
] > On Behalf Of Koehne Kai (Nokia-MP/Berlin) > Sent: Friday, April 13, 2012 12:41 AM > To: thiago.macie...@intel.com; development@qt-project.org > Subject: Re: [Development] Proposed API change: Change signature of > QMessageHandler to use QString > > > > -Original Mes

Re: [Development] Proposed API change: Change signature of QMessageHandler to use QString

2012-04-12 Thread wolfgang.beck
ent@qt-project.org > Subject: Re: [Development] Proposed API change: Change signature of > QMessageHandler to use QString > > On quinta-feira, 12 de abril de 2012 08.17.37, kai.koe...@nokia.com wrote: > > Hi, > > > > I'd like to get > > https://codereview.qt-pr

Re: [Development] Proposed API change: Change signature of QMessageHandler to use QString

2012-04-12 Thread Robin Burchell
2012/4/12 Thiago Macieira : > Not for long. I still need to change fromAscii to be fromUtf8. Provided it > doesn't break too much. I'm happy to help fix test failures (of which I am sure there will be a fair few) once there's something to work with. ___

Re: [Development] Proposed API change: Change signature of QMessageHandler to use QString

2012-04-12 Thread Thiago Macieira
On quinta-feira, 12 de abril de 2012 14.41.27, kai.koe...@nokia.com wrote: > > Maybe QChar *begin, int len? > > > > Or QChar *begin, guaranteed to be NUL-terminated? > > What's the advantage of having a QChar * in contrast to a QString? To be honest, not much. I was just wondering if we could use

Re: [Development] Proposed API change: Change signature of QMessageHandler to use QString

2012-04-12 Thread kai.koehne
ect: Re: [Development] Proposed API change: Change signature of > QMessageHandler to use QString > > On quinta-feira, 12 de abril de 2012 08.17.37, kai.koe...@nokia.com wrote: > > Hi, > > > > I'd like to get > > https://codereview.qt-project.org/#change,2215

Re: [Development] Proposed API change: Change signature of QMessageHandler to use QString

2012-04-12 Thread Thiago Macieira
On quinta-feira, 12 de abril de 2012 08.17.37, kai.koe...@nokia.com wrote: > Hi, > > I'd like to get https://codereview.qt-project.org/#change,22151,patchset=5 > into 5.0/api_changes branch. It's one more change to the logging framework, > specifically to the signature of QMessageHandler (new in 5.

[Development] Proposed API change: Change signature of QMessageHandler to use QString

2012-04-12 Thread kai.koehne
Hi, I'd like to get https://codereview.qt-project.org/#change,22151,patchset=5 into 5.0/api_changes branch. It's one more change to the logging framework, specifically to the signature of QMessageHandler (new in 5.0, old QtMsgHandler is unchanged): void (*QMessageHandler)(QtMsgType, const QMes