Re: [Development] On Pick-to: and QUIP-16

2025-03-17 Thread Thiago Macieira
On Monday, 17 March 2025 01:28:44 Pacific Daylight Time Jani Heikkinen via Development wrote: > In the release branches, we got lots of 'nice-to-have's' picked in, which > doesn't belong to the release branch at all. Sometimes those nice-to-haves are dependencies for a must-have later in the tre

Re: [Development] On Pick-to: and QUIP-16

2025-03-17 Thread Thiago Macieira
On Monday, 17 March 2025 01:11:59 Pacific Daylight Time Marc Mutz via Development wrote: > I don't know how this goes in other modules, but in qtbase, I have been > bitten so many times in the last weeks by missing cherry-picks that the > issue needs some discussion. I don't want to step on any pa

Re: [Development] On Pick-to: and QUIP-16

2025-03-17 Thread Jörg Bornemann via Development
On 3/14/25 5:49 PM, Marc Mutz via Development wrote: TL;DR: do _not_ approve patches that do not "pick-to:" according to QUIP-16 or explain in the commit message why they deviate. This reads as if QUIP-16 would require us cherry-picking to a lower branch. The wording, however, is: "Changes th

Re: [Development] On Pick-to: and QUIP-16

2025-03-17 Thread Jani Heikkinen via Development
> -Original Message- > From: Development On Behalf Of Volker > Hilsheimer via Development > Sent: maanantai 17. maaliskuuta 2025 9.59 > To: Marc Mutz ; development@qt-project.org > Subject: Re: [Development] On Pick-to: and QUIP-16 > > > Marc, > >

Re: [Development] On Pick-to: and QUIP-16

2025-03-17 Thread Marc Mutz via Development
On 17.03.25 08:58, Volker Hilsheimer wrote: >> On 14 Mar 2025, at 17:49, Marc Mutz via Development >> wrote: >> >> Hi, >> >> TL;DR: do _not_ approve patches that do not "pick-to:" according to >> QUIP-16 or explain in the commit message why they deviate. >> >> Long version: >> >> Just a reminder

Re: [Development] On Pick-to: and QUIP-16

2025-03-17 Thread Marc Mutz via Development
On 17.03.25 08:10, Jörg Bornemann wrote: > On 3/14/25 5:49 PM, Marc Mutz via Development wrote: > >> TL;DR: do _not_ approve patches that do not "pick-to:" according to >> QUIP-16 or explain in the commit message why they deviate. > > This reads as if QUIP-16 would require us cherry-picking to a

Re: [Development] On Pick-to: and QUIP-16

2025-03-17 Thread Volker Hilsheimer via Development
> On 14 Mar 2025, at 17:49, Marc Mutz via Development > wrote: > > Hi, > > TL;DR: do _not_ approve patches that do not "pick-to:" according to > QUIP-16 or explain in the commit message why they deviate. > > Long version: > > Just a reminder that QUIP-16¹ gives detailed instructions how far

[Development] On Pick-to: and QUIP-16

2025-03-14 Thread Marc Mutz via Development
Hi, TL;DR: do _not_ approve patches that do not "pick-to:" according to QUIP-16 or explain in the commit message why they deviate. Long version: Just a reminder that QUIP-16¹ gives detailed instructions how far certain sets of changes should be picked, so all maintainers / all approvers shoul