Re: [Development] No Change-Id being generated for commit message

2015-04-13 Thread Mandeep Sandhu
> > It's supposed to contain the text that the editor was last launched with. If > you tried to make a commit and didn't save anything, that's what you'll see in > that file. Hmm...probably thats what happened (I don't remember exactly how or when, but I might have tried to abort a commit by simpl

Re: [Development] No Change-Id being generated for commit message

2015-03-26 Thread Thiago Macieira
On Thursday 26 March 2015 12:07:41 Mandeep Sandhu wrote: > On Thu, Mar 26, 2015 at 10:44 AM, Mandeep Sandhu > > wrote: > >> 3) it removes any comment lines > > > > COMMIT_EDITMSG has _only_ comment lines (i.e lines starting with a #), > > so won't sed remove _all_ lines from it then? (this is e

Re: [Development] No Change-Id being generated for commit message

2015-03-26 Thread Mandeep Sandhu
On Thu, Mar 26, 2015 at 10:44 AM, Mandeep Sandhu wrote: >> 3) it removes any comment lines > > COMMIT_EDITMSG has _only_ comment lines (i.e lines starting with a #), > so won't sed remove _all_ lines from it then? (this is exactly what > I'm seeing when I run the commit-msg script on COMMIT_EDITM

Re: [Development] No Change-Id being generated for commit message

2015-03-26 Thread Mandeep Sandhu
> 3) it removes any comment lines COMMIT_EDITMSG has _only_ comment lines (i.e lines starting with a #), so won't sed remove _all_ lines from it then? (this is exactly what I'm seeing when I run the commit-msg script on COMMIT_EDITMSG). ___ Development

Re: [Development] No Change-Id being generated for commit message

2015-03-26 Thread Thiago Macieira
On Thursday 26 March 2015 09:45:35 Mandeep Sandhu wrote: > Is there a place from where I can get the latest copy of commit-msg > script? I currently used the hint in the failed 'git push' error > message to download the hook. >From Gerrit itself. But I can tell you what mine is and is working:

Re: [Development] No Change-Id being generated for commit message

2015-03-26 Thread Mandeep Sandhu
On Wed, Mar 25, 2015 at 7:44 PM, Thiago Macieira wrote: > On Wednesday 25 March 2015 18:53:18 Mandeep Sandhu wrote: >> I'm not sure, but is that a valid sed expression (with all the >> white-spaces in-between)? > > Yes. Hmmm..if I run this expression on the commandline, it gives out an empty stri

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 18:53:18 Mandeep Sandhu wrote: > I'm not sure, but is that a valid sed expression (with all the > white-spaces in-between)? Yes. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Mandeep Sandhu
> > Is git stripspace or grep malfuncitoning? 'git stripspace' seems to be working fine. $ cat COMMIT_EDITMSG | git stripspace Although the commit-msg script seems to be exiting early in add_ChangeId()... MSG="$1" # Check for, and add if missing, a unique Change-Id # add_ChangeId (){ c

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 18:02:08 Mandeep Sandhu wrote: > It doesn't show up. > > $ grep "Change-Id:" .git/COMMIT_EDITMSG > $ .git/hooks/commit-msg .git/COMMIT_EDITMSG > $ grep "Change-Id:" .git/COMMIT_EDITMSG Then the script chose not to add it. Try to debug it. Check if gerrit.createChangeId

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Mandeep Sandhu
Hi Thiago, > > How are you committing? If you're using Qt Creator's integrated commit editor, I use the commandline. > sure that the script works. To do that, check that your .git/COMMIT_EDITMSG I verified this. .git/COMMIT_EDITMSG does not have Change-Id string. > file does not contain a Chan

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 17:36:58 Mandeep Sandhu wrote: > Hi All, > > I'm having trouble pushing a change. > > 'git push' failed stating that the commit message was missing the > "Change-Id" field. I had this working until recently when I moved my > setup toa different machine. So something lik

[Development] No Change-Id being generated for commit message

2015-03-25 Thread Mandeep Sandhu
Hi All, I'm having trouble pushing a change. 'git push' failed stating that the commit message was missing the "Change-Id" field. I had this working until recently when I moved my setup toa different machine. So something likely got screwed-up. I have the "commit-msg" hook installed in my repo's