Re: [Development] New API design for file system operations

2019-02-12 Thread Jason H
> Sent: Tuesday, February 12, 2019 at 9:54 AM > From: "Volker Hilsheimer" > To: "Jason H" > Cc: "Vitaly Fanaskov" , "development@qt-project.org" > > Subject: Re: [Development] New API design for file system operations > > >

Re: [Development] New API design for file system operations

2019-02-12 Thread Volker Hilsheimer
On 12 Feb 2019, at 10:37, Eike Ziller mailto:eike.zil...@qt.io>> wrote: On Feb 12, 2019, at 09:54, Volker Hilsheimer mailto:volker.hilshei...@qt.io>> wrote: On 11 Feb 2019, at 19:16, Jason H mailto:jh...@gmx.com>> wrote: The question for me is: why would an application (that is not a file explor

Re: [Development] New API design for file system operations

2019-02-12 Thread Eike Ziller
> On Feb 12, 2019, at 09:54, Volker Hilsheimer wrote: > > > >> On 11 Feb 2019, at 19:16, Jason H wrote: >> >> >>> The question for me is: why would an application (that is not a file >>> explorer) want to do any of this? I honestly don’t see the use case. >> >> When I filed the bug again

Re: [Development] New API design for file system operations

2019-02-12 Thread Volker Hilsheimer
> On 11 Feb 2019, at 19:16, Jason H wrote: > > >> The question for me is: why would an application (that is not a file >> explorer) want to do any of this? I honestly don’t see the use case. > > When I filed the bug against KIO not having a "trash" feature it was because > I was working in

Re: [Development] New API design for file system operations

2019-02-11 Thread Jason H
> The question for me is: why would an application (that is not a file > explorer) want to do any of this? I honestly don’t see the use case. When I filed the bug against KIO not having a "trash" feature it was because I was working in digikam (photo library) in KDE - this is MANY years ago (20

Re: [Development] New API design for file system operations

2019-02-11 Thread Volker Hilsheimer
On 11 Feb 2019, at 16:07, Vitaly Fanaskov mailto:vitaly.fanas...@qt.io>> wrote: Hi Volker, The question for me is: why would an application (that is not a file explorer) want to do any of this? I honestly don’t see the use case. I think in order to provide a user some useful information or sugg

Re: [Development] New API design for file system operations

2019-02-11 Thread Vitaly Fanaskov
Hi Volker, The question for me is: why would an application (that is not a file explorer) want to do any of this? I honestly don’t see the use case. I think in order to provide a user some useful information or suggest to perform some actions. For example, "moveToTrash" operation might fail for s

Re: [Development] New API design for file system operations

2019-02-11 Thread Volker Hilsheimer
Hey Vitaly, See inline. On 11 Feb 2019, at 11:42, Vitaly Fanaskov mailto:vitaly.fanas...@qt.io>> wrote: Making QFile::remove(bool toTrash=false); is tempting, but I think Thiago has a valid point about providing a dedicated file system operation abstraction, rather than cramming a mix of simpl

Re: [Development] New API design for file system operations

2019-02-11 Thread Vitaly Fanaskov
Hi Volker, Making QFile::remove(bool toTrash=false); is tempting, but I think Thiago has a valid point about providing a dedicated file system operation abstraction, rather than cramming a mix of simple and complex file operations into QFile and QDir. I agree that creating separate abstraction

Re: [Development] New API design for file system operations

2019-02-08 Thread Volker Hilsheimer
On 8 Feb 2019, at 10:43, Vitaly Fanaskov mailto:vitaly.fanas...@qt.io>> wrote: On 2/7/19 5:03 PM, Volker Hilsheimer wrote: Hi all, TL;DR; we are considering moving file system operations from QFile into a seperate class (or set of classes) for a more consistent and flexible way of moving, co

Re: [Development] New API design for file system operations

2019-02-08 Thread Marco Bubke
+2 On February 8, 2019 11:12:25 Christian Kandeler wrote: > On Thu, 7 Feb 2019 16:03:30 + > Volker Hilsheimer wrote: > >> Thoughts, ideas, and pointers to other frameworks that you believe provide a >> good API are welcome here in this email thread before moving to a dedicated >> JIRA ti

Re: [Development] New API design for file system operations

2019-02-08 Thread Shawn Rutledge
> On 8 Feb 2019, at 11:10, Christian Kandeler wrote: > > On Thu, 7 Feb 2019 16:03:30 + > Volker Hilsheimer wrote: > >> Thoughts, ideas, and pointers to other frameworks that you believe provide a >> good API are welcome here in this email thread before moving to a dedicated >> JIRA tick

Re: [Development] New API design for file system operations

2019-02-08 Thread Daniel Engelke
+1 when I first started, that threw me off as well. Daniel From: Christian Kandeler To: "development@qt-project.org" Sent: 2/8/2019 11:10 AM Subject: Re: [Development] New API design for file system operations On Thu, 7 Feb 2019 16:03:30 + Volker Hilshei

Re: [Development] New API design for file system operations

2019-02-08 Thread Tor Arne Vestbø
> On 8 Feb 2019, at 10:43, Vitaly Fanaskov wrote: > > Hi, > > I've read QTBUG-47703 very carefully and I think that adding some file > managers is overkill in this particular case. I agree, QFile and QDir are natural places to look for such APIs. Tor Arne _

Re: [Development] New API design for file system operations

2019-02-08 Thread Christian Kandeler
On Thu, 7 Feb 2019 16:03:30 + Volker Hilsheimer wrote: > Thoughts, ideas, and pointers to other frameworks that you believe provide a > good API are welcome here in this email thread before moving to a dedicated > JIRA ticket. My personal pet peeve: Please, let's never again use the term

Re: [Development] New API design for file system operations

2019-02-08 Thread Vitaly Fanaskov
Hi, I've read QTBUG-47703 very carefully and I think that adding some file managers is overkill in this particular case. I would suggest the following changes: 1. Extract an abstract class (i.e., interface) for common file operations 2. Both QFile and QDir should implement this interface

[Development] New API design for file system operations

2019-02-07 Thread Volker Hilsheimer
Hi all, TL;DR; we are considering moving file system operations from QFile into a seperate class (or set of classes) for a more consistent and flexible way of moving, copying etc files and directories. The conversation around the design and implementation of an API to move file or directory