Re: [Development] Needing another advise using git

2017-10-06 Thread Frederik Gladhorn
On onsdag 4. oktober 2017 19.28.43 CEST Daniel Savi wrote: > Thank you all for the helpful comments on my previous message. > > I think that I have now managed to amend my changes into one commit and > may understand how to react on comments. > > While amending my commits I must somehow have push

Re: [Development] Needing another advise using git

2017-10-04 Thread Konstantin Tokarev
04.10.2017, 20:29, "Daniel Savi" : > Thank you all for the helpful comments on my previous message. > > I think that I have now managed to amend my changes into one commit and > may understand how to react on comments. > > While amending my commits I must somehow have pushed another commit > agai

Re: [Development] Needing another advise using git

2017-10-04 Thread André Hartmann
Hi Daniel, I'm currently reviewing your patch :) > While amending my commits I must somehow have pushed another commit > again that is not from me at all. It is this one: > https://codereview.qt-project.org/#/c/207639/ I think this is no big deal. To avoid more confusion I'd suggest to leave e

[Development] Needing another advise using git

2017-10-04 Thread Daniel Savi
Thank you all for the helpful comments on my previous message. I think that I have now managed to amend my changes into one commit and may understand how to react on comments. While amending my commits I must somehow have pushed another commit again that is not from me at all. It is this one: