Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-26 Thread Paul Olav Tvete
On Tuesday 24 July 2012 17:15:37 Girish Ramakrishnan wrote: > On Mon, Jul 23, 2012 at 4:31 AM, wrote: > > How about a third solution, that only exposes the three methods that are > > being used by QTestLib? We could turn QWSI into a namespace, and forward > > declare the required methods in qtes

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-24 Thread Girish Ramakrishnan
On Mon, Jul 23, 2012 at 4:31 AM, wrote: > > > On 7/19/12 4:45 PM, "ext Girish Ramakrishnan" > wrote: > >>On Thu, Jul 19, 2012 at 7:16 AM, wrote: >>> On 7/16/12 12:43 PM, "ext Stephen Kelly" wrote: >>> On Sunday, July 15, 2012 14:24:18 Holger Hans Peter Freyther wrote: > On Tue, Jul 10

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-23 Thread lars.knoll
On 7/19/12 4:45 PM, "ext Girish Ramakrishnan" wrote: >On Thu, Jul 19, 2012 at 7:16 AM, wrote: >> On 7/16/12 12:43 PM, "ext Stephen Kelly" wrote: >> >>>On Sunday, July 15, 2012 14:24:18 Holger Hans Peter Freyther wrote: On Tue, Jul 10, 2012 at 11:53:33AM +0200, Thiago Macieira wrote: >>>

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-19 Thread Girish Ramakrishnan
On Thu, Jul 19, 2012 at 7:16 AM, wrote: > On 7/16/12 12:43 PM, "ext Stephen Kelly" wrote: > >>On Sunday, July 15, 2012 14:24:18 Holger Hans Peter Freyther wrote: >>> On Tue, Jul 10, 2012 at 11:53:33AM +0200, Thiago Macieira wrote: >>> > We have only two choices: >>> > >>> > 1) make QWindowSystem

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-19 Thread lars.knoll
On 7/16/12 12:43 PM, "ext Stephen Kelly" wrote: >On Sunday, July 15, 2012 14:24:18 Holger Hans Peter Freyther wrote: >> On Tue, Jul 10, 2012 at 11:53:33AM +0200, Thiago Macieira wrote: >> > We have only two choices: >> > >> > 1) make QWindowSystemInterface a proper, public API class >> >> I thi

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-16 Thread Stephen Kelly
On Sunday, July 15, 2012 14:24:18 Holger Hans Peter Freyther wrote: > On Tue, Jul 10, 2012 at 11:53:33AM +0200, Thiago Macieira wrote: > > We have only two choices: > > > > 1) make QWindowSystemInterface a proper, public API class > > I think QWindowSystemInterface in its current form would be >

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-15 Thread Holger Hans Peter Freyther
On Tue, Jul 10, 2012 at 11:53:33AM +0200, Thiago Macieira wrote: > > We have only two choices: > > 1) make QWindowSystemInterface a proper, public API class I think QWindowSystemInterface in its current form would be a rather incomplete and limited API. Many months ago I looked into creating a p

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-11 Thread Girish Ramakrishnan
Hi Stephen, On Wed, Jul 11, 2012 at 8:26 PM, Stephen Kelly wrote: > On Wednesday, July 11, 2012 20:00:39 you wrote: >> An alternate approach is to make a header specific to QTestLib which >> ensures that modules privates are not required. > > This is very hacky. I prefer to simply move it from qp

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-11 Thread Stephen Kelly
On Wednesday, July 11, 2012 20:00:39 you wrote: > An alternate approach is to make a header specific to QTestLib which > ensures that modules privates are not required. This is very hacky. I prefer to simply move it from qpa/ to the same location as the rest of the public headers. However, a s

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-11 Thread Girish Ramakrishnan
On Tue, Jul 10, 2012 at 4:59 PM, Stephen Kelly wrote: > On Tuesday, July 10, 2012 16:54:57 Girish Ramakrishnan wrote: >> On Tue, Jul 10, 2012 at 3:23 PM, Thiago Macieira >> >> wrote: >> > On terça-feira, 10 de julho de 2012 11.37.41, Stephen Kelly wrote: >> >> If it is not made public, then all C

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-10 Thread Stephen Kelly
On Tuesday, July 10, 2012 16:54:57 Girish Ramakrishnan wrote: > On Tue, Jul 10, 2012 at 3:23 PM, Thiago Macieira > > wrote: > > On terça-feira, 10 de julho de 2012 11.37.41, Stephen Kelly wrote: > >> If it is not made public, then all CMake based code using QtTest will > >> have to use private Qt

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-10 Thread Girish Ramakrishnan
On Tue, Jul 10, 2012 at 3:23 PM, Thiago Macieira wrote: > On terça-feira, 10 de julho de 2012 11.37.41, Stephen Kelly wrote: >> If it is not made public, then all CMake based code using QtTest will have >> to use private QtGui headers. > > $ git grep -l QWindowSystemInterface | cat > qtestkeyboar

Re: [Development] Moving QWindowSystemInterface out of QPA

2012-07-10 Thread Thiago Macieira
On terça-feira, 10 de julho de 2012 11.37.41, Stephen Kelly wrote: > If it is not made public, then all CMake based code using QtTest will have > to use private QtGui headers. $ git grep -l QWindowSystemInterface | cat qtestkeyboard.h qtestmouse.h qtesttouch.h We have only two choices: 1) make

[Development] Moving QWindowSystemInterface out of QPA

2012-07-10 Thread Stephen Kelly
Hi there, QWindowSystemInterface is treated as a QPA header since this discussion: http://thread.gmane.org/gmane.comp.lib.qt.devel/4178/focus=4210 http://thread.gmane.org/gmane.comp.lib.qt.devel/4178/focus=4206 QWindowSystemInterface is different to QPA API because it is just a bunch of stati