Re: [Development] Make qtstyleplugins an official module and release it

2017-04-18 Thread Thiago Macieira
Em terça-feira, 18 de abril de 2017, às 08:31:06 PDT, André Pönitz escreveu: > > Getting this upstreamed is going to be difficult because of the concerns > > Red Hat Legal has about the Qt CLA. > > Interesting... real reasons, or company politics? [guessing] Real in the sense of "some people get

Re: [Development] Make qtstyleplugins an official module and release it

2017-04-18 Thread André Pönitz
On Tue, Apr 18, 2017 at 12:19:43PM +0200, Kevin Kofler wrote: > Thiago Macieira wrote: > > On segunda-feira, 17 de abril de 2017 15:05:30 PDT Kevin Kofler wrote: > >> Thiago Macieira wrote: > >> > So src/widgets/styles/qgtkstyle.cpp did not compile with Gtk3? > >> > >> No, it doesn't. The GTK+ 3 t

Re: [Development] Make qtstyleplugins an official module and release it

2017-04-18 Thread Kevin Kofler
Thiago Macieira wrote: > On segunda-feira, 17 de abril de 2017 15:05:30 PDT Kevin Kofler wrote: >> Thiago Macieira wrote: >> > So src/widgets/styles/qgtkstyle.cpp did not compile with Gtk3? >> >> No, it doesn't. The GTK+ 3 theming API is very different. >> >> Some Red Hat / Fedora developers have

Re: [Development] Make qtstyleplugins an official module and release it

2017-04-17 Thread Thiago Macieira
On segunda-feira, 17 de abril de 2017 15:05:30 PDT Kevin Kofler wrote: > Thiago Macieira wrote: > > So src/widgets/styles/qgtkstyle.cpp did not compile with Gtk3? > > No, it doesn't. The GTK+ 3 theming API is very different. > > Some Red Hat / Fedora developers have ported the Adwaita style (the

Re: [Development] Make qtstyleplugins an official module and release it

2017-04-17 Thread Kevin Kofler
Thiago Macieira wrote: > So src/widgets/styles/qgtkstyle.cpp did not compile with Gtk3? No, it doesn't. The GTK+ 3 theming API is very different. Some Red Hat / Fedora developers have ported the Adwaita style (the default GNOME 3 style) to Qt natively, and that is chosen by default on GNOME 3 in

Re: [Development] Make qtstyleplugins an official module and release it

2017-04-17 Thread Thiago Macieira
On segunda-feira, 17 de abril de 2017 11:19:42 PDT Sérgio Martins wrote: > On Mon, Apr 17, 2017 at 6:50 PM, Thiago Macieira > > wrote: > > Looks like we moved important functionality from qtbase to qtstyleplugins. > > Why wasn't it added to .gitmodules and included in the 5.7.0 and 5.8.0 > > rele

Re: [Development] Make qtstyleplugins an official module and release it

2017-04-17 Thread Konstantin Tokarev
17.04.2017, 21:20, "Sérgio Martins" : > On Mon, Apr 17, 2017 at 6:50 PM, Thiago Macieira > wrote: >>  Looks like we moved important functionality from qtbase to qtstyleplugins. >> Why >>  wasn't it added to .gitmodules and included in the 5.7.0 and 5.8.0 releases? > > IIRC, the gtk2 stuff was c

Re: [Development] Make qtstyleplugins an official module and release it

2017-04-17 Thread Sérgio Martins
On Mon, Apr 17, 2017 at 6:50 PM, Thiago Macieira wrote: > Looks like we moved important functionality from qtbase to qtstyleplugins. Why > wasn't it added to .gitmodules and included in the 5.7.0 and 5.8.0 releases? IIRC, the gtk2 stuff was considered non-important (there's was a thread about thi

[Development] Make qtstyleplugins an official module and release it

2017-04-17 Thread Thiago Macieira
Looks like we moved important functionality from qtbase to qtstyleplugins. Why wasn't it added to .gitmodules and included in the 5.7.0 and 5.8.0 releases? Can we fix it for 5.9.0? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___