Re: [Development] Keep dependent projects in mind when approving changes

2011-10-27 Thread paivi.rajala
evelopment] Keep dependent projects in mind when approving changes Hi Lars, On Thu, Oct 27, 2011 at 8:21 AM, wrote: > In addition, I'd like to be added as a reviewer for changes that break > source compatibility with the public API of Qt 4.x. Please also add > some comment in

Re: [Development] Keep dependent projects in mind when approving changes

2011-10-27 Thread Rohan McGovern
marius.storm-ol...@nokia.com said: > Hi Maintainers and Approver, > > Please keep in mind dependent modules when you approve and merge in > changes which can lead to dependent projects failing. If you know that a > commit has a risk of destabilizing other modules, please ensure that you > are prep

Re: [Development] Keep dependent projects in mind when approving changes

2011-10-27 Thread Robin Burchell
Hi Lars, On Thu, Oct 27, 2011 at 8:21 AM, wrote: > In addition, I'd like to be added as a reviewer for changes that break > source compatibility with the public API of Qt 4.x. Please also add some > comment in the changes file in this case. Following up on this, do you have any information abou

Re: [Development] Keep dependent projects in mind when approving changes

2011-10-26 Thread lars.knoll
On 10/25/11 10:51 PM, "ext marius.storm-ol...@nokia.com" wrote: >Hi Maintainers and Approver, > >Please keep in mind dependent modules when you approve and merge in >changes which can lead to dependent projects failing. If you know that a >commit has a risk of destabilizing other modules, please

Re: [Development] Keep dependent projects in mind when approving changes

2011-10-25 Thread Thiago Macieira
On Tuesday, 25 de October de 2011 20.51.31, marius.storm-ol...@nokia.com wrote: > Hi Maintainers and Approver, > > Please keep in mind dependent modules when you approve and merge in > changes which can lead to dependent projects failing. If you know that a > commit has a risk of destabilizing ot

[Development] Keep dependent projects in mind when approving changes

2011-10-25 Thread marius.storm-olsen
Hi Maintainers and Approver, Please keep in mind dependent modules when you approve and merge in changes which can lead to dependent projects failing. If you know that a commit has a risk of destabilizing other modules, please ensure that you are prepared to also do a fix in the dependent module,