Re: [Development] Issues with 'Fixes' keyword

2019-01-18 Thread Oswald Buddenhagen
On Fri, Jan 18, 2019 at 01:29:52PM +, Kari Oikarinen wrote: > It's not the only automation we have to help development. > https://bugreports.qt.io/browse/QTQAINFRA-1958 > qtqa/automation perhaps? > http://www.xkcd2.com/927/ ___ Development mailin

Re: [Development] Issues with 'Fixes' keyword

2019-01-18 Thread Paul Wicking
On 1/18/19 2:27 PM, Simon Hausmann wrote: > > I suggest to commit the sources to the qtqa repo. > +1 ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Issues with 'Fixes' keyword

2019-01-18 Thread Kari Oikarinen
On 18.1.2019 15.12, Frederik Gladhorn wrote: > On torsdag 27. desember 2018 11:05:28 CET Christian Ehrlicher wrote: >> Am 27.12.2018 um 10:52 schrieb Allan Sandfeld Jensen: >>> It has been for me. I always put bugs I have a patch in review for "in >>> progress", and they have been consistently clo

Re: [Development] Issues with 'Fixes' keyword

2019-01-18 Thread Simon Hausmann
I suggest to commit the sources to the qtqa repo. Simon > On 18. Jan 2019, at 14:15, Frederik Gladhorn wrote: > >> On torsdag 27. desember 2018 11:05:28 CET Christian Ehrlicher wrote: >>> Am 27.12.2018 um 10:52 schrieb Allan Sandfeld Jensen: >>> It has been for me. I always put bugs I have a p

Re: [Development] Issues with 'Fixes' keyword

2019-01-18 Thread Frederik Gladhorn
On torsdag 27. desember 2018 11:05:28 CET Christian Ehrlicher wrote: > Am 27.12.2018 um 10:52 schrieb Allan Sandfeld Jensen: > > It has been for me. I always put bugs I have a patch in review for "in > > progress", and they have been consistently closed, except one time I found > > a bug in the scr

Re: [Development] Issues with 'Fixes' keyword

2018-12-27 Thread Christian Ehrlicher
Am 27.12.2018 um 10:52 schrieb Allan Sandfeld Jensen: It has been for me. I always put bugs I have a patch in review for "in progress", and they have been consistently closed, except one time I found a bug in the script that was then closed. You have probably run into another bug. What else was s

Re: [Development] Issues with 'Fixes' keyword

2018-12-27 Thread Allan Sandfeld Jensen
On Donnerstag, 27. Dezember 2018 08:48:34 CET Christian Ehrlicher wrote: > Am 27.12.2018 um 07:43 schrieb Kari Oikarinen: > > On 26.12.2018 17.58, Christian Ehrlicher wrote: > >> Hi, > >> > >> looks like under some circumstances the 'Fixes' keyword in the commit > >> message does trigger the autom

Re: [Development] Issues with 'Fixes' keyword

2018-12-26 Thread Christian Ehrlicher
Am 27.12.2018 um 07:43 schrieb Kari Oikarinen: On 26.12.2018 17.58, Christian Ehrlicher wrote: Hi, looks like under some circumstances the 'Fixes' keyword in the commit message does trigger the automatic closing of a bug when the bug is in 'In progress' state. Is this the intended behavior? Ye

Re: [Development] Issues with 'Fixes' keyword

2018-12-26 Thread Kari Oikarinen
On 26.12.2018 17.58, Christian Ehrlicher wrote: > Hi, > > looks like under some circumstances the 'Fixes' keyword in the commit message > does trigger the automatic closing of a bug when the bug is in 'In progress' > state. Is this the intended behavior? Yes. You can use the "Task-number" key

[Development] Issues with 'Fixes' keyword

2018-12-26 Thread Christian Ehrlicher
Hi, looks like under some circumstances the 'Fixes' keyword in the commit message does trigger the automatic closing of a bug when the bug is in 'In progress' state. Is this the intended behavior? Here some examples: https://bugreports.qt.io/browse/QTBUG-72545 https://bugreports.qt.io/browse/