Re: [Development] Header diff for QtQml

2013-06-26 Thread Thiago Macieira
On quarta-feira, 26 de junho de 2013 17.42.54, Alan Alpert wrote: > > Does it have a reason for the include? For example, does it declare > > debugging operators for anything? If not, it's probably accidental and > > can be safely removed. > > It uses qWarning() in the definition of a new inline f

Re: [Development] Header diff for QtQml

2013-06-26 Thread Thiago Macieira
On quarta-feira, 26 de junho de 2013 17.23.56, Alan Alpert wrote: > Also qqml.h now includes qdebug.h. While not harmful, do we have a > convention of not including that in public headers? Does it have a reason for the include? For example, does it declare debugging operators for anything? If not

Re: [Development] Header diff for QtQml

2013-06-26 Thread Thiago Macieira
One minor oops found: On quarta-feira, 26 de junho de 2013 13.50.06, Thiago Macieira wrote: > +++ b/src/qml/qml/qqmlextensionplugin.h > -private: > Q_DISABLE_COPY(QQmlExtensionPlugin) By removing the private:, with C++98 the error from trying to copy a Q_DISABLE_COPY moves from compile time