Re: [Development] Header diff for QtCore

2013-07-08 Thread Thiago Macieira
On sábado, 6 de julho de 2013 23.15.12, Thiago Macieira wrote: > On sábado, 6 de julho de 2013 23.02.28, Thiago Macieira wrote: > > On quarta-feira, 26 de junho de 2013 13.49.36, Thiago Macieira wrote: > > > +bool open(OpenMode mode = ReadWrite) Q_DECL_OVERRIDE; > > > > This has just been confi

Re: [Development] Header diff for QtCore

2013-07-06 Thread Thiago Macieira
On sábado, 6 de julho de 2013 23.02.28, Thiago Macieira wrote: > On quarta-feira, 26 de junho de 2013 13.49.36, Thiago Macieira wrote: > > +bool open(OpenMode mode = ReadWrite) Q_DECL_OVERRIDE; > > This has just been confirmed as to cause a binary compatibility issue. > > The rule for overridin

Re: [Development] Header diff for QtCore

2013-07-06 Thread Thiago Macieira
On quarta-feira, 26 de junho de 2013 13.49.36, Thiago Macieira wrote: > +bool open(OpenMode mode = ReadWrite) Q_DECL_OVERRIDE; This has just been confirmed as to cause a binary compatibility issue. The rule for overriding virtuals is that it's ok, provided the old implementation (namely, QIO

Re: [Development] Header diff for QtCore

2013-06-28 Thread Stephen Kelly
On Wednesday, June 26, 2013 14:28:24 Thiago Macieira wrote: > There are a few scary changes in the metatype and QObject connection code > that I'd like Stephen and Olivier (respectively) to take a look. Looks fine to me. Thanks, -- Stephen Kelly | Software Engineer KDAB (Deutschland) GmbH & C

Re: [Development] Header diff for QtCore

2013-06-26 Thread Thiago Macieira
On quarta-feira, 26 de junho de 2013 13.49.36, Thiago Macieira wrote: > -// POD for Q_GLOBAL_STATIC > -template > -class QGlobalStatic class QGlobalStatic was moved to a new header, qglobalstatic.h, which doesn't show in the diff (due to --diff-filter=M). The new class is completely different