Re: [Development] Git commit hook keywords

2012-09-17 Thread Oswald Buddenhagen
On Mon, Sep 17, 2012 at 01:43:03PM +0100, ext Laszlo Papp wrote: > Hmm, perhaps there is a misunderstanding here. I am sorry for that if that > is the case. I would not like to reference to the commit from its commit > message. I would like to reference to other commits from a commit message. > th

Re: [Development] Git commit hook keywords

2012-09-17 Thread Laszlo Papp
Hmm, perhaps there is a misunderstanding here. I am sorry for that if that is the case. I would not like to reference to the commit from its commit message. I would like to reference to other commits from a commit message. An example for this is: 1) Something changed in Qt5-base which requires fur

Re: [Development] Git commit hook keywords

2012-09-17 Thread shane.kearns
The line: Change-Id: I9c239ff790a139c7820ef1aeced89d31320ae6b0 Is what identifies the code review. If you put that into the search box on gerrit, it gives the url: https://codereview.qt-project.org/#q,I9c239ff790a139c7820ef1aeced89d31320ae6b0,n,z Which shows the two reviews for this change (5.0 a

Re: [Development] Git commit hook keywords

2012-09-16 Thread mark.keir
nt-bounces+mark.keir=nokia@qt-project.org] On Behalf Of ext Sergio Ahumada Sent: Sunday, September 16, 2012 4:35 PM To: development@qt-project.org Subject: Re: [Development] Git commit hook keywords Hi, On 09/16/2012 01:34 AM, Giuseppe D'Angelo wrote: > On 16 September 2012 00:09, wrote: >

Re: [Development] Git commit hook keywords

2012-09-16 Thread Laszlo Papp
> > I didn't say we don't need documentation. I said there will always be more > information than what's documented and reviewers are supposed to teach. > Will document it. > > > As I said, it's the "Task-number" that triggers the completion in the > > > Gerrit > > > UI. > > > > How will the "Ta

Re: [Development] Git commit hook keywords

2012-09-16 Thread Thiago Macieira
On domingo, 16 de setembro de 2012 10.34.32, Laszlo Papp wrote: > > In any case, this is why we have reviewers: so they can teach newcomers > > what > > the policies are and how we do things. There will never be documentation > > for > > every single little thing, there's a lot that is latent knowl

Re: [Development] Git commit hook keywords

2012-09-16 Thread Sergio Ahumada
Hi, On 09/16/2012 10:23 AM, Thiago Macieira wrote: > On domingo, 16 de setembro de 2012 07.56.36, Laszlo Papp wrote: >> wrote: >>> On domingo, 16 de setembro de 2012 04.54.19, Laszlo Papp wrote: 1) Documentation welcome about such things from a person who well understand those deeply. >>

Re: [Development] Git commit hook keywords

2012-09-16 Thread Laszlo Papp
> > In any case, this is why we have reviewers: so they can teach newcomers > what > the policies are and how we do things. There will never be documentation > for > every single little thing, there's a lot that is latent knowledge. > Why would they teach if the newcomers knew after reading the do

Re: [Development] Git commit hook keywords

2012-09-16 Thread Thiago Macieira
On domingo, 16 de setembro de 2012 07.56.36, Laszlo Papp wrote: > wrote: > > On domingo, 16 de setembro de 2012 04.54.19, Laszlo Papp wrote: > > > 1) Documentation welcome about such things from a person who well > > > understand those deeply. > > > > As far as I know, "Task-number:" is the keyword

Re: [Development] Git commit hook keywords

2012-09-16 Thread Laszlo Papp
> > People now keep pasting the hard coded link in such situations as far as I > see which is not clickable right away and hard coded. It would be nice if I > could write something like "Review-number: QTREVIEW-31541" or something > like that. > Sorry, I was wrong. The hard coded url is also click

Re: [Development] Git commit hook keywords

2012-09-15 Thread Laszlo Papp
On Sun, Sep 16, 2012 at 7:45 AM, Thiago Macieira wrote: > On domingo, 16 de setembro de 2012 04.54.19, Laszlo Papp wrote: > > 1) Documentation welcome about such things from a person who well > > understand those deeply. > > As far as I know, "Task-number:" is the keyword. > It would be nice if s

Re: [Development] Git commit hook keywords

2012-09-15 Thread Thiago Macieira
On domingo, 16 de setembro de 2012 04.54.19, Laszlo Papp wrote: > 1) Documentation welcome about such things from a person who well > understand those deeply. As far as I know, "Task-number:" is the keyword. > 2) QTREVIEW-XXX may be worth considering. Can you explain why and what that is? And wh

Re: [Development] Git commit hook keywords

2012-09-15 Thread Sergio Ahumada
Hi, On 09/16/2012 01:34 AM, Giuseppe D'Angelo wrote: > On 16 September 2012 00:09, wrote: >> Is there an actual hook that triggers when somebody uses Task-number: >> QTBUG-1234 in a commit message? I am under the impression that at this point >> it is merely a convention that could be hooked u

Re: [Development] Git commit hook keywords

2012-09-15 Thread simon.hausmann
ptember 16, 2012 1:34 To: Hausmann Simon (Nokia-MP/Oslo) Cc: lp...@kde.org; development@qt-project.org Subject: Re: [Development] Git commit hook keywords On 16 September 2012 00:09, wrote: > Is there an actual hook that triggers when somebody uses Task-number: > QTBUG-1234 in a commit messag

Re: [Development] Git commit hook keywords

2012-09-15 Thread Laszlo Papp
On Sun, Sep 16, 2012 at 12:09 AM, wrote: > Is there an actual hook that triggers when somebody uses Task-number: > QTBUG-1234 in a commit message? I am under the impression that at this > point it is merely a convention that could be hooked up with Jira in the > future. > I was confused when I w

Re: [Development] Git commit hook keywords

2012-09-15 Thread Giuseppe D'Angelo
On 16 September 2012 00:09, wrote: > Is there an actual hook that triggers when somebody uses Task-number: > QTBUG-1234 in a commit message? I am under the impression that at this point > it is merely a convention that could be hooked up with Jira in the future. I think *something* happens. Fo

Re: [Development] Git commit hook keywords

2012-09-15 Thread simon.hausmann
Is there an actual hook that triggers when somebody uses Task-number: QTBUG-1234 in a commit message? I am under the impression that at this point it is merely a convention that could be hooked up with Jira in the future. Simon -- Sendt fra min Nokia N916.09.12 00:45 skrev ext Laszlo Papp: If y

Re: [Development] Git commit hook keywords

2012-09-15 Thread Laszlo Papp
> > I meant all the hook keywords in general. At least the "Task-number: > QTBUG-XXX" is documented in there. > I meant "undocumented". Silly me with typos all the time. Laszlo ___ Development mailing list Development@qt-project.org http://lists.qt-proj

Re: [Development] Git commit hook keywords

2012-09-15 Thread Laszlo Papp
> > If you're talking about the commit hook for the Change-id, it's all > documented here http://qt-project.org/wiki/Setting-up-Gerrit > I meant all the hook keywords in general. At least the "Task-number: QTBUG-XXX" is documented in there. Unsure if there are other undocumented practices as well.

Re: [Development] Git commit hook keywords

2012-09-15 Thread Giuseppe D'Angelo
On 15 September 2012 22:56, Laszlo Papp wrote: > Hi, > > I have two minor questions: > > 1) How are new contributors (or even old time) supposed to use the git > commit hooks? Is it documented somewhere? Could something like that be > documented on, or referenced from the Gerrit introduction and c

[Development] Git commit hook keywords

2012-09-15 Thread Laszlo Papp
Hi, I have two minor questions: 1) How are new contributors (or even old time) supposed to use the git commit hooks? Is it documented somewhere? Could something like that be documented on, or referenced from the Gerrit introduction and contribution pages? Currently the procedure is just to grep t