Re: [Development] Foreign windows, embedding and transiency

2012-12-17 Thread Alberto Mardegan
On 12/12/2012 05:24 PM, Alberto Mardegan wrote: > I got a WIP branch up for preliminary review: > > https://codereview.qt-project.org/#change,42633 > > Any hints (especially on how to write automated tests for the feature) > are very welcome :-) > > I tested it with a simple client and a Gtk socket

Re: [Development] Foreign windows, embedding and transiency

2012-12-12 Thread Alberto Mardegan
On 12/12/2012 05:30 PM, Thiago Macieira wrote: > But that change should have targeted the dev branch. It's new API and a new > feature. Indeed! Though I was just interested in sharing the code with people for early feedback, so I didn't pay much care to the target branch. I'll move the next iter

Re: [Development] Foreign windows, embedding and transiency

2012-12-12 Thread Thiago Macieira
On quarta-feira, 12 de dezembro de 2012 17.24.17, Alberto Mardegan wrote: > I got a WIP branch up for preliminary review: > > https://codereview.qt-project.org/#change,42633 > > Any hints (especially on how to write automated tests for the feature) > are very welcome :-) > > I tested it with a s

Re: [Development] Foreign windows, embedding and transiency

2012-12-12 Thread Alberto Mardegan
I got a WIP branch up for preliminary review: https://codereview.qt-project.org/#change,42633 Any hints (especially on how to write automated tests for the feature) are very welcome :-) I tested it with a simple client and a Gtk socket, and it mostly works (still some focusing issues...). Cia

Re: [Development] Foreign windows, embedding and transiency

2012-12-11 Thread Sorvig Morten
On Dec 11, 2012, at 1:30 PM, Alberto Mardegan wrote: > OK. Though I'd prefer to call it Qt::ForeignWindow, to make it obvious > that it's not owned by this process (Qt::NativeWindow just seems to tell > that the QWindow is associated with a native window, which is always > true, AFAIU). Yes,

Re: [Development] Foreign windows, embedding and transiency

2012-12-11 Thread Samuel Rødal
On 12/11/2012 01:30 PM, Alberto Mardegan wrote: > On 12/11/2012 12:47 PM, Sorvig Morten wrote: >> I've been planning this a bit from he perspective if the Cocoa port, here's >> what I think I need: >> >> - A Qt::WindowFlags flag ("Qt::NativeWindow") > > OK. Though I'd prefer to call it Qt::Foreign

Re: [Development] Foreign windows, embedding and transiency

2012-12-11 Thread Alberto Mardegan
On 12/11/2012 12:47 PM, Sorvig Morten wrote: > I've been planning this a bit from he perspective if the Cocoa port, here's > what I think I need: > > - A Qt::WindowFlags flag ("Qt::NativeWindow") OK. Though I'd prefer to call it Qt::ForeignWindow, to make it obvious that it's not owned by this p

Re: [Development] Foreign windows, embedding and transiency

2012-12-11 Thread Samuel Rødal
On 12/11/2012 12:45 PM, Sletta Gunnar wrote: > > On Dec 11, 2012, at 12:33 PM, Samuel Rødal > wrote: > >> On 12/11/2012 12:03 PM, Alberto Mardegan wrote: >>> Hi all, >>> while digging a bit more deeply into the code of QX11EmbedWidget (in >>> order to port it to Qt5), I started wondering if

Re: [Development] Foreign windows, embedding and transiency

2012-12-11 Thread Sorvig Morten
On Dec 11, 2012, at 12:33 PM, Samuel Rødal wrote: >> >> In order to create a QWindow for a foreign window, there might be a >> special subclass of QWindow (QForeignWindow?) or maybe it could just be >> a QWindow with a special Qt::ForeignWindow flag (and maybe a constructor >> like QWindow::QWin

Re: [Development] Foreign windows, embedding and transiency

2012-12-11 Thread Sletta Gunnar
On Dec 11, 2012, at 12:33 PM, Samuel Rødal wrote: > On 12/11/2012 12:03 PM, Alberto Mardegan wrote: >> Hi all, >>while digging a bit more deeply into the code of QX11EmbedWidget (in >> order to port it to Qt5), I started wondering if we really need a >> special API for embedding, or whether

Re: [Development] Foreign windows, embedding and transiency

2012-12-11 Thread Samuel Rødal
On 12/11/2012 12:03 PM, Alberto Mardegan wrote: > Hi all, > while digging a bit more deeply into the code of QX11EmbedWidget (in > order to port it to Qt5), I started wondering if we really need a > special API for embedding, or whether QWindow could already offer most > of it: > > == >

[Development] Foreign windows, embedding and transiency

2012-12-11 Thread Alberto Mardegan
Hi all, while digging a bit more deeply into the code of QX11EmbedWidget (in order to port it to Qt5), I started wondering if we really need a special API for embedding, or whether QWindow could already offer most of it: == QWindow::QWindow(QWindow * parent) Creates a window a