Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Stephen Kelly
On Friday, July 13, 2012 12:00:07 Thiago Macieira wrote: > On sexta-feira, 13 de julho de 2012 11.51.07, Stephen Kelly wrote: > > > You can't connect to the private signal because the type > > > QPrivateSignal is private. > > > > I added some unit tests for this case: > > > > https://codereview.q

Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Thiago Macieira
On sexta-feira, 13 de julho de 2012 11.51.07, Stephen Kelly wrote: > > You can't connect to the private signal because the type QPrivateSignal is > > private. > > I added some unit tests for this case: > > https://codereview.qt-project.org/30762 Why did the change have to be in Q_OBJECT? Couldn't

Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Stephen Kelly
On Friday, July 13, 2012 08:33:42 Girish Ramakrishnan wrote: > Hi, > > On Wed, Jul 11, 2012 at 10:40 PM, Olivier Goffart wrote: > > On Wednesday 11 July 2012 18:50:15 Stephen Kelly wrote: > >> So, either the code should stay as is - leaving the signals private > >> and > >> making function pointe

Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Stephen Kelly
On Friday, July 13, 2012 09:30:44 Thiago Macieira wrote: > On sexta-feira, 13 de julho de 2012 08.33.42, Girish Ramakrishnan wrote: > > Hi, > > > > On Wed, Jul 11, 2012 at 10:40 PM, Olivier Goffart wrote: > > > On Wednesday 11 July 2012 18:50:15 Stephen Kelly wrote: > > >> So, either the code sh

Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Thiago Macieira
On sexta-feira, 13 de julho de 2012 10.07.04, Olivier Goffart wrote: > > > signals: > > > void somethingChanged(); > > > void somethingChanged(int, QPrivateSignal); > > > > > > You can't connect to the private signal because the type QPrivateSignal > > > is > > > private. > > > > Yes that's

Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Olivier Goffart
On Friday 13 July 2012 09:57:49 Olivier Goffart wrote: > On Friday 13 July 2012 09:30:44 Thiago Macieira wrote: > > On sexta-feira, 13 de julho de 2012 08.33.42, Girish Ramakrishnan wrote: > > > Is this really important given that we are in feature freeze? Changes > > > to moc, however small, is no

Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Olivier Goffart
On Friday 13 July 2012 09:30:44 Thiago Macieira wrote: > On sexta-feira, 13 de julho de 2012 08.33.42, Girish Ramakrishnan wrote: > > Is this really important given that we are in feature freeze? Changes > > to moc, however small, is not advisable at all. This is why we brought the subject on th

Re: [Development] Fixing connecting to private signals

2012-07-13 Thread Thiago Macieira
On sexta-feira, 13 de julho de 2012 08.33.42, Girish Ramakrishnan wrote: > Hi, > > On Wed, Jul 11, 2012 at 10:40 PM, Olivier Goffart wrote: > > On Wednesday 11 July 2012 18:50:15 Stephen Kelly wrote: > >> So, either the code should stay as is - leaving the signals private and > >> making function

Re: [Development] Fixing connecting to private signals

2012-07-12 Thread Girish Ramakrishnan
Hi, On Wed, Jul 11, 2012 at 10:40 PM, Olivier Goffart wrote: > On Wednesday 11 July 2012 18:50:15 Stephen Kelly wrote: >> So, either the code should stay as is - leaving the signals private and >> making function pointer connects not work, or the patches should be >> applied, making function poin

Re: [Development] Fixing connecting to private signals

2012-07-11 Thread Olivier Goffart
On Wednesday 11 July 2012 18:50:15 Stephen Kelly wrote: > On Wednesday, July 11, 2012 18:40:10 Thiago Macieira wrote: > > I don't see the point of a private signal. > > > > QAbstractitemModel is abusing it. Just make them regular signals. Do you see the point of the private or protected keyword

Re: [Development] Fixing connecting to private signals

2012-07-11 Thread Stephen Kelly
On Wednesday, July 11, 2012 18:40:10 Thiago Macieira wrote: > On quarta-feira, 11 de julho de 2012 18.13.07, Stephen Kelly wrote: > > Hi there, > > > > With the function-pointer-based QObject::connect syntax, it is currently > > not possible to connect to the private signals on QAbstractItemModel

Re: [Development] Fixing connecting to private signals

2012-07-11 Thread Thiago Macieira
On quarta-feira, 11 de julho de 2012 18.13.07, Stephen Kelly wrote: > Hi there, > > With the function-pointer-based QObject::connect syntax, it is currently not > possible to connect to the private signals on QAbstractItemModel > (rowsInserted() etc), QAbstractState (entered() and exited()) and > Q

[Development] Fixing connecting to private signals

2012-07-11 Thread Stephen Kelly
Hi there, With the function-pointer-based QObject::connect syntax, it is currently not possible to connect to the private signals on QAbstractItemModel (rowsInserted() etc), QAbstractState (entered() and exited()) and QAbstractTransition (triggered()). Patches for fixing that are here: * ht