Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Knoll Lars
Yes, you still have the weekend. I don’t think we’ll create the 5.4 branch before Monday. Cheers, Lars On 08/08/14 17:28, "Thiago Macieira" wrote: >On Friday 08 August 2014 19:26:25 Иван Комиссаров wrote: >> Should i continue pushing changes to dev branch or switch to 5.4? > >5.4 once it exists

Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Thiago Macieira
On Friday 08 August 2014 19:26:25 Иван Комиссаров wrote: > Should i continue pushing changes to dev branch or switch to 5.4? 5.4 once it exists, dev until then. > > Is there anyone who will review during weekend? :-P I'm around. I'm not receiving Gerrit email, but I am looking at the Dashboard

Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Иван Комиссаров
Should i continue pushing changes to dev branch or switch to 5.4? Is there anyone who will review during weekend? :-P Иван Комиссаров 08 авг. 2014 г., в 19:21, Thiago Macieira написал(а): > On Friday 08 August 2014 11:13:47 Marc Mutz wrote: >> Hi Lars, >> >> the above two classes are next to

Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Thiago Macieira
On Friday 08 August 2014 11:13:47 Marc Mutz wrote: > Hi Lars, > > the above two classes are next to compled, but will fail the deadline by a > few hours, max. The're both in the seventies, change-set wise, and have at > one point or another been already accepted. > > https://codereview.qt-proje

[Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Marc Mutz
Hi Lars, the above two classes are next to compled, but will fail the deadline by a few hours, max. The're both in the seventies, change-set wise, and have at one point or another been already accepted. https://codereview.qt-project.org/73945 https://codereview.qt-project.org/82170 I think