Re: [Development] Contribution: Windows Stock Icons

2015-11-17 Thread Frank Richter
Hi, on newer Windows systems some stock icons come in a wealth of sizes for various scaling needs. For example, on Windows 10 some icons are available in 11 different sizes! (Including 256x256.) Hardcoding a "small" and "large" size doesn't really do them justice (even if you'd consider the "shell"

Re: [Development] Contribution: Windows Stock Icons

2015-11-17 Thread Giuseppe D'Angelo
On Sat, Nov 14, 2015 at 2:03 PM, Frank Richter wrote: > Of course I'd very much like to see this make it; however, I think that > before starting to submit individual patches for review maybe a bit of > "approach review" might be a good idea. > * Are these changes desireable? > * What do you think

Re: [Development] Contribution: Windows Stock Icons

2015-11-17 Thread Benjamin TERRIER
Hi, For the first point I think it is a good idea. However the second point seems to be already taken care of. As far as i know, the current API for obtaining such icons is QStyle::standardIcon(), looking at its implementation in QCommonStyle, it calls QPlatformTheme::standardPixmap() for multipl

[Development] Contribution: Windows Stock Icons

2015-11-14 Thread Frank Richter
Hello everybody, I made some (non-trivial) changes to the Windows stock icon implementation. The goals were 1. Use public/"modern" APIs as much as possible to obtain the icons. 2. Make the various different resolutions stock icons are provided in available to Qt. For the first goal I changed to co