Re: [Development] Compatability break in QUrl in Qt 4.8

2012-02-02 Thread ext-aapo.haapanen
On 01 February 2012 22:17 Thiago Macieira wrote: > Aapo, that settles it then. > > Please submit the reversal for the 4.8 branch and feel free to cherry-pick it > to 4.8.0-symbian. Ok, I updated my earlier proposal with some documentation on how relative urls are handled. http://codereview.qt-

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-02-01 Thread Thiago Macieira
On Wednesday, 1 de February de 2012 17.57.57, lars.kn...@nokia.com wrote: > I'm also in favor of keeping the 4.7 behavior if it causes quite some apps > to break. It's not really important enough to break this in the last minor > release we do in 4.x. > > Let's get this sorted and fully fixed in 5.

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-02-01 Thread lars.knoll
I'm also in favor of keeping the 4.7 behavior if it causes quite some apps to break. It's not really important enough to break this in the last minor release we do in 4.x. Let's get this sorted and fully fixed in 5.0 Cheers, Lars On 1/31/12 1:24 PM, "ext Thiago Macieira" wrote: >On Tuesday, 31

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-31 Thread Thiago Macieira
On Tuesday, 31 de January de 2012 11.57.01, shane.kea...@accenture.com wrote: > The documentation note about the dangers of constructing QUrl from QString > was already there in 4.6 (at the bottom of the page) However, > QT_NO_URL_CAST_FROM_STRING is not defined by default, so there are no > compil

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-31 Thread shane.kearns
> Fair enough. > > Other opinions around? Olivier has already said he's for reverting to > the old > 4.7 behaviour. > The documentation note about the dangers of constructing QUrl from QString was already there in 4.6 (at the bottom of the page) However, QT_NO_URL_CAST_FROM_STRING is not defined b

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-31 Thread Thiago Macieira
On Tuesday, 31 de January de 2012 13.22.16, Robin Burchell wrote: > 2012/1/31 Thiago Macieira : > > Other opinions around? Olivier has already said he's for reverting to the > > old 4.7 behaviour. > > I'm for keeping it. Early silent breakage now lessens the amount of > silent breakage 5.0 will cau

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-31 Thread Robin Burchell
2012/1/31 Thiago Macieira : > Other opinions around? Olivier has already said he's for reverting to the old > 4.7 behaviour. I'm for keeping it. Early silent breakage now lessens the amount of silent breakage 5.0 will cause code. ___ Development mailing

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-31 Thread Thiago Macieira
On Tuesday, 31 de January de 2012 10.34.52, ext-aapo.haapa...@nokia.com wrote: > On 30 January 2012 17:34 Thiago Macieira wrote: > > There was no break of binary or source compatibility. It was a change of > > behaviour because the previous behaviour was considered buggy (by me). > > > > Every bug

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-31 Thread ext-aapo.haapanen
On 30 January 2012 17:34 Thiago Macieira wrote: > There was no break of binary or source compatibility. It was a change of > behaviour because the previous behaviour was considered buggy (by me). > > Every bug fix is a change in behaviour. Your reasons why this change is neede make a lot of sense

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-30 Thread Thiago Macieira
On Monday, 30 de January de 2012 16.53.41, Olivier Goffart wrote: > On Monday 30 January 2012 16:35:04 Thiago Macieira wrote: > > On Monday, 30 de January de 2012 16.19.25, Olivier Goffart wrote: > > > This actually broke sounds notification in KDE > > > https://bugs.kde.org/show_bug.cgi?id)1333 >

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-30 Thread Olivier Goffart
On Monday 30 January 2012 16:35:04 Thiago Macieira wrote: > On Monday, 30 de January de 2012 16.19.25, Olivier Goffart wrote: > > This actually broke sounds notification in KDE > > https://bugs.kde.org/show_bug.cgi?id=291333 > > https://bugs.kde.org/show_bug.cgi?id=288764 > > Read: "the sound noti

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-30 Thread Robin Burchell
2012/1/30 Thiago Macieira : > That said, I could be convinced that the effort is too great and that the > possibility of the already-existing bugs showing up. In that case, I could be > convinced of changing this behaviour in Qt 4.8.1 back to what it was in 4.7. > But I will definitely not be convi

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-30 Thread Thiago Macieira
On Monday, 30 de January de 2012 16.19.25, Olivier Goffart wrote: > This actually broke sounds notification in KDE > https://bugs.kde.org/show_bug.cgi?id)1333 > https://bugs.kde.org/show_bug.cgi?id(8764 Read: "the sound notification in KDE was buggy before, now it simply stopped working completely

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-30 Thread Thiago Macieira
On Monday, 30 de January de 2012 13.30.32, ext-aapo.haapa...@nokia.com wrote: > The change concerns how toLocalFile() handles relative urls. Before 4.8 it > returned the path, but in 4.8 it returns an empty string. 4.7: > QUrl("dir/file.html").toLocalFile(); returns "dir/file.html" 4.8: > QUrl("dir

Re: [Development] Compatability break in QUrl in Qt 4.8

2012-01-30 Thread Olivier Goffart
On Monday 30 January 2012 13:30:32 ext-aapo.haapa...@nokia.com wrote: > Hi, > > The behaviour of QUrl::toLocalFile() was changed between Qt 4.7.4 and 4.8. I > would like to open discussion for reverting that change for 4.8 in order to > maintain backward compatibility for applications. > > The

[Development] Compatability break in QUrl in Qt 4.8

2012-01-30 Thread ext-aapo.haapanen
Hi, The behaviour of QUrl::toLocalFile() was changed between Qt 4.7.4 and 4.8. I would like to open discussion for reverting that change for 4.8 in order to maintain backward compatibility for applications. The change concerns how toLocalFile() handles relative urls. Before 4.8 it returned the