Re: [Development] Coding style: space after comma

2018-07-16 Thread Edward Welbourne
On Tuesday, 3 July 2018 07:37:25 PDT Edward Welbourne wrote: >> Derived:Derived(Type arg, Mode um, Form ent) >> >> : Base(arg) >> >> , mem(um) >> , ber(ent) >> {} Thiago Macieira (16 July 2018 17:48) > There are spaces before these commas, so they don't conform to coding > style now. New

Re: [Development] Coding style: space after comma

2018-07-16 Thread Thiago Macieira
On Tuesday, 3 July 2018 07:37:25 PDT Edward Welbourne wrote: > Derived:Derived(Type arg, Mode um, Form ent) > > : Base(arg) > > , mem(um) > , ber(ent) > {} There are spaces before these commas, so they don't conform to coding style now. Newlines are whitespace, so even if you flushed

Re: [Development] Coding style: space after comma

2018-07-16 Thread Edward Welbourne
I (3 July 2018 16:37) wrote: > [0] https://wiki.qt.io/Qt_Coding_Style > > I propose to follow (under "Whitespace") the list item > > * Surround binary operators with spaces > > with > > * Leave a space after each comma > > Any objections, or improved wordings ? Hearing no objections or suggest

[Development] Coding style: space after comma

2018-07-03 Thread Edward Welbourne
I notice that our coding style [0] doesn't actually say out loud that we expect a space after each comma (and none before). Its sole mention of comma is that it goes at a line-end, unlike operators at line-start, on a continued line. Yet the Qt code-base is mostly consistent about this and I've s