Re: [Development] Code Review of Build File Changes

2022-07-26 Thread Mattie Nejati
___ From: Development on behalf of Mattie Nejati Sent: Friday, July 22, 2022 9:39 AM To: development@qt-project.org Subject: Re: [Development] Code Review of Build File Changes Hi again! Thank you all for your interest in the discussion. Reading through your responses gave us a better understa

Re: [Development] Code Review of Build File Changes

2022-07-22 Thread Mattie Nejati
hesitate to sign up using the link below. Sign up link: https://forms.gle/Yec6ZvCemNiLktwr5 Best, Mattie From: Development on behalf of Mattie Nejati Sent: Wednesday, July 20, 2022 2:29 PM To: development@qt-project.org Subject: [Development] Code Review of Build

Re: [Development] Code Review of Build File Changes

2022-07-21 Thread Thiago Macieira
On Thursday, 21 July 2022 00:54:28 PDT Volker Hilsheimer wrote: > These would be observable, quantifiable measurements. And if one of the > reason for those measurements is “there are very few people who can review > build system changes”, then that’s a qualitative statement, getting to > which see

Re: [Development] Code Review of Build File Changes

2022-07-21 Thread Edward Welbourne
On Wednesday, 20 July 2022 11:29:57 PDT Mattie Nejati wrote: >> I’m Mattie, a Ph.D. student at the University of Waterloo and I’ve >> been studying the code review process of build files in Qt. For >> example, I’ve found that changes to build files are 2 to 4 times less >> likely to be discussed du

Re: [Development] Code Review of Build File Changes

2022-07-21 Thread Volker Hilsheimer
> On 21 Jul 2022, at 00:30, Thiago Macieira wrote: > > On Wednesday, 20 July 2022 11:29:57 PDT Mattie Nejati wrote: >> I’m Mattie, a Ph.D. student at the University of Waterloo and I’ve been >> studying the code review process of build files in Qt. For example, I’ve >> found that changes to bui

Re: [Development] Code Review of Build File Changes

2022-07-20 Thread Thiago Macieira
On Wednesday, 20 July 2022 11:29:57 PDT Mattie Nejati wrote: > I’m Mattie, a Ph.D. student at the University of Waterloo and I’ve been > studying the code review process of build files in Qt. For example, I’ve > found that changes to build files are 2 to 4 times less likely to be > discussed during

Re: [Development] Code Review of Build File Changes

2022-07-20 Thread Mattie Nejati
Note that the form no longer requires participants to use a Google account. Best, Mattie From: Development on behalf of Mattie Nejati Sent: Wednesday, July 20, 2022 2:29 PM To: development@qt-project.org Subject: [Development] Code Review of Build File Changes

[Development] Code Review of Build File Changes

2022-07-20 Thread Mattie Nejati
Hi Developers, I’m Mattie, a Ph.D. student at the University of Waterloo and I’ve been studying the code review process of build files in Qt. For example, I’ve found that changes to build files are 2 to 4 times less likely to be discussed during code review than changes to source code or test