Re: [Development] ChangeLog entries and reverted commits

2017-07-31 Thread Thiago Macieira
On Monday, 31 July 2017 00:07:35 PDT Joerg Bornemann wrote: > Suppose you create a new feature in commit A for Qt 5.x. The commit > message has a change log entry. After a while A has to be reverted. You > won't have time to fix the issue properly for 5.x. The git history for > 5.x still contains t

Re: [Development] ChangeLog entries and reverted commits

2017-07-31 Thread Oswald Buddenhagen
On Mon, Jul 31, 2017 at 09:07:35AM +0200, Jörg Bornemann wrote: > Suppose you create a new feature in commit A for Qt 5.x. The commit > message has a change log entry. After a while A has to be reverted. You > won't have time to fix the issue properly for 5.x. The git history for > 5.x still con

Re: [Development] ChangeLog entries and reverted commits

2017-07-31 Thread Christian Kandeler
On Mon, 31 Jul 2017 11:11:41 +0200 Friedemann Kleint wrote: > have a look at https://codereview.qt-project.org/#/c/201164/ for the > Perl script. Are the two scripts competing or do they complement each other in some way? Christian ___ Development m

Re: [Development] ChangeLog entries and reverted commits

2017-07-31 Thread Friedemann Kleint
Hi, have a look at https://codereview.qt-project.org/#/c/201164/ for the Perl script. Friedemann -- Friedemann Kleint The Qt Company GmbH ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/developme

Re: [Development] ChangeLog entries and reverted commits

2017-07-31 Thread Edward Welbourne
Joerg Bornemann (31 July 2017 09:07) > Suppose you create a new feature in commit A for Qt 5.x. The commit > message has a change log entry. After a while A has to be > reverted. You won't have time to fix the issue properly for 5.x. The > git history for 5.x still contains the change log entry -

[Development] ChangeLog entries and reverted commits

2017-07-31 Thread Joerg Bornemann
Suppose you create a new feature in commit A for Qt 5.x. The commit message has a change log entry. After a while A has to be reverted. You won't have time to fix the issue properly for 5.x. The git history for 5.x still contains the change log entry - now erronously. Is the script that create