Re: [Development] Backporting the Keccak change

2017-09-14 Thread Thiago Macieira
On Wednesday, 30 August 2017 12:45:44 PDT Thiago Macieira wrote: > I'm actually leaning towards for 5.6 and (b) for 5.9. 5.9 change: https://codereview.qt-project.org/205458 I'll give it another day for any further reviews. It's already approved, so if no one raises any red flags, I'll apply it

Re: [Development] Backporting the Keccak change

2017-09-05 Thread Thiago Macieira
On Tuesday, 5 September 2017 14:04:14 -03 Oswald Buddenhagen wrote: > On Tue, Sep 05, 2017 at 10:29:44AM -0300, Thiago Macieira wrote: > > On Tuesday, 5 September 2017 05:09:19 -03 Oswald Buddenhagen wrote: > > > # ifndef QT_FIXED_SHA3 > > > > > >QT_DEPRECATED_SINCE(5, 10, 0) Sha3_224 = 7

Re: [Development] Backporting the Keccak change

2017-09-05 Thread Oswald Buddenhagen
On Tue, Sep 05, 2017 at 10:29:44AM -0300, Thiago Macieira wrote: > On Tuesday, 5 September 2017 05:09:19 -03 Oswald Buddenhagen wrote: > > # ifndef QT_FIXED_SHA3 > >QT_DEPRECATED_SINCE(5, 10, 0) Sha3_224 = 7, > >QT_DEPRECATED_SINCE(5, 10, 0) Sha3_256, > >QT_DEPRECATED_SINCE

Re: [Development] Backporting the Keccak change

2017-09-05 Thread Thiago Macieira
On Tuesday, 5 September 2017 05:09:19 -03 Oswald Buddenhagen wrote: > # ifndef QT_FIXED_SHA3 >QT_DEPRECATED_SINCE(5, 10, 0) Sha3_224 = 7, >QT_DEPRECATED_SINCE(5, 10, 0) Sha3_256, >QT_DEPRECATED_SINCE(5, 10, 0) Sha3_384, >QT_DEPRECATED_SINCE(5, 10, 0) Sha3_512, > #

Re: [Development] Backporting the Keccak change

2017-09-05 Thread Oswald Buddenhagen
On Tue, Sep 05, 2017 at 06:57:38AM +, Lars Knoll wrote: > On 4 Sep 2017, at 14:12, Thiago Macieira wrote: > > 2) enum names > > I'd like to do: > > > >Keccak_224 = 7, > >Keccak_256, > >Keccak_384, > >Keccak_512 > >RealSha3_224 = 11, > >RealSha3_

Re: [Development] Backporting the Keccak change

2017-09-04 Thread Lars Knoll
> On 4 Sep 2017, at 14:12, Thiago Macieira wrote: > > On Monday, 4 September 2017 03:30:31 -03 Lars Knoll wrote: >> I think we should in any case also introduce the keccak enum values. I'm ok, >> if one of them aliases Sha3_512 (which we should then deprecate) and you >> add a new enum value for

Re: [Development] Backporting the Keccak change

2017-09-04 Thread Thiago Macieira
On Monday, 4 September 2017 03:30:31 -03 Lars Knoll wrote: > I think we should in any case also introduce the keccak enum values. I'm ok, > if one of them aliases Sha3_512 (which we should then deprecate) and you > add a new enum value for the correct Sha3 algorithm. Confirm your thinking, please.

Re: [Development] Backporting the Keccak change

2017-09-03 Thread Lars Knoll
On 3 Sep 2017, at 03:10, Thiago Macieira mailto:thiago.macie...@intel.com>> wrote: On Saturday, 2 September 2017 12:03:13 PDT Oswald Buddenhagen wrote: On Wed, Aug 30, 2017 at 12:45:44PM -0700, Thiago Macieira wrote: a) revert the 5.6 backport of 88a8feeacb9bdaff9ee06164424e407eb904cd10 so that

Re: [Development] Backporting the Keccak change

2017-09-03 Thread Harri Porten
On Sat, 2 Sep 2017, Oswald Buddenhagen wrote: if we wanted to be really conservative, we'd leave the old meaning of the sha3 constants and introduce realSha3 (or something to that effect) instead, in 5.10+. keccak aliases would be also provided for a smooth migration. Fwiw, I would have apprec

Re: [Development] Backporting the Keccak change

2017-09-02 Thread Thiago Macieira
On Saturday, 2 September 2017 12:03:13 PDT Oswald Buddenhagen wrote: > On Wed, Aug 30, 2017 at 12:45:44PM -0700, Thiago Macieira wrote: > > a) revert the 5.6 backport of 88a8feeacb9bdaff9ee06164424e407eb904cd10 so > > > > that 5.6.x will forever calculate Keccak, not SHA3; > > > > b) additional

Re: [Development] Backporting the Keccak change

2017-09-02 Thread Oswald Buddenhagen
On Wed, Aug 30, 2017 at 12:45:44PM -0700, Thiago Macieira wrote: > a) revert the 5.6 backport of 88a8feeacb9bdaff9ee06164424e407eb904cd10 so > that 5.6.x will forever calculate Keccak, not SHA3; > > b) additionally backport 12c5264d9add1826d543c36d893db77262195fc6 to both > 5.6 > and 5.9, wit

Re: [Development] Backporting the Keccak change

2017-08-31 Thread Lars Knoll
On 31 Aug 2017, at 08:57, Thiago Macieira mailto:thiago.macie...@intel.com>> wrote: On Wednesday, 30 August 2017 23:12:40 PDT Lars Knoll wrote: a) revert the 5.6 backport of 88a8feeacb9bdaff9ee06164424e407eb904cd10 so that 5.6.x will forever calculate Keccak, not SHA3; b) additionally backport

Re: [Development] Backporting the Keccak change

2017-08-30 Thread Thiago Macieira
On Wednesday, 30 August 2017 23:12:40 PDT Lars Knoll wrote: > > a) revert the 5.6 backport of 88a8feeacb9bdaff9ee06164424e407eb904cd10 so > > that 5.6.x will forever calculate Keccak, not SHA3; > > > > b) additionally backport 12c5264d9add1826d543c36d893db77262195fc6 to both > > 5.6 and 5.9, with

Re: [Development] Backporting the Keccak change

2017-08-30 Thread Lars Knoll
> On 30 Aug 2017, at 21:45, Thiago Macieira wrote: > > When writing the 5.6.3 changelog, I'm currently leaving it with: > > ** > * Important Behavior Changes * > *

[Development] Backporting the Keccak change

2017-08-30 Thread Thiago Macieira
When writing the 5.6.3 changelog, I'm currently leaving it with: ** * Important Behavior Changes * ***