Re: [Development] Apparently dead code: GPU_BLACKLIST and friends

2018-08-08 Thread Edward Welbourne
I wrote: > I notice that QTest includes support, in [0], alongside its BLACKLIST > files for problematic tests, for a GPU_BLACKLIST file; [...] > > Inevitably, I'm contemplating a featurectomy. The reviews can be found here: https://codereview.qt-project.org/#/q/status:open+branch:dev+topic:gpu-b

Re: [Development] Apparently dead code: GPU_BLACKLIST and friends

2018-08-08 Thread Edward Welbourne
>>> I'm not the only one : >>> https://github.com/search?p=1&q=QTEST_ADD_GPU_BLACKLIST_SUPPORT_DEFS&type=Code On 08/08/2018 01:41 PM, Edward Welbourne wrote: >> This URL got me: >> >> We could not perform this search >>Must include at least one user, organization, or repo

Re: [Development] Apparently dead code: GPU_BLACKLIST and friends

2018-08-08 Thread Joerg Bornemann
On 08/08/2018 01:41 PM, Edward Welbourne wrote: I'm not the only one : https://github.com/search?p=1&q=QTEST_ADD_GPU_BLACKLIST_SUPPORT_DEFS&type=Code This URL got me: We could not perform this search Must include at least one user, organization, or repository so I'm

Re: [Development] Apparently dead code: GPU_BLACKLIST and friends

2018-08-08 Thread Edward Welbourne
I wrote: >> Inevitably, I'm contemplating a featurectomy. Jean-Michaël Celerier (8 August 2018 13:33) replied > I remember using it to be able to run integration tests on a virtual X11 > server in Travis CI. How long ago ? Are you *still* using it for this ? Do you anticipate using it with 5.12

Re: [Development] Apparently dead code: GPU_BLACKLIST and friends

2018-08-08 Thread Jean-Michaël Celerier
> Inevitably, I'm contemplating a featurectomy. Laszlo, who introduced this for some fragile embedded systems in 2015, doesn't believe it's in use, I don't see any evidence that it's documented anywhere (so I don't expect anyone to be using it outside Qt itself *and* I can only work out how it's

[Development] Apparently dead code: GPU_BLACKLIST and friends

2018-08-08 Thread Edward Welbourne
Hi all, I notice that QTest includes support, in [0], alongside its BLACKLIST files for problematic tests, for a GPU_BLACKLIST file; there are, however, no GPU_BLACKLIST files anywhere in our source tree (in any currently live branch, from 5.6 to dev). There's a whole complex QTEST_ADD_GPU_BLACKL