Re: [Development] API review for the new QUrl

2011-11-04 Thread Thiago Macieira
On Friday, 4 de November de 2011 17:14:35 Stephen Kelly wrote: > On Tuesday, October 25, 2011 11:59:54 Thiago Macieira wrote: > > QStringList allQueryItemValues(const QString &key, > > > > QUrl::ComponentFormattingOptions encoding = QUrl::PrettyDecoded) const; > > Does this return all values fo

Re: [Development] API review for the new QUrl

2011-11-04 Thread Stephen Kelly
On Tuesday, October 25, 2011 11:59:54 Thiago Macieira wrote: > QStringList allQueryItemValues(const QString &key, > QUrl::ComponentFormattingOptions encoding = QUrl::PrettyDecoded) const; Does this return all values for the key? If the query string is a=4&a=5&a=6, then queryObject.allQuery

Re: [Development] API review for the new QUrl

2011-11-01 Thread Peter Hartmann
On 10/31/2011 05:42 PM, ext Thiago Macieira wrote: > (...) >>>- QUrlQuery does not keep the order of the items (it's kept in a hash). >>>Is >>> >>> the order important? >> >> I would prefer if the order was kept; e.g. for using OAuth, the >> parameters need to be sorted in alphabetical orde

Re: [Development] API review for the new QUrl

2011-10-31 Thread Thiago Macieira
On Monday, 31 de October de 2011 16:40:32 Peter Hartmann wrote: > On 10/25/2011 11:59 AM, ext Thiago Macieira wrote: > > I can't post the code just yet, but I can post the new API. > > > > Questions: > > - I un-deprecated fromEncoded and toEncoded, as they're used everywhere. > > > > Should I d

Re: [Development] API review for the new QUrl

2011-10-31 Thread Peter Hartmann
On 10/25/2011 11:59 AM, ext Thiago Macieira wrote: > I can't post the code just yet, but I can post the new API. > > Questions: > - I un-deprecated fromEncoded and toEncoded, as they're used everywhere. > Should I do the same for fromPercentEncoding and toPercentEncoding? They > convert from QStr

[Development] API review for the new QUrl

2011-10-25 Thread Thiago Macieira
I can't post the code just yet, but I can post the new API. Questions: - I un-deprecated fromEncoded and toEncoded, as they're used everywhere. Should I do the same for fromPercentEncoding and toPercentEncoding? They convert from QString to QByteArray and vice-versa, while QByteArray::fromPerc