Re: [Development] [Request] Compiler warnings in Qt

2013-12-09 Thread Knoll Lars
I think this is ok for the headers, but I don’t think we’d be doing ourselves a favor if we tried to use these warnings for .cpp files. Lars On 07.12.13 20:45, "Thiago Macieira" wrote: >On sábado, 7 de dezembro de 2013 13:36:35, Kurt Pattyn wrote: >> "-Wsign-conversion"

Re: [Development] [Request] Compiler warnings in Qt

2013-12-07 Thread Thiago Macieira
On sábado, 7 de dezembro de 2013 13:36:35, Kurt Pattyn wrote: > "-Wsign-conversion" > "-Wsign-promo" > "-Wsign-compare" Oh, man. These three are extremely annoying. I now remember why we don't like unsigned types in our API..

Re: [Development] [Request] Compiler warnings in Qt

2013-12-07 Thread Thiago Macieira
On sábado, 7 de dezembro de 2013 13:38:20, Kurt Pattyn wrote: > > I still have a pending change that compiles each and every public header > > independently -Werror and defining the keywords. > > > > > > > > None of my builds with Clang or GCC have any warnings. There are a few > > with ICC beca

Re: [Development] [Request] Compiler warnings in Qt

2013-12-07 Thread Kurt Pattyn
On 07 Dec 2013, at 12:00, development-requ...@qt-project.org wrote: > From: Thiago Macieira > Subject: Re: [Development] [Request] Compiler warnings in Qt > Date: 6 Dec 2013 18:15:47 GMT+1 > To: development@qt-project.org > > > On sexta-feira, 6 de dezembro de 2013 13:4

Re: [Development] [Request] Compiler warnings in Qt

2013-12-07 Thread Kurt Pattyn
On 07 Dec 2013, at 12:00, development-requ...@qt-project.org wrote: > From: Thiago Macieira > Subject: Re: [Development] [Request] Compiler warnings in Qt > Date: 6 Dec 2013 18:16:20 GMT+1 > To: development@qt-project.org > > > On sexta-feira, 6 de dezembro de 2013 11:16:

Re: [Development] [Request] Compiler warnings in Qt

2013-12-07 Thread Olivier Goffart
On Friday 06 December 2013 09:15:47 Thiago Macieira wrote: > On sexta-feira, 6 de dezembro de 2013 13:41:34, Olivier Goffart wrote: > > There used to be a 'compilerwarnings' autotest that made sure there was no > > warning in the headers (in a more strict ways that the warnings we check > > while

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Giuseppe D'Angelo
On 6 December 2013 19:30, Smith Martin wrote: > Should I report these warnings in JIRA? Yes, please. -- Giuseppe D'Angelo ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Smith Martin
rtin.smith=digia@qt-project.org] on behalf of Thiago Macieira [thiago.macie...@intel.com] Sent: Friday, December 06, 2013 6:25 PM To: development@qt-project.org Subject: Re: [Development] [Request] Compiler warnings in Qt On sexta-feira, 6 de dezembro de 2013 17:18:02, Smith Martin wrote: > I

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Thiago Macieira
On sexta-feira, 6 de dezembro de 2013 17:18:02, Smith Martin wrote: > I get warnings with clang in OSX. It even treats an unused variable as an > error. Which makes you fix them, so we don't get warnings in the repository :-) -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architec

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Smith Martin
...@intel.com] Sent: Friday, December 06, 2013 6:16 PM To: development@qt-project.org Subject: Re: [Development] [Request] Compiler warnings in Qt On sexta-feira, 6 de dezembro de 2013 11:16:20, Kurt Pattyn wrote: > When compiling applications with compiler flags on, a lot of warnings

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Thiago Macieira
On sexta-feira, 6 de dezembro de 2013 11:16:20, Kurt Pattyn wrote: > When compiling applications with compiler flags on, a lot of warnings are > generated for the Qt header files. I Which compiler? Which warnings? We're not supposed to have any warnings with GCC or Clang. -- Thiago Macieira - th

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Thiago Macieira
On sexta-feira, 6 de dezembro de 2013 13:41:34, Olivier Goffart wrote: > There used to be a 'compilerwarnings' autotest that made sure there was no > warning in the headers (in a more strict ways that the warnings we check > while compiling Qt itself). But i think it's gone. I still have a pend

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Olivier Goffart
On Friday 06 December 2013 11:16:20 Kurt Pattyn wrote: > When compiling applications with compiler flags on, a lot of warnings are > generated for the Qt header files. It needs a lot of work to exclude them > in our builds, and some of them can just not be excluded because they are > located in mac

Re: [Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Oswald Buddenhagen
On Fri, Dec 06, 2013 at 11:16:20AM +0100, Kurt Pattyn wrote: > When compiling applications with compiler flags on, a lot of warnings are > generated for the Qt header files. > It needs a lot of work to exclude them in our builds, and some of them can > just not be excluded because they are locate

[Development] [Request] Compiler warnings in Qt

2013-12-06 Thread Kurt Pattyn
When compiling applications with compiler flags on, a lot of warnings are generated for the Qt header files. It needs a lot of work to exclude them in our builds, and some of them can just not be excluded because they are located in macros or inline methods. The same holds for the moc generated c