On 14/12/2012 8:27 PM, Martin Smith wrote:
> +1
>
> my problem with "I would prefer that you didn't submit this" is that -1 is
> often used without including an explanation of what is wrong and how it
> should be fixed.
>
> I like "This requires more work" better, but I think it will still be abu
On Fri, Dec 14, 2012 at 09:57:15AM -0800, Thiago Macieira wrote:
> On sexta-feira, 14 de dezembro de 2012 17.43.55, Oswald Buddenhagen wrote:
> > this is a self-contradicting interpretation. a minimal fully functional
> > change is not splittable (i.e., it's atomic). therefore no part of that
> > c
On sexta-feira, 14 de dezembro de 2012 17.43.55, Oswald Buddenhagen wrote:
> this is a self-contradicting interpretation. a minimal fully functional
> change is not splittable (i.e., it's atomic). therefore no part of that
> change can legally exist on its own (i.e., satisfy the criterion of
> bein
On Fri, Dec 14, 2012 at 07:46:39AM -0800, Thiago Macieira wrote:
> I don't think the feature is even enabled. We turned it on when we went live
> and immediately found problems with the implementation, some coming from the
> original description of the functionality. So we turned it off.
>
> Whe
On Fri, Dec 14, 2012 at 07:49:26AM -0800, Thiago Macieira wrote:
> On sexta-feira, 14 de dezembro de 2012 13.57.16, Oswald Buddenhagen wrote:
> > another reason is that any sane commit policy prescribes atomicity on a
> > commit level, so forced grouping of commits isn't much of an advantage.
>
>
On sexta-feira, 14 de dezembro de 2012 19.55.03, Konstantin Tokarev wrote:
> > I often read it as "it must be as small as possible" and sometimes my
> > commits are not testable by themselves.
>
> In my understanding, "small as possible" means "can be cherry-picked on its
> own"
Again, that's not
digia@qt-project.org] On
>>> Behalf Of Sergio Ahumada
>>> Sent: Friday, December 14, 2012 12:00 PM
>>> To: development@qt-project.org
>>> Subject: Re: [Development] [Qt-creator] gerrit-speak
>>>
>>> [...]
>>>
>>> They
14.12.2012, 19:49, "Thiago Macieira" :
> On sexta-feira, 14 de dezembro de 2012 13.57.16, Oswald Buddenhagen wrote:
>
>> another reason is that any sane commit policy prescribes atomicity on a
>> commit level, so forced grouping of commits isn't much of an advantage.
>
> Note that "atomicity" h
On sexta-feira, 14 de dezembro de 2012 13.57.16, Oswald Buddenhagen wrote:
> another reason is that any sane commit policy prescribes atomicity on a
> commit level, so forced grouping of commits isn't much of an advantage.
Note that "atomicity" here is ambiguous.
Ossi was referring to "this chang
> Sent: Friday, December 14, 2012 12:00 PM
> > To: development@qt-project.org
> > Subject: Re: [Development] [Qt-creator] gerrit-speak
> >
> > [...]
> >
> > They just change the implementation between minor releases.
> > Also, it seems like they don't
On 14.12.2012 13.00, "Sergio Ahumada" wrote:
>On 12/14/2012 11:54 AM, Bache-Wiig Jens wrote:
>>
>> Actually looking at the android version of gerrit which I presume would
>> be using the upstream version they have omitted the comments entirely,
>> merely using a "Code-Review +1" comment.
>> The
14.12.2012, 15:02, "Sergio Ahumada" :
> On 12/14/2012 11:54 AM, Bache-Wiig Jens wrote:
>
>>> Oh well, if you already feel offended by this phrasing, I guess you
>>> should get a thicker skin ... we've people from very different
>>> cultures and with varying English language skills in the commu
On Thu, Dec 13, 2012 at 08:50:16PM +, Jenssen Tim wrote:
> > (Rethoric: should this go to a more generic qt list?)
> >
> > Hello
> >
> > (First a side question, is there a more consequent documentation about the
> > use
> > of gerrit?)
> >
> > Is it only me that finds the "-1" review default
Re: [Development] [Qt-creator] gerrit-speak
>
> [...]
> They just change the implementation between minor releases.
> Also, it seems like they don't want our features to be up-streamed, see
> https://groups.google.com/forum/?fromgroups=#!topic/repo-
> discuss/gXjbuhfW0tg
>
On 12/14/2012 11:54 AM, Bache-Wiig Jens wrote:
>> Oh well, if you already feel offended by this phrasing, I guess you
>> should get a thicker skin ... we've people from very different
>> cultures and with varying English language skills in the community, so
>> you should just take things with a pin
Oh well, if you already feel offended by this phrasing, I guess you should get
a thicker skin ... we've people from very different cultures and with varying
English language skills in the community, so you should just take things with a
pinch of salt in general.
Anyway, the sentence is from the
On Dec 14, 2012, at 10:40 AM, Sune Vuorela wrote:
> On 2012-12-13, Jenssen Tim wrote:
>>> "I would prefer that you didn't submit this"
>>>
>>> reads to my brain much like "go f*k yourself" without the raw words.
>>>
>>> I get all the idea of the automating thing and all, and that machines have
12 10:16 PM
>> To: Jenssen Tim
>> Cc: development@qt-project.org; Cristian Tibirna
>> Subject: Re: [Development] [Qt-creator] gerrit-speak
>>
>> +1
>>
>> I have seen some people take serious issue with the phrasing; the iOS
>> contributions spring t
On 2012-12-13, Jenssen Tim wrote:
>> "I would prefer that you didn't submit this"
>>
>> reads to my brain much like "go f*k yourself" without the raw words.
>>
>> I get all the idea of the automating thing and all, and that machines have no
>> emotion, but, if I don't miss something obvious (this
> Oh well, if you already feel offended by this phrasing, I guess you should
> get a thicker skin ... we've people from very different cultures and with
> varying English language skills in the community, so you should just take
> things with a pinch of salt in general.
>
> Anyway, the sentence
> There's a point though that a lot of people (including me) are using -1 for
> 'this requires more work', and -2 for 'the patch, or target branch is just
> wrong, please abandon'. So if the intention of the patch is fine in general,
> but contains some errors, I myself tend to give -1, though i
project.org; Cristian Tibirna
> Subject: Re: [Development] [Qt-creator] gerrit-speak
>
> +1
>
> I have seen some people take serious issue with the phrasing; the iOS
> contributions spring to mind, but many people clearly feel publicly disgraced.
Oh well, if you already feel offend
+1
I have seen some people take serious issue with the phrasing; the iOS
contributions spring to mind, but many people clearly feel publicly
disgraced.
On Dec 13, 2012 12:51 PM, "Jenssen Tim" wrote:
>
> Von:
> qt-creator-bounces+tim.jenssen=digia@qt-
Von: qt-creator-bounces+tim.jenssen=digia@qt-project.org
[qt-creator-bounces+tim.jenssen=digia@qt-project.org]" im Auftrag von
"Cristian Tibirna [tibi...@kde.org]
Gesendet: Donnerstag, 13. Dezember 2012 18:15
An: qt-crea...@qt-project.org
Betreff:
24 matches
Mail list logo
