Re: [Development] [FYI] commit/review policy refactored

2016-07-13 Thread Oswald Buddenhagen
On Wed, Jul 13, 2016 at 12:15:44PM +0200, Kai Köhne wrote: > The page is obviously written from the viewpoint of a maintainer. I'd > prefer to write It in a less intimidating way to the contributor, and > make it helpful for first time, inexperienced contributors. > first-timers can ask in case of

Re: [Development] [FYI] commit/review policy refactored

2016-07-13 Thread Kai Koehne
> -Original Message- > From: Development [mailto:development-bounces+kai.koehne=qt.io@qt- > project.org] On Behalf Of Oswald Buddenhagen > Sent: Wednesday, July 13, 2016 11:08 AM > To: development@qt-project.org; qt-crea...@qt-project.org > Subject: [Development] [

Re: [Development] [FYI] commit/review policy refactored

2016-07-13 Thread Oswald Buddenhagen
On Wed, Jul 13, 2016 at 11:57:28AM +0200, Martin Smith wrote: > Sometimes I am listed as a reviewer for a code change in Qt that also involves > documentation changes. The code change is sometimes outside my expertise, but > I > assume I have been included to approve the documentation changes. I a

Re: [Development] [FYI] commit/review policy refactored

2016-07-13 Thread Martin Smith
From: Development on behalf of Oswald Buddenhagen Sent: Wednesday, July 13, 2016 11:08:07 AM To: development@qt-project.org; qt-crea...@qt-project.org Subject: [Development] [FYI] commit/review policy refactored just a heads-up that i (finally) split off the review policy

[Development] [FYI] commit/review policy refactored

2016-07-13 Thread Oswald Buddenhagen
just a heads-up that i (finally) split off the review policy from the commit policy. see https://wiki.qt.io/Review_Policy . if you have suggestions for improvement, please discuss them upfront on irc. you're expected to read the document even if you're not interested in actively improving it any t