Re: [Development] [API Review Request] QWebsockets

2013-08-27 Thread Shane Kearns
There's a fair amount of legacy code using other methods for implementing the private class pointer. Q_Q and Q_D macros are preferred though. You don't need to merge your .cpp files, we generally have one .cpp per class (though trivial classes don't always have their own file). The point is that t

Re: [Development] [API Review Request] QWebsockets

2013-08-25 Thread Kurt Pattyn
Ok, tabs has been converted into 4 spaces. Regarding the *_p.cpp files: I just did this to keep the file sizes at a reasonable size; if it is a style requirement, I can merge those files. The same holds for the other files (DataProcessor, …). If I merge them with QWebSocket.cpp, then that file w

Re: [Development] [API Review Request] QWebsockets

2013-08-25 Thread Matt Broadstone
On Sun, Aug 25, 2013 at 3:49 PM, Kurt Pattyn wrote: > Hi, > > I am about to move the QWebSockets project (see: > http://github.com/KurtPattyn/QWebSockets) to the playground. > Could you please review the API? > > Just some quick stylistic observations: * you don't usually make a class_p.cpp (imp

[Development] [API Review Request] QWebsockets

2013-08-25 Thread Kurt Pattyn
Hi, I am about to move the QWebSockets project (see: http://github.com/KurtPattyn/QWebSockets) to the playground. Could you please review the API? Notes: The public API is QWebSocket and QWebSocketServer; all other classes are internal. The APIs of both classes were modelled after QAbstractSock