Re: [Development] Allowed C++11 features [was: Re: Re: MSVC2012 in CI]

2016-03-21 Thread Poenitz Andre
Sean Harmer wrote: > On Monday 21 March 2016 12:23:44 Poenitz Andre wrote: > > I will argue that if user code looks ugly by default, or needs one specific, > > controversial coding style when using an API, the API is bad. > > > > A possible question here is why

Re: [Development] Allowed C++11 features [was: Re: Re: MSVC2012 in CI]

2016-03-21 Thread Poenitz Andre
Marc Mutz wrote: > On Monday 21 March 2016 12:07:24 Poenitz Andre wrote: > > Marc Mutz wrote: > > > I said then and I repeat it now that imho template aliases are not > > > interesting for library development. In particular, I don't think > > >

Re: [Development] Allowed C++11 features [was: Re: Re: MSVC2012 in CI]

2016-03-21 Thread Poenitz Andre
Marc Mutz wrote: > I said then and I repeat it now that imho template aliases are not interesting > for library development. In particular, I don't think something like > > > > > template > > > > using QNodeCreatedChangePtr = QSharedPointer>; > > should be part of an API of a library. We have a

Re: [Development] Fixing QRect::width() / height()

2016-03-15 Thread Poenitz Andre
Marc Mutz wrote: > > Cluttering up the API doesn’t seem nice. Also not sure what you mean by > > new users needing such large rectangles… if they do, why don’t they use > > QRectF? > > For one, QRectF has different semantics w.r.t. wdith()/height(), for another, > sizeof(QRectF) == 2 * sizeof(Q

Re: [Development] Fixing QRect::width() / height()

2016-03-15 Thread Poenitz Andre
On Tuesday 15 March 2016 13:08:42 Bo Thorsen wrote: > > Den 15-03-2016 kl. 14:07 skrev Marc Mutz: > [...] > > There is another option that doesn't mean a change of signature: Bound > > the result. So if the real result is > INT_MAX, return INT_MAX. Same for > > INT_MIN. > > > > Yes, it's not the c

Re: [Development] RFC: more liberal 'auto' rules?

2015-12-09 Thread Poenitz Andre
Lars wrote: > I don’t think there is a full consensus. Indeed, there isn't. > Let me try to summarise where > we are, what I think we agree upon and then add my thoughts :) > > As a primary goal, auto should be used wherever it increases readability > of the code. I think we all agree here.

Re: [Development] RFC: Proposal for a semi-radical change in Qt APIs taking strings

2015-10-16 Thread Poenitz Andre
Marc Mutz wrote: > > I think too we should embrace the standard library more and don't replicate > > their features. > > So you think that QStringView is too experimental and _at the same time_ > replicating the standard. Sounds paradoxal to me. It's not paradoxical at all. It would be a new imp

Re: [Development] Compiler warnings

2014-10-15 Thread Poenitz Andre
Kurt Pattyn wrote: > > On 14 Oct 2014, at 10:21, Bo Thorsen wrote: > > > > Den 14-10-2014 08:59, Kurt Pattyn skrev: > >> how do these applications comply with MISRA? > > > > MISRA is impossible to comply with for a framework. For example, > > consider the required rule 0-1-11: "There shall be n

Re: [Development] QOptional

2014-08-21 Thread Poenitz Andre
Julien Blanc wrote: > There are two strong arguments in favor of optional : > - real life tends to show that the optional &ok parameter is often > missed in context it should not, leading to hard to find bugs. > - optional is much more friendly to static verification than &ok (dependancy between v

Re: [Development] QOptional

2014-08-21 Thread Poenitz Andre
Hausmann Simon wrote: > On Thursday 21. August 2014 13.13.15 Иван Комиссаров wrote: > > Of course, i can:) > > > > bool ok; > > const int value = string.toInt(&ok); > > if (ok) > > qDebug() << "value is" << value; > > > > // > > const auto value = string.toInt(); > > if (value) > > qD

Re: [Development] QOptional

2014-08-21 Thread Poenitz Andre
Milian Wolff [m...@milianw.de] > On Thursday 21 August 2014 13:13:15 Иван Комиссаров wrote: > > Of course, i can:) > > > > bool ok; > > const int value = string.toInt(&ok); > > if (ok) > > qDebug() << "value is" << value; > > > > // > > const auto value = string.toInt(); > > if (value) > >

Re: [Development] QOptional

2014-08-21 Thread Poenitz Andre
Иван Комиссаров [abba...@gmail.com] wrote: > The goal is to get rid of ugly "int QString::toInt(bool *ok = 0)" functions. Can you maybe spell out some code to demonstrate why this is ugly, and how the use of QOptional would improve that? Andre' ___ Deve

Re: [Development] QOptional

2014-08-21 Thread Poenitz Andre
Иван Комиссаров wrote: > I've started working on a QOptional class > (https://codereview.qt-project.org/#/c/92006/). > As Thiago mentioned in gerrit, there are some things to discuss. 3) Why do we need that class at all? Andre' ___ Development mailing

Re: [Development] Debugging Android App on Qt Creator 3.1.2 and real device (Python scripting)

2014-07-24 Thread Poenitz Andre
Fernando Pelliccioni wrote: > I just made a bug report, but I want to comment on this forum to get earlier > feedback. Sorry if it is not the place to do it. It's not the place to do it. Anyway... > I can not debug an Android application using Qt 5.3.1 and Qt Creator 3.1.2 > and a real device (

Re: [Development] Converting types in Qt

2014-07-16 Thread Poenitz Andre
Olivier Goffart wrote: > Jędrzej Nowacki wrote: > [...] > > > What is wrong with string -> int or bytearray -> int? > > > > At the very least, _implicit_ conversions should not lose data, > > i.e. a A a1; B b = a1; A a2 = b; round trip ideally should yield > > a1 == a2. > > > > If I am ready to g

Re: [Development] Converting types in Qt

2014-07-16 Thread Poenitz Andre
Jędrzej Nowacki wrote: > Eike wrote: > > [...] > >>> We use common sense on a case by case basic. > > > > Either there is no “common sense” common to me, or this rule has failed in > > the past already ;) > > bool -> string ? > > bytearray -> int/long/double ? > > keysequence -> int ? > > string ->

Re: [Development] Converting types in Qt

2014-07-16 Thread Poenitz Andre
Olivier Goffart: > Poenitz Andre wrote: > > I wholeheartedly disagree. Most of my QVariant uses are there because > > the Qt API requires me to use it, and I sometimes use it voluntarily for > > type-agnostic storage or transport of "things". But in those cases I nev

Re: [Development] Converting types in Qt

2014-07-16 Thread Poenitz Andre
Olivier Goffart wrote: > > > I'd say yes, for sensible conversion > > > You are right that it is a behaviour change, but i think it is worth > > > changing it. > > Why? > > > > On one hand you promise binary compatibility. On the other hand > > behaviour changes are proposed to be done on an "nice

Re: [Development] Converting types in Qt

2014-07-15 Thread Poenitz Andre
Olivier Goffart wrote: > Jędrzej Nowacki wrote: > > 1. Are we allowed to add new conversions? > > The question is tricky because adding a new conversion is a behavior > > change, as this code: > > if (variant.canConvert(QMetaType::int)) ... > > may work differently. If we add

Re: [Development] Gerrit dropping CI failure mails?

2014-07-08 Thread Poenitz Andre
Oswald Buddenhagen [oswald.buddenha...@digia.com] > > > [...] > > > Is it just me or how much does everybody else rely on it? > > > > It's not just you. I pretty much prefer mails in my inbox in case > > something happens (or fails) over polling a web interface too. > > > > I am also mildly surpri

Re: [Development] Gerrit dropping CI failure mails?

2014-07-08 Thread Poenitz Andre
Blasche Alexander wrote: > Oswald Buddenhagen wrote: > >i tried to reduce the flood somewhat by denying the bots (including CI) > >the right to mail reviewers, so only the owner now gets the emails. > >on the downside, you now need to pay more attention in case you adopt a > >change from someone el

Re: [Development] new "debugsupport" module and API

2014-05-13 Thread Poenitz Andre
Ulf Hermann: > Is anyone opposed to keeping this in a separate qtdebugsupport.git > repository, then? With what compatibility promises regarding code and protocol? Andre' ___ Development mailing list Development@qt-project.org http://lists.qt-project.o

Re: [Development] Modules in qtbase (was: Re: new "debugsupport" module and API)

2014-05-12 Thread Poenitz Andre
Kurt Pattyn [pattyn.k...@gmail.com]: > This makes sense. Maybe the WebSockets module can be > integrated into the network module in that case? Is there something Network really needs out of Websockets? Especially for security sensitive areas like network "nice to have" is not a good reason for co

Re: [Development] Categorized logging inside Qt

2014-04-11 Thread Poenitz Andre
shawn.rutle...@digia.com wrote: > On 10 Apr 2014, at 7:20 PM, Frederik Gladhorn wrote: > > > Hi all, > > > > I just started to port accessibility to the new and shiny categorized > > logging. > > http://blog.qt.digia.com/blog/2014/03/11/qt-weekly-1-categorized-logging/ > > > > I'd propose we dec

Re: [Development] qt_add/removeObject hooks

2014-04-08 Thread Poenitz Andre
volker.kra...@kdab.com: > > > So unless there's some compiler magic I missed I think this needs a > > > different approach to be reliable and cross-platform, such as callbacks. > > > Would this be acceptable? If so, would a minimal approach similar to > > > qt_register_signal_spy_callbacks() or r

Re: [Development] On the effectiveness of time based releases

2014-02-26 Thread Poenitz Andre
Koehne Kai [kai.koe...@digia.com] > > [...] > > > Before merging a feature the maintainers consider if yes or not the > > > feature is ready for integration. If bad decisions are made, I don't > > > think the "time- based" releases have anything to do with that. > > > > It has to some degree, beca

Re: [Development] [Interest] qmlx11 plugin

2014-02-06 Thread Poenitz Andre
Rutledge Shawn [shawn.rutle...@digia.com] > On 5 Feb 2014, at 11:16 AM, Damian Ivanov wrote: > > I made a c++ QML plugin for X11 functions like windowlist, active > > window, setting, getting icon of apps, names, id and setting netwm > > properties. Source code is here > > https://build.opensuse.o

Re: [Development] Build Hotspots in the Qt build process

2014-02-06 Thread Poenitz Andre
Shane McIntosh [mcint...@cs.queensu.ca] wrote: > Hi Qt developers! > > My name is Shane. I’m a PhD student at Queen’s University in Canada. > > I’ve been working on an approach for detecting build hotspots, i.e., > files that not only take a long time to rebuild, but also change often. > We thi

Re: [Development] Let's get rid of qDebug/qWarning/qCritical!

2014-01-10 Thread Poenitz Andre
Grr... OWA. > And here are the results: > > PASS : CatLogBench::qWarningPrintf1() > RESULT : CatLogBench::qWarningPrintf1(): > 0.0010 msecs per iteration (total: 67, iterations: 65536) > PASS : CatLogBench::qWarningPrintf2() > RESULT : CatLogBench::qWarningPrintf2(): > 0.0013 msecs p

Re: [Development] Let's get rid of qDebug/qWarning/qCritical!

2014-01-10 Thread Poenitz Andre
Koehne Kai wrote: > > -Original Message- > > From: development-bounces+kai.koehne=digia@qt-project.org > > [...] > > As a blueprint I've started a patch for a 'qt.core.io' category: > > > > https://codereview.qt-project.org/#change,74862,patchset=1 > > Andre raised concerns about the

Re: [Development] Let's get rid of qDebug/qWarning/qCritical!

2014-01-09 Thread Poenitz Andre
Koehne Kai wrote: > On quinta-feira, 9 de janeiro de 2014 07:28:07, Koehne Kai wrote: > > if qCWarning() would expand to an if (myCategory().isEnabled()) ... > > That's why it would have to expand to if (!myCategory().isEnabled()) {} else > > Well, we can't, since the << arguments are not part of

Re: [Development] Coding style proposal

2014-01-03 Thread Poenitz Andre
André Somers wrote: > Poenitz Andre schreef op 2-1-2014 23:49: > > Jiergir Ogoerg wrote: > >> Ironically, not even the IDE (QtCreator) sorts them out, in my example > >> parse...() is the 1st in the list, and locale() is the last one (16th). > > There's a

Re: [Development] Coding style proposal

2014-01-02 Thread Poenitz Andre
Jiergir Ogoerg wrote: > Ironically, not even the IDE (QtCreator) sorts them out, in my example > parse...() is the 1st in the list, and locale() is the last one (16th). There's a "Sort alphabetically" check box in the context menu of whatever-that-combobox-that-I-never-use-for-navigation-is-calle

Re: [Development] Qt 5.2 RC1 candidate packages available

2013-11-29 Thread Poenitz Andre
Simon Lees [simon.l...@codanradio.com] > The version of QtCreator shipped with the package crashes my x everytime > i attempt to launch it. It was the Android Linux x86_64 package running > on openSUSE 12.3 with Enlightenment as the window manager and the > proprietary NVIDIA Driver Could you try

Re: [Development] #error for unreleased MSVC versions

2013-10-24 Thread Poenitz Andre
Thiago Macieira [thiago.macie...@intel.com] > I'm going to add an #error to qcompilerdetection.h for any unreleased version > of MSVC. > > ==> In other words, adding new Q_COMPILER_xxx defines for C++11 for MSVC > breaks >binary compatibility <=== > > For that reason and because we don'

Re: [Development] Fwd: Change in qt/qtbase[dev]: Enable -Werror for all of qtbase

2013-09-04 Thread Poenitz Andre
That's wasting our time, as predicted. ../../corelib/tools/qdatetime.cpp: In function 'time_t qt_mktime(QDate*, QTime*, QDateTimePrivate::Spec*, QString*, bool*)': ../../corelib/tools/qdatetime.cpp:258:34: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

Re: [Development] Qt Creator Debug - GDB error

2013-03-01 Thread Poenitz Andre
Majid Khan wrote: > I am trying to debug Qt Creator (working on #7044) but when I debug > (its new linux mint 14 Nadia Cinammon) my gdb gives error > > Starting executable failed: > "/home/majid/projects/qtcreator-build/bin/qtcreator.sh": not in executable > format: File format not recognised

Re: [Development] Qt 5.1 feature set and freeze date

2013-02-14 Thread Poenitz Andre
Rodal Samuel wrote: >On 02/14/2013 10:39 AM, Poenitz Andre wrote: >> Samuel Rødal wrote: >>> What use is a QPlatformPixmapHandle having per-platform typedefs >>> (xcb_pixmap_t, HDC, etc) without #ifdefs to manipulate it using native >>> code in the first pl

Re: [Development] Qt 5.1 feature set and freeze date

2013-02-14 Thread Poenitz Andre
Samuel Rødal wrote: > What use is a QPlatformPixmapHandle having per-platform typedefs > (xcb_pixmap_t, HDC, etc) without #ifdefs to manipulate it using native > code in the first place? > > Can you give a platform-independent example use case? :) It helps reducing the amount of user code within

Re: [Development] abandoning stale changes on gerrit

2013-01-29 Thread Poenitz Andre
Oswald Buddenhagen wrote: > > No, and that's my point : I don't really care how many changes others > > have. I'll deregister myself from those I'm not interested in. > > > all changes i'm subscribed to are somehow interesting to me, obviously. > that means that i don't want to unsubscribe, as i'd

Re: [Development] QMake behaviour change

2012-11-28 Thread Poenitz Andre
> Nope, but I guess that a common interpretation of pro-files between > qmake and QtCreator are of interest to most. You need contemporary versions of Qt Creator for use with recent versions of Qt. Andre' ___ Development mailing list Development@qt-proj

Re: [Development] binary compatibility promise (was: Re: Frameworks on Mac?)

2012-11-23 Thread Poenitz Andre
Peter Hartmann wrote: > On 11/23/2012 12:12 AM, André Pönitz wrote: > > (...) > > The reality is that this guarantee often enough does not hold in > > practice. Vendors of "binary" Qt based application typically test their > > setup against one specific (often enough patched) version of Qt which >

Re: [Development] Pending decisions on co-installation

2012-10-31 Thread Poenitz Andre
Sune Vuorela: > This is something that will happen to be done. and for the sake of > documentation and support, please let it be consistant not only across > distributions, but also across platforms so that documentations don't > have to be > if mac | upstream-provided-linux-builds { > run qmake

Re: [Development] Summary of renaming changes

2012-10-19 Thread Poenitz Andre
Sune Vuorela [nos...@vuorela.dk] > I have, as a distributor, frequently gotten 'hate' in #qt for providing > switchable qmakes. > And from a 'user support' PoV, having to write "depending on what you > have set as your default you can maybe write qmake, maybe you need to > oither switch the defau

Re: [Development] Summary of renaming changes

2012-10-19 Thread Poenitz Andre
Sorvig Morten wrote: > Knoll Lars wrote: > > Hi, > > > > looks like there's quite some discussion about Thiago's proposal. > > Let's see if we can get at least agreement on most of the changes > > and then focus on the parts that are controversial. > > To me this looks like a case where there c

Re: [Development] Summary of renaming changes

2012-10-19 Thread Poenitz Andre
Thiago Macieira: > On sexta-feira, 19 de outubro de 2012 06.07.34, Kalinowski Maurice wrote: > > On Windows there is no global qmake or such to call and distinguish between > > versions. Each Qt version will have to live in its own package, either made > > by the binary distribution or self-compile

Re: [Development] Branching for Qt 5 repositories

2012-09-28 Thread Poenitz Andre
From: development-bounces+andre.poenitz=digia@qt-project.org [development-bounces+andre.poenitz=digia@qt-project.org] on behalf of Loaden [loa...@gmail.com] > I prefer: > dev -> next > stable -> master > release -> release -1, and +1 for the originally proposed version. For someone wanti