Re: [Development] How to change the status of a review from WIP back to active?

2020-08-24 Thread Marcel Krems
Unfortunately I don't have that option. I only have Cherry-pick, Download patch, Follow-up, Ignore and Mark unreviewed Marcel On 24.08.2020 17:07, Giuseppe D'Angelo via Development wrote: On 24/08/2020 17:02, Marcel Krems wrote: I have two reviews which have been cherry-pick

[Development] How to change the status of a review from WIP back to active?

2020-08-24 Thread Marcel Krems
Hi, I have two reviews which have been cherry-picked to 5.15 with a merge-conflict. I have resolved the conflicts and pushed new changesets, but the status is still "Work in Progress". How do I change the status back to "Active" or if I am not allowed to what does one usually do to get this

Re: [Development] qsizetype and classes working with QStrings or QList

2020-08-24 Thread Marcel Krems
https://bugreports.qt.io/browse/QTBUG-86224 On 24.08.2020 09:26, Giuseppe D'Angelo via Development wrote: On 23/08/2020 16:06, Marcel Krems wrote: If they keep using int there could be a lot of warnings like this one: warning: implicit conversion loses integer precision: 'qsize

Re: [Development] Qt 6: Assigning QPalette to ApplicationWindow.palette no longer supported?

2020-08-24 Thread Marcel Krems
-Thilo-Str. 10 D-12489 Berlin fabian.kosm...@qt.io +49 1638686070 http://qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B -- ------

[Development] qsizetype and classes working with QStrings or QList

2020-08-23 Thread Marcel Krems
Hi, since QString, QList, etc. are using qsizetype for indexing- and size-operations. What is the plan with classes working with aforementioned container classes which are still using int in their interfaces? If they keep using int there could be a lot of warnings like this one: warning: impli

[Development] Qt 6: Assigning QPalette to ApplicationWindow.palette no longer supported?

2020-08-21 Thread Marcel Krems
Hi, I recently implemented a theming system for my Qt Quick application. With Qt 6 I'm getting an error: "Unable to assign QPalette to QQuickPalette*" This was changed in the following commits:  - https://codereview.qt-project.org/c/qt/qtquickcontrols2/+/270097  - https://codereview.qt-project