Re: [Development] where to push refs for qt5?

2013-11-11 Thread Graham Coleman
here's no master branch) > depending on where the change is supposed to go. > > -- > Nicolás > > 2013/11/11 Graham Coleman : > > Greetings, > > > > I've prepared my changes to gerrit for review on qt5 but having trouble > > pushing them. Is th

[Development] where to push refs for qt5?

2013-11-11 Thread Graham Coleman
Greetings, I've prepared my changes to gerrit for review on qt5 but having trouble pushing them. Is the target branch or something else wrong? It should go to refs/for/master or refs/for/HEAD, right? The changes are in qtbase/src/gui/text. my errors below and best regards, Graham Graham@KATIUSC

Re: [Development] gerrit: relevant reviewers for signals bugfix in QTextCursor

2013-10-21 Thread Graham Coleman
Thanks for the quick feedback, this review is closed. I will test in qt5 and perhaps submit a followup patch. Graham On Mon, Oct 21, 2013 at 3:59 PM, Graham Coleman wrote: > Greetings, > > I'm awaiting reviews for my first submission, a small bugfix I proposed on > JIRA, but

[Development] gerrit: relevant reviewers for signals bugfix in QTextCursor

2013-10-21 Thread Graham Coleman
Greetings, I'm awaiting reviews for my first submission, a small bugfix I proposed on JIRA, but do not know if I have added appropriate reviewers (I added a few from 'git history' and the Maintainer chart as suggested). The Contribution guidelines document suggests to also ask here. The bug, patc