[Development] QUuid changes

2012-03-12 Thread Denis Dzyubenko
Hi, There is a change that I was working that that slipped out of my hands and was left unnoticed on gerrit (thanks Robin for reminding me!) Is it too late to integrate a patch that removes implicit conversion between QUuid and Windows GUID struct? http://codereview.qt-project.org/11968 I would

Re: [Development] qtdeclarative doesn't compile?

2012-03-11 Thread Denis Dzyubenko
Hi Sergio, On Sun, Mar 11, 2012 at 3:12 PM, Sergio Ahumada Navea wrote: > qtbase/containers was merged into qtbase/api_change > > qtdeclarative/master depends on > qtbase/3d19422ef16a230bb11dbbfe4a8cc9667f39bf15 > > qtjsondb/master depends on qtbase/api_changes and qtdeclarative/master > > I woul

[Development] qtdeclarative doesn't compile?

2012-03-11 Thread Denis Dzyubenko
Hi guys, Is there something wrong with the CI or is qtdeclarative broken at the moment? I got an error in qtdeclarative when staging a change for qtjsondb module: http://codereview.qt-project.org/19092 http://testresults.qt-project.org/ci/QtJsonDb_master_Integration/build_00599/linux-g%2B%2B_de

Re: [Development] API review: Updating QWheelEvent

2012-01-17 Thread Denis Dzyubenko
Hi Morten, On Tue, Jan 17, 2012 at 2:42 PM, wrote: > QWheelEvent has fallen a bit behind and needs an update. It was once used for > mouse wheel events only, but is today also used for scroll events generated > from trackpad swipe gestures. > > There are two main issues: > > * QWheelEvents are

Re: [Development] Source incompatible Qt 5 change: Removing the QTouchEvent::TouchPoint::Primary flag

2012-01-12 Thread Denis Dzyubenko
Hi Sam, On Thu, Jan 12, 2012 at 2:26 PM, Samuel Rødal wrote: > Hello, > > I'd like to remove the QTouchEvent::TouchPoint::Primary flag, as per > change request http://codereview.qt-project.org/#change,12928 > > The current purpose of the flag is simply to note that a touch point is > duplicated a

Re: [Development] qt5 modules in namespaces

2012-01-04 Thread Denis Dzyubenko
On Wed, Jan 4, 2012 at 2:47 PM, Denis Dzyubenko wrote: > On Tue, Jan 3, 2012 at 7:16 PM,   wrote: >> On 03/01/2012 12:01, ext Thiago Macieira wrote: >>> On Tuesday, 3 de January de 2012 18.19.47, Denis Dzyubenko wrote: >>>> That's the thing - it doesn'

Re: [Development] syncqt generated forward include headers

2012-01-04 Thread Denis Dzyubenko
Hi Thiago, 2012/1/4 Thiago Macieira : >> I made it configurable via sync.profile - >> http://codereview.qt-project.org/12128 > > Have you checked what other stuff it creates on other modules? > > The Q-protection was intentional, since there are other helper structs and > classes in Qt code. I'v

[Development] syncqt generated forward include headers

2012-01-04 Thread Denis Dzyubenko
Hi, I've made a patch for syncqt to make it generate forward include header (e.g. "include/QtCore/QObject" and "include/QtCore/qobject.h") even if the class name doesn't have a "Q" prefix - in qtjsondb module all classes have "JsonDb" prefix instead and that confused syncqt. I made it configurabl

Re: [Development] qt5 modules in namespaces

2012-01-04 Thread Denis Dzyubenko
Hi, On Tue, Jan 3, 2012 at 7:16 PM, wrote: > On 03/01/2012 12:01, ext Thiago Macieira wrote: >> On Tuesday, 3 de January de 2012 18.19.47, Denis Dzyubenko wrote: >>> That's the thing - it doesn't work in some cases - if you do >>> in-source-tree build of th

Re: [Development] qt5 modules in namespaces

2012-01-03 Thread Denis Dzyubenko
Hi Thiago, 2012/1/3 Thiago Macieira : > On Friday, 30 de December de 2011 14.55.55, Denis Dzyubenko wrote: >> In qt5 modules we have exactly the same problem as in namespaced-Qt >> itself. Hence my suggestion to solve it in the same way - I would like >> to b

Re: [Development] Nominating Robin Burchell for approver

2012-01-03 Thread Denis Dzyubenko
2011/12/29 Thiago Macieira : > I'd like to nominate Robin Burchell (a.k.a. w00t on IRC) for approver in Qt. > He's been around Qt for some time now and has been contributing both in his > work time and in his personal time. He was also my main external "sparring > partner" when developing the Open

[Development] qt5 modules in namespaces

2012-01-03 Thread Denis Dzyubenko
Hi guys, With a qt5 module that we are developing, qtjsondb, we stumbled upon an issue with moc and our classes that are inside a namespace. Let me illustrate it with a code: jsondb-global.h: #if defined(QT_NAMESPACE) # define QT_ADDON_JSONDB_BEGIN_NAMESPACE namespace QT_NAMESPACE { namespace Q

Re: [Development] [Qt5-feedback] A micro API review: for V3(md5) and V5(sha1) in QUuid

2011-12-30 Thread Denis Dzyubenko
Hi João On Fri, Dec 23, 2011 at 6:31 PM, wrote: > [ Re-trying after the previous massive quoting and line-wrap fail :-/ ] > > Denis Dzyubenko wrote: >> 2011/12/9 João Abecasis : >> >>    inline QUuid QUuid::createFromName(const QUuid &n

Re: [Development] [Qt5-feedback] A micro API review: for V3(md5) and V5(sha1) in QUuid

2011-12-28 Thread Denis Dzyubenko
Hi, 2011/12/9 João Abecasis : >>    inline QUuid QUuid::createFromName(const QUuid &ns, const QString &name) >>    { >>        return createFromName(ns, name.toUtf8()); >>    } > > would only be updated to call the right implementations, as appropriate. I like the current status of the patch very