[Development] Why are my merged patches not in dev after checkout?

nts to check, I'm talking about these two patches: Change-Id: Iaa8ec0246aaba004d98c9e8c66609795101519a9 Change-Id: I2d269ef0f842e73af64d48bfef531d5fa3078088 What am I doing wrong? Regards, Daniel Savi ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

[Development] Problem with merging a patch

Dear developers My journey into Qt development came again to a sudden halt. I've commited this patch (Iaa8ec0246aaba004d98c9e8c66609795101519a9) and Lars Knoll gave it green light after comments from him, André Hartman and Edward Welbourne. Now, when I hit the "Merge patch Set to Staging"-butto

Re: [Development] how to include further changes while previous commit is still under review?

t;git checkout master", "git branch fix2", git checkout fix2", add fix 2 and commit the second patch. I'm writing all commands by heart, may have some mistakes there. Would that work out, or am I running into troubles somewhere? Am 20. Januar 2018 23:28:13 MEZ schrieb K

Re: [Development] how to include further changes while previous commit is still under review?

On 19.01.2018 18:40, Konstantin Tokarev wrote: 19.01.2018, 01:58, "Samuel Gaist" :  On 18 Jan 2018, at 22:42, Daniel Savi wrote:  Hello qt devs  I'm back with another newbie question. I have committed a patch that is still under review on gerrit.  Meanwhile, I

[Development] how to include further changes while previous commit is still under review?

Hello qt devs I'm back with another newbie question. I have committed a patch that is still under review on gerrit. Meanwhile, I've got a local and unrelated patch on the same file, that I would like to commit, too. Now, how would I include this patch into my local git repo and how would I

[Development] Needing another advise using git

Thank you all for the helpful comments on my previous message. I think that I have now managed to amend my changes into one commit and may understand how to react on comments. While amending my commits I must somehow have pushed another commit again that is not from me at all. It is this one:

[Development] Seeking advise using git and code review

Hello everybody I've just pushed my first commit to QtGui, trying to follow the contribution guidelines posted here http://wiki.qt.io/Qt_Contribution_Guidelines. Now I have some questions regarding the process. It seems that I have done it at least partly wrong ;-) The codereview to my chan