Re: [Development] Removing MSVC2008 from the CI build farm?

2014-02-05 Thread Chris Colbert
There are still some very large enterprise users running on vc2008 build systems. Would this mean that all hope for building new releases on vc2008 would be lost, or that it just may take more effort than normal? As it stands, I had to apply some manual fixes to get 5.1 to build with vc2008, but it

[Development] request for reviewers: patch for widgets regression

2014-01-18 Thread Chris Colbert
Would someone familiar with widgets please kindly review this patch or suggest an alternative fix. I'm happy to update the patch if a better solution exists. This regression is preventing my company from moving from Qt4 to Qt5. https://codereview.qt-project.org/#change,72939 __

Re: [Development] What's the magic incantation for developing effectively from the Qt git repo?

2013-12-09 Thread Chris Colbert
Behalf > Of Chris Colbert > Sent: 6. desember 2013 02:46 > To: Olivier Goffart > Cc: development@qt-project.org > Subject: Re: [Development] What's the magic incantation for developing > effectively from the Qt git repo? > > > I was able to get things to build a

Re: [Development] Order of macro expansion in compiler error messages

2013-12-07 Thread Chris Colbert
de dezembro de 2013 15:03:26, Chris Colbert wrote: > > Is there a line missing from Option A, just after the line for ? > > This specific compiler did not output anything for this case. > > That case was a misuse of a macro. Here's another example, where the > problem >

Re: [Development] Order of macro expansion in compiler error messages

2013-12-07 Thread Chris Colbert
Is there a line missing from Option A, just after the line for ? On Sat, Dec 7, 2013 at 2:53 PM, Thiago Macieira wrote: > Hi guys > > Just a quick poll: which order do you think is more intuitive? > > Option A: > qobjectdefs.h:69:20: error: expected unqualified-id before ‘protected’ > # defin

Re: [Development] Build failure on stable branch

2013-12-07 Thread Chris Colbert
I had the same issue recently. It was because my qtdeclarative module (and maybe others) was not built on 'stable'. I corrected by ensuring all submodules were checked out to 'stable' where possible, or 'master' otherwise. On Sat, Dec 7, 2013 at 11:15 AM, Nurmi J-P wrote: > On 07 Dec 2013, at 1

Re: [Development] What's the magic incantation for developing effectively from the Qt git repo?

2013-12-05 Thread Chris Colbert
same thing the build bot is building against. On Thu, Dec 5, 2013 at 9:45 PM, Nicolás Alvarez wrote: > 2013/12/5 Chris Colbert : > > In the broader sense, if the Gerrit only merges to 'stable' once the > build > > succeeds and (presumably) tests pass, what's th

Re: [Development] What's the magic incantation for developing effectively from the Qt git repo?

2013-12-05 Thread Chris Colbert
#x27; once the build succeeds and (presumably) tests pass, what's the reasoning behind not having qt5.git default the submodules to the 'stable' branch? On Mon, Dec 2, 2013 at 7:06 AM, Olivier Goffart wrote: > On Sunday 01 December 2013 13:53:50 Chris Colbert wrote: > > I

[Development] What's the magic incantation for developing effectively from the Qt git repo?

2013-12-01 Thread Chris Colbert
I recently had a change-set merged which fixed the WA_StaticContents flag on Windows. However, when I update my git repo according to the advice on the website: 1. git pull 2. git submodule sync 3. git submodule update --recursive I get a checkout which does not include my recent chang