Re: [Development] kdelibs coding style

2013-04-30 Thread Axel Waggershauser
On Tue, Apr 30, 2013 at 5:13 PM, Thiago Macieira wrote: > On terça-feira, 30 de abril de 2013 08.54.31, Samuel Rødal wrote: >> A good reason for using the >> >> Foo() >> : x(0) >> , y(0) > > This is extremely ugly and should be discouraged. If it is about the sum of all opinions, I agre

Re: [Development] Updating third-parties

2013-04-05 Thread Axel Waggershauser
On Fri, Apr 5, 2013 at 12:20 PM, Axel Waggershauser wrote: >> Based on that and without an answer from Oswald which revision is >> currently in preparation within the winrt branch, I'd suggest to go >> for the latest Chrome related branch, which would be chrome_m27: >

Re: [Development] Updating third-parties

2013-04-05 Thread Axel Waggershauser
On Fri, Apr 5, 2013 at 12:18 PM, Axel Waggershauser wrote: > On Thu, Mar 28, 2013 at 9:18 PM, Axel Waggershauser wrote: >> (I went ahead and posted a question on the ANGLE ML asking which >> 'stable' revision they would suggest to ship with Qt 5.1.) > > I got the

Re: [Development] Updating third-parties

2013-04-05 Thread Axel Waggershauser
On Thu, Mar 28, 2013 at 9:18 PM, Axel Waggershauser wrote: > (I went ahead and posted a question on the ANGLE ML asking which > 'stable' revision they would suggest to ship with Qt 5.1.) I got the following reply on the ANGLE ML: -- Trunk is generally pretty stable unless a

Re: [Development] Switch of MinGW toolchain for Qt 5.1

2013-04-04 Thread Axel Waggershauser
In light of the recent mentioning of gcc's switch to DWARF4 from DWARF2 with version 4.8, which should help get down the size of debug builds, I am very much for giving the 4.8.0 option a try. Cheers, Axel ___ Development mailing list Development@qt-pr

Re: [Development] Updating third-parties

2013-03-28 Thread Axel Waggershauser
On Thu, Mar 28, 2013 at 9:09 PM, Oswald Buddenhagen wrote: > On Thu, Mar 28, 2013 at 08:44:13PM +0100, Axel Waggershauser wrote: >> P.S. this is not necessarily an offer to do the upgrade myself (I >> don't even have enough space to build qt on my windows partition right &g

Re: [Development] Updating third-parties

2013-03-28 Thread Axel Waggershauser
On Wed, Mar 20, 2013 at 5:50 PM, Thiago Macieira wrote: > qtbase: > ANGLE (*) If I followed this thread sufficiently, it seems as if no one has yet made a statement about the update of ANGLE. I just remembered that a couple of weeks ago I came across this warning message when running some

[Development] QtSDK size difference between mingw and msvc version

2013-03-28 Thread Axel Waggershauser
Hi, sorry if this is a boring/stupid/old question (I have not found any related discussion): Why is the installed mingw version of the (5.0.1) SDK more than 3 times the size (>3.5GB) of the msvc version? It obviously boils down to the question why especially the debug dlls are so much bigger (lik

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Axel Waggershauser
On Fri, Mar 15, 2013 at 8:11 AM, Thiago Macieira wrote: >> 2 c) if vs. while lines seem obviously inconsistent >> >> if (test == true >> && 1 == 0) // 8 spaces == 4 relative to the '(' > > This is a special case because of a { > > If you write: > if (test == true > && 1

Re: [Development] White space / coding style patches welcome?

2013-03-14 Thread Axel Waggershauser
With the trailing whitespace issue pretty much fixed, the next step is eliminating leading tabs. A few questions about that: 1) If in doubt, is it generally fair to assume that whatever QtCreator's CTRL+i in the default built-in Qt coding style does, is the way to go? 2) Especially continuation l

Re: [Development] White space / coding style patches welcome?

2013-03-13 Thread Axel Waggershauser
On Wed, Mar 13, 2013 at 10:30 AM, Oswald Buddenhagen wrote: > On Wed, Mar 13, 2013 at 01:38:31AM +0100, Axel Waggershauser wrote: >> I'd say in terms of Lars's worries about having automatic checks in >> place before attacking whitespace issues, there should not be any &g

Re: [Development] White space / coding style patches welcome?

2013-03-12 Thread Axel Waggershauser
On Tue, Mar 12, 2013 at 5:32 PM, Oswald Buddenhagen wrote: > it went to the trash because the idea was not liked back then. the winds > appear to have changed meanwhile. That is a pitty. Given, that I already spent a bunch of hours looking into this, I hope you are right (about the winds of chang

Re: [Development] White space / coding style patches welcome?

2013-03-12 Thread Axel Waggershauser
On Tue, Mar 12, 2013 at 2:11 PM, Oswald Buddenhagen wrote: > On Tue, Mar 12, 2013 at 01:34:54PM +0100, Axel Waggershauser wrote: >> I thought splitting by type first and potentially by directory second >> if it is too big still, would be best because it reduces the burden on >&g

Re: [Development] White space / coding style patches welcome?

2013-03-12 Thread Axel Waggershauser
>> 3. How to best split up patches from that category? e.g. fixing all >> "if(...){" -> "if (...) {" occurrences in qtbase would be a rather >> large patch (I have it half done) >> a) split that up based on "manageable" subdirectories? >> > yes, and that only for easy recovery from merge conflict

[Development] White space / coding style patches welcome?

2013-03-11 Thread Axel Waggershauser
Hi, sitting in front of my keyboard after midnight and being in the mood of killing some time with brain-dead typing, I came up with this: https://codereview.qt-project.org/#change,50652 patch. During my recent first adventures as a Qt 'contributor' I learned that fixing white space problems 'on t