Re: [Development] (Bikeshed, pedantic) East constexpr vs West constexpr

2024-09-20 Thread Ahmad Samir
7;static constexpr inline' is what I would type by default (before doubting myself and grep'ing in the codebase to see what's used the most in case I've forgotten). Unlike other orders like east const vs west const, there is no difference in my ability or speed to parse either forms. Good point. [...] Regards, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Should QObject::event() be protected or public?

2024-03-15 Thread Ahmad Samir
On 15/3/24 19:57, Jean-Michaël Celerier wrote: There's nothing more frustrating that instantiating a C++ type on the stack like MyType foo; and having to call a function with: static_cast(foo).someVirtualMethod(); Or: foo.Base::someVirtualMethod(); [..] -- Ahmad

Re: [Development] Raising the minimum to C++20

2024-02-09 Thread Ahmad Samir
ago, the CI still uses C++17, I have seen very few issues. My 2p's. Regards, Ahmad Samir On 9 Feb 2024, at 10:41, Vladimir Minenko via Development wrote: Just as a reminder, the "C++20 is mandatory for users of Qt (Phase III)” (https://bugreports.qt.io/browse/QTBUG-109362) says &q

Re: [Development] Removal/deprecation of OpenSSL 1 in Qt

2023-12-05 Thread Ahmad Samir
and not using any automatic detection whatsoever: users of Qt should never ever be enabling it "by accident". Just stating the obvious: I agree, must be opt-in with a clear disclaimer "You're on your own, if it breaks, you get to keep the pieces". [...] My 2p&#

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Ahmad Samir
;ll get less formatting issues in reviews (especially from new contributors) - or we'll still get formatting issues, just different ones than what clang-format currently does So 6-12 months, and we'll have a definite answer. :) Regards, Ahmad Samir OpenPGP_signature Description: O

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Ahmad Samir
On 13/9/23 09:13, Paul Wicking wrote: On 12 Sep 2023, at 22:33, Ahmad Samir wrote: _clang-format isn't picked up by clang-format by default, you'd have to rename it to .clang-format. clang-format reads either of them [0]. It's unnecessary to rename the configuration fil

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-12 Thread Ahmad Samir
On 13/9/23 01:46, Marc Mutz via Development wrote: [I didn't get André's Email...] On 12.09.23 23:40, Ahmad Samir wrote: On 13/9/23 00:11, apoenitz wrote: On Tue, Sep 12, 2023 at 11:33:17PM +0300, Ahmad Samir wrote: A config file that is 80-90% correct is better than nothing.

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-12 Thread Ahmad Samir
On 13/9/23 00:11, apoenitz wrote: On Tue, Sep 12, 2023 at 11:33:17PM +0300, Ahmad Samir wrote: A config file that is 80-90% correct is better than nothing. I disagree. The result of such a thing is that people submit patches matching the config 100%, deviating from the wanted style by 10-20

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-12 Thread Ahmad Samir
ding style, but I don't have to do it all manually. Drive-by suggestion: each module should also have a .git-blame-ignore-revs file (name should be unified in all Qt repos), to put commit hashes that git-blame should ignore. (See 'git blame --ignore-revs-file'). Regards, Ahmad

Re: [Development] CI failing due to ASan tst_selftest

2023-09-05 Thread Ahmad Samir
`, which showed it's because in `checkErrorOutput(const QString &test, const QByteArray &errorOutput)` in tst_selftests.cpp, the code should return early for "silent" test, because the latter calls qFatal, that doesn't seem to happen on Linux any more. Regards, Ahma

Re: [Development] On the use of the inline keyword

2023-08-28 Thread Ahmad Samir
On 26/8/23 11:51, Volker Hilsheimer wrote: On 25 Aug 2023, at 14:20, Ahmad Samir wrote: On 25/8/23 14:11, Cristian Adam via Development wrote: The other way of fixing this is by using ... macros. The article at c++ - Importing inline functions in MinGW - Stack Overflow<ht

Re: [Development] On the use of the inline keyword

2023-08-25 Thread Ahmad Samir
qt-project.org/c/qt/qtbase/+/498739 Regards, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Q_FOREACH, again

2023-08-14 Thread Ahmad Samir
on. HEADER_MODULE isn't used that many times in Qt code, and typically where it's used there is no SOURCES arg passed to qt_internal_add_module, however it's a corner case to look out for when adding DEFINES to qt_internal_add_module. Regards, Ahmad Samir OpenPGP_signature Descrip

Re: [Development] Failed to build Qt6 Documentation from qt/qtbase sources?

2023-08-03 Thread Ahmad Samir
g-build-qt6-docs.txt* --- Haowei Hsu From the build log: D:/Repo/GitHub/testing/qtbase/src/corelib/doc/qtcore.qdocconf:1: (qdoc) error: Cannot open file 'C:/Qt/Qt-6.5.3/./doc/global/qt-module-defaults.qdocconf': ??? Cannot open file 'C:/Qt/Qt-6.5.3/./doc/global/qt-mo

Re: [Development] qsizetype

2023-03-09 Thread Ahmad Samir
On 9/3/23 10:14, Marc Mutz via Development wrote: On 08.03.23 15:30, Ahmad Samir wrote: So, named casts (static_cast) are better in such cases, as searching for them in source code is much easier than searching for: - int(foo) - (int)foo - (int)(foo) In which situation would you want to

Re: [Development] qsizetype

2023-03-08 Thread Ahmad Samir
qlonglong, qulonglong... etc). Thanks, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] [Announce] Security advisory: Freetype in Qt

2022-08-19 Thread Ahmad Samir
falls on you (any which way you want to look at it, license-wise, morally, legally...). My 2p's. Regards, Ahmad Samir OpenPGP_signature Description: OpenPGP digital signature ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] QKeySequenceEdit questions

2022-05-17 Thread Ahmad Samir
tcutsDialog and co.). Best regards Ahmad Samir ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Qt 6 not seeing the same DPI as Qt 5

2021-11-30 Thread Ahmad Samir
l DPI: 96,96 Subpixel_None High DPI scaling factor: 2 DevicePixelRatio: 2 Do the - and + lines represent the same monitor? one says refresh rate is ~60Hz, the other says ~30Hz. [...] -- Ahmad Samir ___ Development mailing list Development@qt-projec

Re: [Development] Raising minimum CMake version to 3.16 for Qt6

2021-05-05 Thread Ahmad Samir
Have a good day. -- Ahmad Samir ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development