Re: [Development] Recommended way to take in strings

2023-06-10 Thread A . Pönitz
On Wed, May 31, 2023 at 07:17:21AM +, Marc Mutz via Development wrote: > On 31.05.23 09:07, Sami Varanka via Development wrote: > > What is the recommended way for functions to take strings? Our QtGraphs > > API takes in const QString & but is recommended way nowadays take in > > QAnyStringVi

Re: [Development] Recommended way to take in strings

2023-05-31 Thread A . Pönitz
On Wed, May 31, 2023 at 07:17:21AM +, Marc Mutz via Development wrote: > On 31.05.23 09:07, Sami Varanka via Development wrote: > > What is the recommended way for functions to take strings? Our QtGraphs > > API takes in const QString & but is recommended way nowadays take in > > QAnyStringVi

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread A . Pönitz
On Tue, May 09, 2023 at 06:51:37AM +, Marc Mutz via Development wrote: > Hi, > > I'd like to propose the following clarifications: > > - no space between "operator" and it's symbol: > [...] > - exactly one space each between if and constexpr/constinit and > [...] > - space after template and

Re: [Development] API style guide: scoped enum or not?

2023-05-03 Thread A . Pönitz
[re-ordered] On Wed, May 03, 2023 at 05:32:46PM +, Axel Spoerl via Development wrote: > > On 3 May 2023, at 18:42, Giuseppe D'Angelo via Development > > wrote: > > > > 02/05/23 10:58, Volker Hilsheimer via Development ha > > scritto: > >> During the header review, but also in API discussions

Re: [Development] Changes to QObject::connect and other functor-taking API implementations

2023-05-03 Thread A . Pönitz
On Wed, May 03, 2023 at 03:21:40PM +0200, Giuseppe D'Angelo via Development wrote: > Il 02/05/23 12:34, Volker Hilsheimer via Development ha scritto: > > > > What started as an attempt to provide a few building blocks for making it > > easier to build asynchronous APIs taking any kind of callabl

Re: [Development] qsizetype

2023-03-11 Thread A . Pönitz
On Thu, Mar 09, 2023 at 02:08:48PM +0100, Hasselmann Mathias via Development wrote: > My take on qsizetype: Just revert this failed experiment. > > It's a huge annoyance for little to no benefit. Correct. > I'll never understand how this very broken and incomplete experiment could > make it int

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread A . Pönitz
On Thu, Jan 19, 2023 at 01:44:16PM +, Friedemann Kleint via Development wrote: > Hi, > > we also need to agree on whether the Qt library rules apply to the > full extent; for example: > > - Do we use the modern string literals (u"bla"_s, previously, example > code just constructed QString fro

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread A . Pönitz
On Wed, Jan 18, 2023 at 04:10:20PM +, Kai Köhne via Development wrote: > > -Original Message- > >[...] > > > > MANDATORY > > > > > > Do not use QT_BEGIN_NAMESPACE ... QT_END_NAMESPACE for example > > types. This namespace is exclusively for types in the Qt libraries. > > > > This

Re: [Development] Updates to QUIP-6: Acceptable Source-Incompatible changes

2022-12-17 Thread A . Pönitz
On Fri, Dec 16, 2022 at 09:49:51PM +, Marc Mutz via Development wrote: > Hi, > > The recent episode with qVersion() moving from qglobal.h to > qlibraryinfo.h, a header not included in qglobal.h, has shown that > QUIP-6 SiC A are too broad a category. As per QUIP-6, I'm proposing to > add a

Re: [Development] How qAsConst and qExchange lead to qNN

2022-12-01 Thread A . Pönitz
On Wed, Nov 16, 2022 at 09:50:35AM -0800, Thiago Macieira wrote: > On Tuesday, 15 November 2022 23:50:38 PST Marc Mutz via Development wrote: > > > in a thread-safe manner (such that if something in > > > the same thread or another thread-safely modifies that map, the original > > > user isn't affe

Re: [Development] How qAsConst and qExchange lead to qNN

2022-12-01 Thread A . Pönitz
On Tue, Nov 15, 2022 at 08:07:50AM +, Marc Mutz via Development wrote: > On 14.11.22 23:04, A. Pönitz wrote: > >> Marc’s proposal of a Non-Owning Interface is already > >> become manifest in QRegion::begin/end > >> > >> https://doc.qt.io/qt-6/qregion.ht

[Development] Nominating Marcus Tillmanns as Approver

2022-11-22 Thread A . Pönitz
I'd like to nominate Marcus Tillmanns as an approver for the Qt project. Marcus has been working on Qt Creator since April, mostly on Docker support and remote file access/command execution, but also on LLDB support and various other changes across the code base. He made already several excell

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-14 Thread A . Pönitz
On Mon, Nov 14, 2022 at 04:54:20PM +, Volker Hilsheimer wrote: > > > On 12 Nov 2022, at 14:41, A. Pönitz wrote: > > > > On Fri, Nov 11, 2022 at 09:35:27AM +0100, Ulf Hermann via > > Development wrote: > >> There is an undeniable benefit of _offering_ QS

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-13 Thread A . Pönitz
On Fri, Nov 11, 2022 at 09:35:27AM +0100, Ulf Hermann via Development wrote: > There is an undeniable benefit of _offering_ QSpan, QStringView, and > generator APIs in a few relevant cases: This is true, but my problem with this is that already _offering_ additional solutions does not come for fre

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-10 Thread A . Pönitz
On Thu, Nov 10, 2022 at 03:55:39PM +, Marc Mutz via Development wrote: > Hi Ivan, > > On 10.11.22 11:03, Ivan Solovev via Development wrote: > > I wonder how your NOI-everywhere suggestion will work with the > > signal/slot connections? Specially for the case when > > Qt::QueuedConnection is

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-10 Thread A . Pönitz
[ TL;DR : Qt API should use QString foo() const; void setFoo(const QString &); Neither QStringView nor C++20 changes this. ] On Wed, Nov 09, 2022 at 10:52:15AM +, Marc Mutz via Development wrote: > Hi Ulf, > > On 09.11.22 08:18, Ulf Hermann via Development wrote: > >> I don't wa

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-08 Thread A . Pönitz
On Mon, Nov 07, 2022 at 08:15:58PM +, Marc Mutz via Development wrote: > Hi all, > > SCNR taking the proffered bait: > > On 07.11.22 18:51, Edward Welbourne wrote: > > For Qt to remain relevant in the rapidly-evolving C++ landscape, it > > needs to change; but one of its strong selling-points

Re: [Development] Using '#pragma once' instead of include guards?

2022-11-04 Thread A . Pönitz
On Wed, Nov 02, 2022 at 02:25:25PM +, Marc Mutz via Development wrote: > Hi Volker, > > On 14.10.22 17:12, Volker Hilsheimer via Development wrote: > > Anyway, I’ve added the respective text to the coding convention wiki > > page. > > https://wiki.qt.io/Coding_Conventions > > Having read the

Re: [Development] qsizetype

2022-09-21 Thread A . Pönitz
On Tue, Sep 13, 2022 at 01:12:57PM +, Volker Hilsheimer wrote: > > On Wed, Sep 07, 2022 at 06:38:30PM +0200, A. Pönitz wrote: > >> [...] What would have been wrong with starting with > >> > >> #ifdef I_AM_WORKING_ON_IT using qsizetyp_ = qsizetype; #else u

Re: [Development] qsizetype

2022-09-12 Thread A . Pönitz
On Wed, Sep 07, 2022 at 06:38:30PM +0200, A. Pönitz wrote: > On Mon, Sep 05, 2022 at 05:15:45PM +, Marc Mutz wrote: > > [...] > >We have the tools (QT_REMOVED_SINCE + Ivan's work on > >-disable-deprecated-until) to have a user-configurable, rolling BC windo

Re: [Development] qsizetype

2022-09-07 Thread A . Pönitz
On Mon, Sep 05, 2022 at 05:15:45PM +, Marc Mutz wrote: > [...] >We have the tools (QT_REMOVED_SINCE + Ivan's work on >-disable-deprecated-until) to have a user-configurable, rolling BC window >now We should use these tools to avoid accumulating too much technical >[...] >Th

Re: [Development] Challenge: adding new method overloads when existing consumers use {} with args

2022-08-15 Thread A . Pönitz
On Sat, Jul 30, 2022 at 01:10:55PM +0200, Giuseppe D'Angelo via Development wrote: > On 28/07/2022 22:54, Thiago Macieira wrote: > > This case can be considered a Category B source incompatible change as per > > https://quips-qt-io.herokuapp.com/quip-0006.html, because it clearly > > introduces am