[Development] Can't get review for more than two years

2023-06-19 Thread Ilya Fedin
Hi, I have a change[1] I made two years ago. People were adding another people to reviewers as no one of them had knowledge to review the change. Since some time people has just started ignoring pings. More than two years has passed but the change is still there, with no votes nor clear explanatio

Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-19 Thread Marc Mutz via Development
Hi, I've tried to summarize this thread, using my own observation on existing use of [[nodiscard]] to fill in C++17 uses, in https://codereview.qt-project.org/c/meta/quips/+/486201 Let's discuss exact wording over in the Gerrit change and come back to the ML for more fundamental questions, if

Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-19 Thread Marc Mutz via Development
On 19.06.23 09:55, Ivan Solovev via Development wrote: > > (*)  That macro that does nothing until C++20 anyway, so I’d also add > the support for the optional string-literal that C++20 also introduces.. > > Our tests actually show that this macro provides an expected warning on > most of the c

Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-19 Thread Ivan Solovev via Development
> (*) That macro that does nothing until C++20 anyway, so I’d also add the > support for the optional string-literal that C++20 also introduces.. Our tests actually show that this macro provides an expected warning on most of the compilers that we use in the CI, even in C++17 mode. IIRC, in my