Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-16 Thread Thiago Macieira
On Friday, 16 June 2023 11:05:30 PDT Giuseppe D'Angelo via Development wrote: > On 16/06/2023 18:00, Thiago Macieira wrote: > > On Friday, 16 June 2023 01:06:33 PDT Stephen Kelly wrote: > >> Make sure you're not hitting > >> > >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96117 > > > > We are i

Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-16 Thread Giuseppe D'Angelo via Development
On 16/06/2023 18:00, Thiago Macieira wrote: On Friday, 16 June 2023 01:06:33 PDT Stephen Kelly wrote: Make sure you're not hitting https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96117 We are indeed hitting that. But there's nothing we can currently do about it. Why can't we turn Q_DECL_EXPORT

Re: [Development] API style guide: scoped enum or not?

2023-06-16 Thread Thiago Macieira
On Friday, 16 June 2023 01:04:30 PDT Stephen Kelly wrote: > >> https://godbolt.org/z/4EWjWhvfa > > > > That's the "massive code update and can't be helped with macros" I > > mentioned in my other email. > > Are you talking about the type of the oopsLostType variable? No, I'm talking about simply

Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-16 Thread Thiago Macieira
On Friday, 16 June 2023 01:06:33 PDT Stephen Kelly wrote: > Make sure you're not hitting > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96117 We are indeed hitting that. But there's nothing we can currently do about it. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Arch

Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-16 Thread Stephen Kelly
On 16/06/2023 07:49, Marc Mutz via Development wrote: On 14.06.23 08:33, Marc Mutz via Development wrote: Two more data points: It doesn't matter whether I write Q_FOO_EXPORT [[nodiscard]] or [[nodicard]] Q_FOO_EXPORT, I always get an error on some compiler. Make sure you're not hitting htt

Re: [Development] API style guide: scoped enum or not?

2023-06-16 Thread Stephen Kelly
On 15/06/2023 23:34, Thiago Macieira wrote: On Thursday, 15 June 2023 15:23:47 PDT Stephen Kelly wrote: And, you can introduce it in a way which is source-compatible until the user upgrades their compiler to a compiler version which implements `using enum`: https://godbolt.org/z/4EWjWhvfa