Re: [Development] Using '#pragma once' instead of include guards?

2022-10-14 Thread Volker Hilsheimer via Development
> On 14 Oct 2022, at 15:47, Kyle Edwards via Development > wrote: > > On 10/14/22 03:15, Eike Ziller wrote: >>> However, there are ways to enforce the use of unique header guards. >>> clang-tidy has an extensible header guard check that can be customized >>> per-project, and plugin loading f

Re: [Development] Using '#pragma once' instead of include guards?

2022-10-14 Thread Kyle Edwards via Development
On 10/14/22 03:15, Eike Ziller wrote: However, there are ways to enforce the use of unique header guards. clang-tidy has an extensible header guard check that can be customized per-project, and plugin loading functionality. Qt could create a clang-tidy plugin that sets up this header guard che

Re: [Development] Duplicated test data tags

2022-10-14 Thread Edward Welbourne via Development
Milian Wolff (Friday, 14 October 2022 3:00 AM) wrote: >> >> I have many times accidentally written bogus code that duplicated the >> >> tags.  Getting a warning is useful, so thanks for working on that! >> >> >> >> But we won't easily spot these in the thousands of lines of outputs a >> >> large

Re: [Development] Duplicated test data tags

2022-10-14 Thread Milian Wolff
On Freitag, 14. Oktober 2022 10:55:54 CEST Edward Welbourne wrote: > Milian Wolff (Friday, 14 October 2022 3:00 AM) > > >> I have many times accidentally written bogus code that duplicated the > >> tags. Getting a warning is useful, so thanks for working on that! > >> > >> But we won't easily sp

Re: [Development] Duplicated test data tags

2022-10-14 Thread Edward Welbourne via Development
Milian Wolff (Friday, 14 October 2022 3:00 AM) >> I have many times accidentally written bogus code that duplicated the >> tags. Getting a warning is useful, so thanks for working on that! >> >> But we won't easily spot these in the thousands of lines of outputs a >> large test suite is generating

Re: [Development] Using '#pragma once' instead of include guards?

2022-10-14 Thread Eike Ziller via Development
> On 13 Oct 2022, at 16:56, Kyle Edwards via Development > wrote: > > On 10/13/22 10:42, Jean-Michaël Celerier wrote: >> >The only way you’d have a strong case with this is if it has some other >> >significant benefit, like compilation speedup. >> >> The main benefit to me is that it entirel